From: Arnd Bergmann <arnd@arndb.de>
To: Barry Song <21cnbao@gmail.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-pwm@vger.kernel.org, Rongjun Ying <Rongjun.ying@csr.com>,
Huayi Li <Huayi.Li@csr.com>,
DL-SHA-WorkGroupLinux <workgroup.linux@csr.com>,
Barry Song <Baohua.Song@csr.com>
Subject: Re: [PATCH v2] pwm: add CSR SiRFSoC PWM driver
Date: Fri, 31 Jan 2014 16:23:56 +0100 [thread overview]
Message-ID: <201401311623.56902.arnd@arndb.de> (raw)
In-Reply-To: <CAGsJ_4xFKytv=Mj9eVwGY7RjyUy2W=iSXvnULKyBETYVzMVbOg@mail.gmail.com>
On Friday 31 January 2014, Barry Song wrote:
> >
> > Is SRC_OSC_RATE the rate of spwm->clk? If so, it would be nice to just call
> > clk_get_rate() here, in case you ever have a chip with a different rate.
> >
>
> SRC_OSC_RATE is the fixed frequency of crystal oscillator, but
> spwm->clk comes from the IO bus. the design is a little strange, pwm
> channels don't use the clock of PWM controller to generate
> period/duty, but use other sources.
How about modeling that other source as a fixed-rate clock in DT
then?
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] pwm: add CSR SiRFSoC PWM driver
Date: Fri, 31 Jan 2014 16:23:56 +0100 [thread overview]
Message-ID: <201401311623.56902.arnd@arndb.de> (raw)
In-Reply-To: <CAGsJ_4xFKytv=Mj9eVwGY7RjyUy2W=iSXvnULKyBETYVzMVbOg@mail.gmail.com>
On Friday 31 January 2014, Barry Song wrote:
> >
> > Is SRC_OSC_RATE the rate of spwm->clk? If so, it would be nice to just call
> > clk_get_rate() here, in case you ever have a chip with a different rate.
> >
>
> SRC_OSC_RATE is the fixed frequency of crystal oscillator, but
> spwm->clk comes from the IO bus. the design is a little strange, pwm
> channels don't use the clock of PWM controller to generate
> period/duty, but use other sources.
How about modeling that other source as a fixed-rate clock in DT
then?
Arnd
next prev parent reply other threads:[~2014-01-31 15:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 5:52 [PATCH v2] pwm: add CSR SiRFSoC PWM driver Barry Song
2014-01-30 5:52 ` Barry Song
2014-01-30 19:49 ` Arnd Bergmann
2014-01-30 19:49 ` Arnd Bergmann
2014-01-31 12:05 ` Barry Song
2014-01-31 12:05 ` Barry Song
2014-01-31 15:23 ` Arnd Bergmann [this message]
2014-01-31 15:23 ` Arnd Bergmann
2014-02-06 10:21 ` Barry Song
2014-02-06 10:21 ` Barry Song
2014-02-06 15:27 ` Arnd Bergmann
2014-02-06 15:27 ` Arnd Bergmann
2014-02-07 2:30 ` Barry Song
2014-02-07 2:30 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201401311623.56902.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=21cnbao@gmail.com \
--cc=Baohua.Song@csr.com \
--cc=Huayi.Li@csr.com \
--cc=Rongjun.ying@csr.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=workgroup.linux@csr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.