* [PATCH] ts-calibrate: Always export TSLIB_CALIBFILE env variable @ 2014-01-31 0:12 Franklin S. Cooper Jr 2014-01-30 22:49 ` Cooper Jr., Franklin 2014-01-30 22:54 ` Maupin, Chase 0 siblings, 2 replies; 6+ messages in thread From: Franklin S. Cooper Jr @ 2014-01-31 0:12 UTC (permalink / raw) To: meta-arago; +Cc: Franklin S. Cooper Jr * Previously TSLIB_CALIBFILE env variable was only being exported if the mmc partition was mounted. * Move the export statement outside of the if statement to insure that this important variable is always exported. Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com> --- .../recipes-graphics/tslib/ts-calibrate-init/init | 3 ++- .../tslib/ts-calibrate-init_1.0.bb | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/meta-arago-extras/recipes-graphics/tslib/ts-calibrate-init/init b/meta-arago-extras/recipes-graphics/tslib/ts-calibrate-init/init index 5d5c0aa..ab19da3 100644 --- a/meta-arago-extras/recipes-graphics/tslib/ts-calibrate-init/init +++ b/meta-arago-extras/recipes-graphics/tslib/ts-calibrate-init/init @@ -31,9 +31,10 @@ mount | grep /media/mmcblk0p1 | grep vfat > /dev/null 2>&1 if [ "$?" = "0" ] then tsfile=/media/mmcblk0p1/pointercal - export TSLIB_CALIBFILE=$tsfile fi +export TSLIB_CALIBFILE=$tsfile + if [ ! -f $tsfile ] ; then echo -n "Calibrating touchscreen (first time only)" ts_calibrate diff --git a/meta-arago-extras/recipes-graphics/tslib/ts-calibrate-init_1.0.bb b/meta-arago-extras/recipes-graphics/tslib/ts-calibrate-init_1.0.bb index dde5c42..0915941 100644 --- a/meta-arago-extras/recipes-graphics/tslib/ts-calibrate-init_1.0.bb +++ b/meta-arago-extras/recipes-graphics/tslib/ts-calibrate-init_1.0.bb @@ -6,7 +6,7 @@ RDEPENDS_${PN} += "tslib" LICENSE = "GPLv2" LIC_FILES_CHKSUM = "file://init;beginline=2;endline=11;md5=4b2e3b15f01cf63d2cb7988afdcc6c60" -PR = "r2" +PR = "r3" S = "${WORKDIR}" -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ts-calibrate: Always export TSLIB_CALIBFILE env variable 2014-01-31 0:12 [PATCH] ts-calibrate: Always export TSLIB_CALIBFILE env variable Franklin S. Cooper Jr @ 2014-01-30 22:49 ` Cooper Jr., Franklin 2014-01-30 22:54 ` Maupin, Chase 1 sibling, 0 replies; 6+ messages in thread From: Cooper Jr., Franklin @ 2014-01-30 22:49 UTC (permalink / raw) To: meta-arago@arago-project.org I made a mistake since this patch should go before " [PATCH] Update sd card partition mount location". I can resubmit the patches to properly show the dependencies if someone wants me to. > -----Original Message----- > From: Cooper Jr., Franklin > Sent: Thursday, January 30, 2014 6:13 PM > To: meta-arago@arago-project.org > Cc: Cooper Jr., Franklin > Subject: [PATCH] ts-calibrate: Always export TSLIB_CALIBFILE env variable > > * Previously TSLIB_CALIBFILE env variable was only being exported if the mmc > partition was mounted. > * Move the export statement outside of the if statement to insure that this > important variable is always exported. > > Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com> > --- > .../recipes-graphics/tslib/ts-calibrate-init/init | 3 ++- > .../tslib/ts-calibrate-init_1.0.bb | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/meta-arago-extras/recipes-graphics/tslib/ts-calibrate-init/init b/meta- > arago-extras/recipes-graphics/tslib/ts-calibrate-init/init > index 5d5c0aa..ab19da3 100644 > --- a/meta-arago-extras/recipes-graphics/tslib/ts-calibrate-init/init > +++ b/meta-arago-extras/recipes-graphics/tslib/ts-calibrate-init/init > @@ -31,9 +31,10 @@ mount | grep /media/mmcblk0p1 | grep vfat > > /dev/null 2>&1 if [ "$?" = "0" ] then > tsfile=/media/mmcblk0p1/pointercal > - export TSLIB_CALIBFILE=$tsfile > fi > > +export TSLIB_CALIBFILE=$tsfile > + > if [ ! -f $tsfile ] ; then > echo -n "Calibrating touchscreen (first time only)" > ts_calibrate > diff --git a/meta-arago-extras/recipes-graphics/tslib/ts-calibrate-init_1.0.bb > b/meta-arago-extras/recipes-graphics/tslib/ts-calibrate-init_1.0.bb > index dde5c42..0915941 100644 > --- a/meta-arago-extras/recipes-graphics/tslib/ts-calibrate-init_1.0.bb > +++ b/meta-arago-extras/recipes-graphics/tslib/ts-calibrate-init_1.0.bb > @@ -6,7 +6,7 @@ RDEPENDS_${PN} += "tslib" > LICENSE = "GPLv2" > LIC_FILES_CHKSUM = > "file://init;beginline=2;endline=11;md5=4b2e3b15f01cf63d2cb7988afdcc6c60 > " > > -PR = "r2" > +PR = "r3" > > S = "${WORKDIR}" > > -- > 1.7.0.4 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ts-calibrate: Always export TSLIB_CALIBFILE env variable 2014-01-31 0:12 [PATCH] ts-calibrate: Always export TSLIB_CALIBFILE env variable Franklin S. Cooper Jr 2014-01-30 22:49 ` Cooper Jr., Franklin @ 2014-01-30 22:54 ` Maupin, Chase 2014-01-30 23:01 ` Cooper Jr., Franklin 1 sibling, 1 reply; 6+ messages in thread From: Maupin, Chase @ 2014-01-30 22:54 UTC (permalink / raw) To: Cooper Jr., Franklin, meta-arago@arago-project.org >-----Original Message----- >From: meta-arago-bounces@arago-project.org [mailto:meta-arago- >bounces@arago-project.org] On Behalf Of Cooper Jr., Franklin >Sent: Thursday, January 30, 2014 6:13 PM >To: meta-arago@arago-project.org >Cc: Cooper Jr., Franklin >Subject: [meta-arago] [PATCH] ts-calibrate: Always export >TSLIB_CALIBFILE env variable > >* Previously TSLIB_CALIBFILE env variable was only being exported >if the mmc > partition was mounted. >* Move the export statement outside of the if statement to insure >that this > important variable is always exported. > >Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com> >--- > .../recipes-graphics/tslib/ts-calibrate-init/init | 3 ++- > .../tslib/ts-calibrate-init_1.0.bb | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > >diff --git a/meta-arago-extras/recipes-graphics/tslib/ts- >calibrate-init/init b/meta-arago-extras/recipes-graphics/tslib/ts- >calibrate-init/init >index 5d5c0aa..ab19da3 100644 >--- a/meta-arago-extras/recipes-graphics/tslib/ts-calibrate- >init/init >+++ b/meta-arago-extras/recipes-graphics/tslib/ts-calibrate- >init/init >@@ -31,9 +31,10 @@ mount | grep /media/mmcblk0p1 | grep vfat > >/dev/null 2>&1 > if [ "$?" = "0" ] > then > tsfile=/media/mmcblk0p1/pointercal >- export TSLIB_CALIBFILE=$tsfile > fi > >+export TSLIB_CALIBFILE=$tsfile This is a nice to have but not strictly required right? Because the default is /etc/pointercal and you only need to reset this if you are pointing to the SD card. Or am I missing something? >+ > if [ ! -f $tsfile ] ; then > echo -n "Calibrating touchscreen (first time only)" > ts_calibrate >diff --git a/meta-arago-extras/recipes-graphics/tslib/ts- >calibrate-init_1.0.bb b/meta-arago-extras/recipes- >graphics/tslib/ts-calibrate-init_1.0.bb >index dde5c42..0915941 100644 >--- a/meta-arago-extras/recipes-graphics/tslib/ts-calibrate- >init_1.0.bb >+++ b/meta-arago-extras/recipes-graphics/tslib/ts-calibrate- >init_1.0.bb >@@ -6,7 +6,7 @@ RDEPENDS_${PN} += "tslib" > LICENSE = "GPLv2" > LIC_FILES_CHKSUM = >"file://init;beginline=2;endline=11;md5=4b2e3b15f01cf63d2cb7988afd >cc6c60" > >-PR = "r2" >+PR = "r3" > > S = "${WORKDIR}" > >-- >1.7.0.4 > >_______________________________________________ >meta-arago mailing list >meta-arago@arago-project.org >http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ts-calibrate: Always export TSLIB_CALIBFILE env variable 2014-01-30 22:54 ` Maupin, Chase @ 2014-01-30 23:01 ` Cooper Jr., Franklin 2014-01-31 14:47 ` Maupin, Chase 0 siblings, 1 reply; 6+ messages in thread From: Cooper Jr., Franklin @ 2014-01-30 23:01 UTC (permalink / raw) To: Maupin, Chase, meta-arago@arago-project.org > -----Original Message----- > From: Maupin, Chase > Sent: Thursday, January 30, 2014 4:54 PM > To: Cooper Jr., Franklin; meta-arago@arago-project.org > Subject: RE: [meta-arago] [PATCH] ts-calibrate: Always export TSLIB_CALIBFILE > env variable > > >-----Original Message----- > >From: meta-arago-bounces@arago-project.org [mailto:meta-arago- > >bounces@arago-project.org] On Behalf Of Cooper Jr., Franklin > >Sent: Thursday, January 30, 2014 6:13 PM > >To: meta-arago@arago-project.org > >Cc: Cooper Jr., Franklin > >Subject: [meta-arago] [PATCH] ts-calibrate: Always export > >TSLIB_CALIBFILE env variable > > > >* Previously TSLIB_CALIBFILE env variable was only being exported if > >the mmc > > partition was mounted. > >* Move the export statement outside of the if statement to insure that > >this > > important variable is always exported. > > > >Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com> > >--- > > .../recipes-graphics/tslib/ts-calibrate-init/init | 3 ++- > > .../tslib/ts-calibrate-init_1.0.bb | 2 +- > > 2 files changed, 3 insertions(+), 2 deletions(-) > > > >diff --git a/meta-arago-extras/recipes-graphics/tslib/ts- > >calibrate-init/init b/meta-arago-extras/recipes-graphics/tslib/ts- > >calibrate-init/init > >index 5d5c0aa..ab19da3 100644 > >--- a/meta-arago-extras/recipes-graphics/tslib/ts-calibrate- > >init/init > >+++ b/meta-arago-extras/recipes-graphics/tslib/ts-calibrate- > >init/init > >@@ -31,9 +31,10 @@ mount | grep /media/mmcblk0p1 | grep vfat > > >/dev/null 2>&1 if [ "$?" = "0" ] then > > tsfile=/media/mmcblk0p1/pointercal > >- export TSLIB_CALIBFILE=$tsfile > > fi > > > >+export TSLIB_CALIBFILE=$tsfile > > This is a nice to have but not strictly required right? Because the default is > /etc/pointercal and you only need to reset this if you are pointing to the SD card. > Or am I missing something? [Franklin] Your right if tslib by default assumes that file is located at /etc/pointercal but at the time I didn't think that was the case. After searching some more that is indeed the case: http://manpages.ubuntu.com/manpages/raring/man5/ts.conf.5.html So we can take this patch or leave it. > > >+ > > if [ ! -f $tsfile ] ; then > > echo -n "Calibrating touchscreen (first time only)" > > ts_calibrate > >diff --git a/meta-arago-extras/recipes-graphics/tslib/ts- > >calibrate-init_1.0.bb b/meta-arago-extras/recipes- > >graphics/tslib/ts-calibrate-init_1.0.bb > >index dde5c42..0915941 100644 > >--- a/meta-arago-extras/recipes-graphics/tslib/ts-calibrate- > >init_1.0.bb > >+++ b/meta-arago-extras/recipes-graphics/tslib/ts-calibrate- > >init_1.0.bb > >@@ -6,7 +6,7 @@ RDEPENDS_${PN} += "tslib" > > LICENSE = "GPLv2" > > LIC_FILES_CHKSUM = > >"file://init;beginline=2;endline=11;md5=4b2e3b15f01cf63d2cb7988afd > >cc6c60" > > > >-PR = "r2" > >+PR = "r3" > > > > S = "${WORKDIR}" > > > >-- > >1.7.0.4 > > > >_______________________________________________ > >meta-arago mailing list > >meta-arago@arago-project.org > >http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ts-calibrate: Always export TSLIB_CALIBFILE env variable 2014-01-30 23:01 ` Cooper Jr., Franklin @ 2014-01-31 14:47 ` Maupin, Chase 2014-01-31 23:18 ` Denys Dmytriyenko 0 siblings, 1 reply; 6+ messages in thread From: Maupin, Chase @ 2014-01-31 14:47 UTC (permalink / raw) To: Cooper Jr., Franklin, meta-arago@arago-project.org >-----Original Message----- >From: Cooper Jr., Franklin >Sent: Thursday, January 30, 2014 5:01 PM >To: Maupin, Chase; meta-arago@arago-project.org >Subject: RE: [meta-arago] [PATCH] ts-calibrate: Always export >TSLIB_CALIBFILE env variable > > > >> -----Original Message----- >> From: Maupin, Chase >> Sent: Thursday, January 30, 2014 4:54 PM >> To: Cooper Jr., Franklin; meta-arago@arago-project.org >> Subject: RE: [meta-arago] [PATCH] ts-calibrate: Always export >TSLIB_CALIBFILE >> env variable >> >> >-----Original Message----- >> >From: meta-arago-bounces@arago-project.org [mailto:meta-arago- >> >bounces@arago-project.org] On Behalf Of Cooper Jr., Franklin >> >Sent: Thursday, January 30, 2014 6:13 PM >> >To: meta-arago@arago-project.org >> >Cc: Cooper Jr., Franklin >> >Subject: [meta-arago] [PATCH] ts-calibrate: Always export >> >TSLIB_CALIBFILE env variable >> > >> >* Previously TSLIB_CALIBFILE env variable was only being >exported if >> >the mmc >> > partition was mounted. >> >* Move the export statement outside of the if statement to >insure that >> >this >> > important variable is always exported. >> > >> >Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com> >> >--- >> > .../recipes-graphics/tslib/ts-calibrate-init/init | 3 ++- >> > .../tslib/ts-calibrate-init_1.0.bb | 2 +- >> > 2 files changed, 3 insertions(+), 2 deletions(-) >> > >> >diff --git a/meta-arago-extras/recipes-graphics/tslib/ts- >> >calibrate-init/init b/meta-arago-extras/recipes- >graphics/tslib/ts- >> >calibrate-init/init >> >index 5d5c0aa..ab19da3 100644 >> >--- a/meta-arago-extras/recipes-graphics/tslib/ts-calibrate- >> >init/init >> >+++ b/meta-arago-extras/recipes-graphics/tslib/ts-calibrate- >> >init/init >> >@@ -31,9 +31,10 @@ mount | grep /media/mmcblk0p1 | grep vfat > >> >/dev/null 2>&1 if [ "$?" = "0" ] then >> > tsfile=/media/mmcblk0p1/pointercal >> >- export TSLIB_CALIBFILE=$tsfile >> > fi >> > >> >+export TSLIB_CALIBFILE=$tsfile >> >> This is a nice to have but not strictly required right? Because >the default is >> /etc/pointercal and you only need to reset this if you are >pointing to the SD card. >> Or am I missing something? >[Franklin] Your right if tslib by default assumes that file is >located at /etc/pointercal but at the time I didn't think that was >the case. > >After searching some more that is indeed the case: >http://manpages.ubuntu.com/manpages/raring/man5/ts.conf.5.html > >So we can take this patch or leave it. I'm OK with it since it makes things clear, I was just checking in case there was something I was missing. > >> >> >+ >> > if [ ! -f $tsfile ] ; then >> > echo -n "Calibrating touchscreen (first time only)" >> > ts_calibrate >> >diff --git a/meta-arago-extras/recipes-graphics/tslib/ts- >> >calibrate-init_1.0.bb b/meta-arago-extras/recipes- >> >graphics/tslib/ts-calibrate-init_1.0.bb >> >index dde5c42..0915941 100644 >> >--- a/meta-arago-extras/recipes-graphics/tslib/ts-calibrate- >> >init_1.0.bb >> >+++ b/meta-arago-extras/recipes-graphics/tslib/ts-calibrate- >> >init_1.0.bb >> >@@ -6,7 +6,7 @@ RDEPENDS_${PN} += "tslib" >> > LICENSE = "GPLv2" >> > LIC_FILES_CHKSUM = >> >>"file://init;beginline=2;endline=11;md5=4b2e3b15f01cf63d2cb7988af >d >> >cc6c60" >> > >> >-PR = "r2" >> >+PR = "r3" >> > >> > S = "${WORKDIR}" >> > >> >-- >> >1.7.0.4 >> > >> >_______________________________________________ >> >meta-arago mailing list >> >meta-arago@arago-project.org >> >http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ts-calibrate: Always export TSLIB_CALIBFILE env variable 2014-01-31 14:47 ` Maupin, Chase @ 2014-01-31 23:18 ` Denys Dmytriyenko 0 siblings, 0 replies; 6+ messages in thread From: Denys Dmytriyenko @ 2014-01-31 23:18 UTC (permalink / raw) To: Maupin, Chase; +Cc: meta-arago@arago-project.org, Cooper Jr., Franklin On Fri, Jan 31, 2014 at 02:47:23PM +0000, Maupin, Chase wrote: > >-----Original Message----- > >From: Cooper Jr., Franklin > >Sent: Thursday, January 30, 2014 5:01 PM > >To: Maupin, Chase; meta-arago@arago-project.org > >Subject: RE: [meta-arago] [PATCH] ts-calibrate: Always export > >TSLIB_CALIBFILE env variable > > > > > > > >> -----Original Message----- > >> From: Maupin, Chase > >> Sent: Thursday, January 30, 2014 4:54 PM > >> To: Cooper Jr., Franklin; meta-arago@arago-project.org > >> Subject: RE: [meta-arago] [PATCH] ts-calibrate: Always export > >TSLIB_CALIBFILE > >> env variable > >> > >> >-----Original Message----- > >> >From: meta-arago-bounces@arago-project.org [mailto:meta-arago- > >> >bounces@arago-project.org] On Behalf Of Cooper Jr., Franklin > >> >Sent: Thursday, January 30, 2014 6:13 PM > >> >To: meta-arago@arago-project.org > >> >Cc: Cooper Jr., Franklin > >> >Subject: [meta-arago] [PATCH] ts-calibrate: Always export > >> >TSLIB_CALIBFILE env variable > >> > > >> >* Previously TSLIB_CALIBFILE env variable was only being > >exported if > >> >the mmc > >> > partition was mounted. > >> >* Move the export statement outside of the if statement to > >insure that > >> >this > >> > important variable is always exported. > >> > > >> >Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com> > >> >--- > >> > .../recipes-graphics/tslib/ts-calibrate-init/init | 3 ++- > >> > .../tslib/ts-calibrate-init_1.0.bb | 2 +- > >> > 2 files changed, 3 insertions(+), 2 deletions(-) > >> > > >> >diff --git a/meta-arago-extras/recipes-graphics/tslib/ts- > >> >calibrate-init/init b/meta-arago-extras/recipes- > >graphics/tslib/ts- > >> >calibrate-init/init > >> >index 5d5c0aa..ab19da3 100644 > >> >--- a/meta-arago-extras/recipes-graphics/tslib/ts-calibrate- > >> >init/init > >> >+++ b/meta-arago-extras/recipes-graphics/tslib/ts-calibrate- > >> >init/init > >> >@@ -31,9 +31,10 @@ mount | grep /media/mmcblk0p1 | grep vfat > > >> >/dev/null 2>&1 if [ "$?" = "0" ] then > >> > tsfile=/media/mmcblk0p1/pointercal > >> >- export TSLIB_CALIBFILE=$tsfile > >> > fi > >> > > >> >+export TSLIB_CALIBFILE=$tsfile > >> > >> This is a nice to have but not strictly required right? Because > >the default is > >> /etc/pointercal and you only need to reset this if you are > >pointing to the SD card. > >> Or am I missing something? > >[Franklin] Your right if tslib by default assumes that file is > >located at /etc/pointercal but at the time I didn't think that was > >the case. > > > >After searching some more that is indeed the case: > >http://manpages.ubuntu.com/manpages/raring/man5/ts.conf.5.html > > > >So we can take this patch or leave it. > > I'm OK with it since it makes things clear, I was just checking in case > there was something I was missing. Franklin, after what we've discussed above and the optional nature of this patch, if you still really want this in, would mind updating the patch with the new /run/media location, which I'm about to push? If not, we can just drop it... Thanks. > >> > if [ ! -f $tsfile ] ; then > >> > echo -n "Calibrating touchscreen (first time only)" > >> > ts_calibrate > >> >diff --git a/meta-arago-extras/recipes-graphics/tslib/ts- > >> >calibrate-init_1.0.bb b/meta-arago-extras/recipes- > >> >graphics/tslib/ts-calibrate-init_1.0.bb > >> >index dde5c42..0915941 100644 > >> >--- a/meta-arago-extras/recipes-graphics/tslib/ts-calibrate- > >> >init_1.0.bb > >> >+++ b/meta-arago-extras/recipes-graphics/tslib/ts-calibrate- > >> >init_1.0.bb > >> >@@ -6,7 +6,7 @@ RDEPENDS_${PN} += "tslib" > >> > LICENSE = "GPLv2" > >> > LIC_FILES_CHKSUM = > >> > >>"file://init;beginline=2;endline=11;md5=4b2e3b15f01cf63d2cb7988af > >d > >> >cc6c60" > >> > > >> >-PR = "r2" > >> >+PR = "r3" > >> > > >> > S = "${WORKDIR}" > >> > > >> >-- > >> >1.7.0.4 > >> > > >> >_______________________________________________ > >> >meta-arago mailing list > >> >meta-arago@arago-project.org > >> >http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago > _______________________________________________ > meta-arago mailing list > meta-arago@arago-project.org > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-01-31 23:18 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-01-31 0:12 [PATCH] ts-calibrate: Always export TSLIB_CALIBFILE env variable Franklin S. Cooper Jr 2014-01-30 22:49 ` Cooper Jr., Franklin 2014-01-30 22:54 ` Maupin, Chase 2014-01-30 23:01 ` Cooper Jr., Franklin 2014-01-31 14:47 ` Maupin, Chase 2014-01-31 23:18 ` Denys Dmytriyenko
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.