From: Christoffer Dall <christoffer.dall@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: kvm-devel <kvm@vger.kernel.org>,
kvm-ppc <kvm-ppc@vger.kernel.org>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
Patch Tracking <patches@linaro.org>,
Marc Zyngier <marc.zyngier@arm.com>,
Alexander Graf <agraf@suse.de>,
Paolo Bonzini <pbonzini@redhat.com>,
"gleb@kernel.org" <gleb@kernel.org>
Subject: Re: [PATCH v3] KVM: Specify byte order for KVM_EXIT_MMIO
Date: Sun, 02 Feb 2014 21:02:51 +0000 [thread overview]
Message-ID: <20140202210251.GD3570@cbox> (raw)
In-Reply-To: <CAFEAcA8n+sZamE_aY8zBxwWcN9rx5GwMN_j21wrkc-t0YNj_-g@mail.gmail.com>
On Sun, Feb 02, 2014 at 12:50:47PM +0000, Peter Maydell wrote:
> On 28 January 2014 16:28, Christoffer Dall <christoffer.dall@linaro.org> wrote:
> > diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt
> > index 366bf4b..e11f09d 100644
> > --- a/Documentation/virtual/kvm/api.txt
> > +++ b/Documentation/virtual/kvm/api.txt
> > @@ -2565,6 +2565,10 @@ executed a memory-mapped I/O instruction which could not be satisfied
> > by kvm. The 'data' member contains the written data if 'is_write' is
> > true, and should be filled by application code otherwise.
> >
> > +The 'data' member contains, in its first 'len' bytes, the value as it would
> > +appear if the VCPU performed a load or store of the appropriate width directly
> > +to the byte array.
>
> I don't think you need my acked-by as such (though if you want it you
> have it), but since I was one of the people arguing in this thread I guess
> I should say specifically that I'm happy with this wording.
>
Paolo, Gleb,
Will you apply this one directly (assuming you also agree) or do you
want me to include it as part of a pull request?
Thanks,
-Christoffer
WARNING: multiple messages have this Message-ID (diff)
From: Christoffer Dall <christoffer.dall@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: kvm-devel <kvm@vger.kernel.org>,
kvm-ppc <kvm-ppc@vger.kernel.org>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
Patch Tracking <patches@linaro.org>,
Marc Zyngier <marc.zyngier@arm.com>,
Alexander Graf <agraf@suse.de>,
Paolo Bonzini <pbonzini@redhat.com>,
"gleb@kernel.org" <gleb@kernel.org>
Subject: Re: [PATCH v3] KVM: Specify byte order for KVM_EXIT_MMIO
Date: Sun, 2 Feb 2014 13:02:51 -0800 [thread overview]
Message-ID: <20140202210251.GD3570@cbox> (raw)
In-Reply-To: <CAFEAcA8n+sZamE_aY8zBxwWcN9rx5GwMN_j21wrkc-t0YNj_-g@mail.gmail.com>
On Sun, Feb 02, 2014 at 12:50:47PM +0000, Peter Maydell wrote:
> On 28 January 2014 16:28, Christoffer Dall <christoffer.dall@linaro.org> wrote:
> > diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt
> > index 366bf4b..e11f09d 100644
> > --- a/Documentation/virtual/kvm/api.txt
> > +++ b/Documentation/virtual/kvm/api.txt
> > @@ -2565,6 +2565,10 @@ executed a memory-mapped I/O instruction which could not be satisfied
> > by kvm. The 'data' member contains the written data if 'is_write' is
> > true, and should be filled by application code otherwise.
> >
> > +The 'data' member contains, in its first 'len' bytes, the value as it would
> > +appear if the VCPU performed a load or store of the appropriate width directly
> > +to the byte array.
>
> I don't think you need my acked-by as such (though if you want it you
> have it), but since I was one of the people arguing in this thread I guess
> I should say specifically that I'm happy with this wording.
>
Paolo, Gleb,
Will you apply this one directly (assuming you also agree) or do you
want me to include it as part of a pull request?
Thanks,
-Christoffer
next prev parent reply other threads:[~2014-02-02 21:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 16:28 [PATCH v3] KVM: Specify byte order for KVM_EXIT_MMIO Christoffer Dall
2014-01-28 16:28 ` Christoffer Dall
2014-01-29 14:31 ` Alexander Graf
2014-01-29 14:31 ` Alexander Graf
2014-02-02 12:50 ` Peter Maydell
2014-02-02 12:50 ` Peter Maydell
2014-02-02 21:02 ` Christoffer Dall [this message]
2014-02-02 21:02 ` Christoffer Dall
2014-03-14 4:27 ` Christoffer Dall
2014-03-14 4:27 ` Christoffer Dall
2014-03-17 19:00 ` Marc Zyngier
2014-03-17 19:00 ` Marc Zyngier
2014-03-29 14:45 ` Paolo Bonzini
2014-03-29 14:45 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140202210251.GD3570@cbox \
--to=christoffer.dall@linaro.org \
--cc=agraf@suse.de \
--cc=gleb@kernel.org \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=marc.zyngier@arm.com \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.