* [PATCH 1/2] mfd: max14577: max14577_{suspend,resume}() should depend on CONFIG_PM_SLEEP
@ 2014-01-26 10:38 Geert Uytterhoeven
2014-01-26 10:38 ` [PATCH 2/2] mfd: sec-core: sec_pmic_{suspend,resume}() " Geert Uytterhoeven
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Geert Uytterhoeven @ 2014-01-26 10:38 UTC (permalink / raw)
To: Samuel Ortiz, Lee Jones, Sangbeom Kim, Krzysztof Kozlowski,
Chanwoo Choi
Cc: linux-kernel, Geert Uytterhoeven
If CONFIG_PM_SLEEP=n:
drivers/mfd/max14577.c:177: warning: ‘max14577_suspend’ defined but not used
drivers/mfd/max14577.c:200: warning: ‘max14577_resume’ defined but not used
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/mfd/max14577.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c
index ac514fb2b877..71aa14a6bfbb 100644
--- a/drivers/mfd/max14577.c
+++ b/drivers/mfd/max14577.c
@@ -173,6 +173,7 @@ static const struct i2c_device_id max14577_i2c_id[] = {
};
MODULE_DEVICE_TABLE(i2c, max14577_i2c_id);
+#ifdef CONFIG_PM_SLEEP
static int max14577_suspend(struct device *dev)
{
struct i2c_client *i2c = container_of(dev, struct i2c_client, dev);
@@ -208,6 +209,7 @@ static int max14577_resume(struct device *dev)
return 0;
}
+#endif /* CONFIG_PM_SLEEP */
static struct of_device_id max14577_dt_match[] = {
{ .compatible = "maxim,max14577", },
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 2/2] mfd: sec-core: sec_pmic_{suspend,resume}() should depend on CONFIG_PM_SLEEP
2014-01-26 10:38 [PATCH 1/2] mfd: max14577: max14577_{suspend,resume}() should depend on CONFIG_PM_SLEEP Geert Uytterhoeven
@ 2014-01-26 10:38 ` Geert Uytterhoeven
2014-02-03 10:35 ` Lee Jones
2014-01-27 8:28 ` [PATCH 1/2] mfd: max14577: max14577_{suspend,resume}() " Krzysztof Kozlowski
2014-02-03 10:34 ` Lee Jones
2 siblings, 1 reply; 7+ messages in thread
From: Geert Uytterhoeven @ 2014-01-26 10:38 UTC (permalink / raw)
To: Samuel Ortiz, Lee Jones, Sangbeom Kim, Krzysztof Kozlowski,
Chanwoo Choi
Cc: linux-kernel, Geert Uytterhoeven
If CONFIG_PM_SLEEP=n:
drivers/mfd/sec-core.c:349: warning: ‘sec_pmic_suspend’ defined but not used
drivers/mfd/sec-core.c:371: warning: ‘sec_pmic_resume’ defined but not used
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/mfd/sec-core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
index e4671088f075..dbc39e676cbd 100644
--- a/drivers/mfd/sec-core.c
+++ b/drivers/mfd/sec-core.c
@@ -345,6 +345,7 @@ static int sec_pmic_remove(struct i2c_client *i2c)
return 0;
}
+#ifdef CONFIG_PM_SLEEP
static int sec_pmic_suspend(struct device *dev)
{
struct i2c_client *i2c = container_of(dev, struct i2c_client, dev);
@@ -379,6 +380,7 @@ static int sec_pmic_resume(struct device *dev)
return 0;
}
+#endif /* CONFIG_PM_SLEEP */
static SIMPLE_DEV_PM_OPS(sec_pmic_pm_ops, sec_pmic_suspend, sec_pmic_resume);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 2/2] mfd: sec-core: sec_pmic_{suspend,resume}() should depend on CONFIG_PM_SLEEP
2014-01-26 10:38 ` [PATCH 2/2] mfd: sec-core: sec_pmic_{suspend,resume}() " Geert Uytterhoeven
@ 2014-02-03 10:35 ` Lee Jones
0 siblings, 0 replies; 7+ messages in thread
From: Lee Jones @ 2014-02-03 10:35 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Samuel Ortiz, Sangbeom Kim, Krzysztof Kozlowski, Chanwoo Choi,
linux-kernel
> If CONFIG_PM_SLEEP=n:
>
> drivers/mfd/sec-core.c:349: warning: ‘sec_pmic_suspend’ defined but not used
> drivers/mfd/sec-core.c:371: warning: ‘sec_pmic_resume’ defined but not used
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/mfd/sec-core.c | 2 ++
> 1 file changed, 2 insertions(+)
Applied to my -fixes branch.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] mfd: max14577: max14577_{suspend,resume}() should depend on CONFIG_PM_SLEEP
2014-01-26 10:38 [PATCH 1/2] mfd: max14577: max14577_{suspend,resume}() should depend on CONFIG_PM_SLEEP Geert Uytterhoeven
2014-01-26 10:38 ` [PATCH 2/2] mfd: sec-core: sec_pmic_{suspend,resume}() " Geert Uytterhoeven
@ 2014-01-27 8:28 ` Krzysztof Kozlowski
2014-01-27 8:31 ` Geert Uytterhoeven
2014-02-03 10:34 ` Lee Jones
2 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2014-01-27 8:28 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Samuel Ortiz, Lee Jones, Sangbeom Kim, Chanwoo Choi, linux-kernel
On Sun, 2014-01-26 at 11:38 +0100, Geert Uytterhoeven wrote:
> If CONFIG_PM_SLEEP=n:
>
> drivers/mfd/max14577.c:177: warning: ‘max14577_suspend’ defined but not used
> drivers/mfd/max14577.c:200: warning: ‘max14577_resume’ defined but not used
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/mfd/max14577.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c
> index ac514fb2b877..71aa14a6bfbb 100644
> --- a/drivers/mfd/max14577.c
> +++ b/drivers/mfd/max14577.c
> @@ -173,6 +173,7 @@ static const struct i2c_device_id max14577_i2c_id[] = {
> };
> MODULE_DEVICE_TABLE(i2c, max14577_i2c_id);
>
> +#ifdef CONFIG_PM_SLEEP
> static int max14577_suspend(struct device *dev)
> {
> struct i2c_client *i2c = container_of(dev, struct i2c_client, dev);
> @@ -208,6 +209,7 @@ static int max14577_resume(struct device *dev)
>
> return 0;
> }
> +#endif /* CONFIG_PM_SLEEP */
>
> static struct of_device_id max14577_dt_match[] = {
> { .compatible = "maxim,max14577", },
Same here:
http://thread.gmane.org/gmane.linux.kernel/1615513/focus=1615563
although I don't mind if your patch comes in :).
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 1/2] mfd: max14577: max14577_{suspend,resume}() should depend on CONFIG_PM_SLEEP
2014-01-27 8:28 ` [PATCH 1/2] mfd: max14577: max14577_{suspend,resume}() " Krzysztof Kozlowski
@ 2014-01-27 8:31 ` Geert Uytterhoeven
2014-01-27 9:54 ` Lee Jones
0 siblings, 1 reply; 7+ messages in thread
From: Geert Uytterhoeven @ 2014-01-27 8:31 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Samuel Ortiz, Lee Jones, Sangbeom Kim, Chanwoo Choi,
linux-kernel@vger.kernel.org
On Mon, Jan 27, 2014 at 9:28 AM, Krzysztof Kozlowski
<k.kozlowski@samsung.com> wrote:
> On Sun, 2014-01-26 at 11:38 +0100, Geert Uytterhoeven wrote:
>> If CONFIG_PM_SLEEP=n:
>>
>> drivers/mfd/max14577.c:177: warning: ‘max14577_suspend’ defined but not used
>> drivers/mfd/max14577.c:200: warning: ‘max14577_resume’ defined but not used
>>
>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> ---
>> drivers/mfd/max14577.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c
>> index ac514fb2b877..71aa14a6bfbb 100644
>> --- a/drivers/mfd/max14577.c
>> +++ b/drivers/mfd/max14577.c
>> @@ -173,6 +173,7 @@ static const struct i2c_device_id max14577_i2c_id[] = {
>> };
>> MODULE_DEVICE_TABLE(i2c, max14577_i2c_id);
>>
>> +#ifdef CONFIG_PM_SLEEP
>> static int max14577_suspend(struct device *dev)
>> {
>> struct i2c_client *i2c = container_of(dev, struct i2c_client, dev);
>> @@ -208,6 +209,7 @@ static int max14577_resume(struct device *dev)
>>
>> return 0;
>> }
>> +#endif /* CONFIG_PM_SLEEP */
>>
>> static struct of_device_id max14577_dt_match[] = {
>> { .compatible = "maxim,max14577", },
>
> Same here:
> http://thread.gmane.org/gmane.linux.kernel/1615513/focus=1615563
> although I don't mind if your patch comes in :).
Sorry, missed those.
It's a pity these known fixes don't go in together with the code that introduces
them...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 1/2] mfd: max14577: max14577_{suspend,resume}() should depend on CONFIG_PM_SLEEP
2014-01-27 8:31 ` Geert Uytterhoeven
@ 2014-01-27 9:54 ` Lee Jones
0 siblings, 0 replies; 7+ messages in thread
From: Lee Jones @ 2014-01-27 9:54 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Krzysztof Kozlowski, Samuel Ortiz, Sangbeom Kim, Chanwoo Choi,
linux-kernel@vger.kernel.org
> >> If CONFIG_PM_SLEEP=n:
> >>
> >> drivers/mfd/max14577.c:177: warning: ‘max14577_suspend’ defined but not used
> >> drivers/mfd/max14577.c:200: warning: ‘max14577_resume’ defined but not used
> >>
> >> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> >> ---
> >> drivers/mfd/max14577.c | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>
> >> diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c
> >> index ac514fb2b877..71aa14a6bfbb 100644
> >> --- a/drivers/mfd/max14577.c
> >> +++ b/drivers/mfd/max14577.c
> >> @@ -173,6 +173,7 @@ static const struct i2c_device_id max14577_i2c_id[] = {
> >> };
> >> MODULE_DEVICE_TABLE(i2c, max14577_i2c_id);
> >>
> >> +#ifdef CONFIG_PM_SLEEP
> >> static int max14577_suspend(struct device *dev)
> >> {
> >> struct i2c_client *i2c = container_of(dev, struct i2c_client, dev);
> >> @@ -208,6 +209,7 @@ static int max14577_resume(struct device *dev)
> >>
> >> return 0;
> >> }
> >> +#endif /* CONFIG_PM_SLEEP */
> >>
> >> static struct of_device_id max14577_dt_match[] = {
> >> { .compatible = "maxim,max14577", },
> >
> > Same here:
> > http://thread.gmane.org/gmane.linux.kernel/1615513/focus=1615563
> > although I don't mind if your patch comes in :).
>
> Sorry, missed those.
> It's a pity these known fixes don't go in together with the code that introduces
> them...
Great idea. Can I borrow your time machine? ;)
Or, we can use the -rcs, as this is what they were designed for.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] mfd: max14577: max14577_{suspend,resume}() should depend on CONFIG_PM_SLEEP
2014-01-26 10:38 [PATCH 1/2] mfd: max14577: max14577_{suspend,resume}() should depend on CONFIG_PM_SLEEP Geert Uytterhoeven
2014-01-26 10:38 ` [PATCH 2/2] mfd: sec-core: sec_pmic_{suspend,resume}() " Geert Uytterhoeven
2014-01-27 8:28 ` [PATCH 1/2] mfd: max14577: max14577_{suspend,resume}() " Krzysztof Kozlowski
@ 2014-02-03 10:34 ` Lee Jones
2 siblings, 0 replies; 7+ messages in thread
From: Lee Jones @ 2014-02-03 10:34 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Samuel Ortiz, Sangbeom Kim, Krzysztof Kozlowski, Chanwoo Choi,
linux-kernel
> If CONFIG_PM_SLEEP=n:
>
> drivers/mfd/max14577.c:177: warning: ‘max14577_suspend’ defined but not used
> drivers/mfd/max14577.c:200: warning: ‘max14577_resume’ defined but not used
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/mfd/max14577.c | 2 ++
> 1 file changed, 2 insertions(+)
Applied to my -fixes branch.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-02-03 10:35 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-26 10:38 [PATCH 1/2] mfd: max14577: max14577_{suspend,resume}() should depend on CONFIG_PM_SLEEP Geert Uytterhoeven
2014-01-26 10:38 ` [PATCH 2/2] mfd: sec-core: sec_pmic_{suspend,resume}() " Geert Uytterhoeven
2014-02-03 10:35 ` Lee Jones
2014-01-27 8:28 ` [PATCH 1/2] mfd: max14577: max14577_{suspend,resume}() " Krzysztof Kozlowski
2014-01-27 8:31 ` Geert Uytterhoeven
2014-01-27 9:54 ` Lee Jones
2014-02-03 10:34 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.