From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Hans de Goede <hdegoede@redhat.com>, Tejun Heo <tj@kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-ide@vger.kernel.org, Oliver Schinagl <oliver@schinagl.nl>,
Richard Zhu <Hong-Xing.Zhu@freescale.com>,
linux-sunxi@googlegroups.com,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Roger Quadros <rogerq@ti.com>
Subject: Re: [PATCH v5 08/14] ahci-platform: "Library-ise" suspend / resume functionality
Date: Mon, 3 Feb 2014 15:53:45 +0100 [thread overview]
Message-ID: <201402031553.46083.arnd@arndb.de> (raw)
In-Reply-To: <1390417489-5354-9-git-send-email-hdegoede@redhat.com>
On Wednesday 22 January 2014, Hans de Goede wrote:
> --- a/include/linux/ahci_platform.h
> +++ b/include/linux/ahci_platform.h
> @@ -50,4 +50,11 @@ int ahci_platform_init_host(struct platform_device *pdev,
> unsigned int force_port_map,
> unsigned int mask_port_map);
>
> +#ifdef CONFIG_PM_SLEEP
> +int ahci_platform_suspend_host(struct device *dev);
> +int ahci_platform_resume_host(struct device *dev);
> +int ahci_platform_suspend(struct device *dev);
> +int ahci_platform_resume(struct device *dev);
> +#endif
> +
Not sure if the #ifdef does any good here. Normally, we don't hide declarations
so we can do stuff like
if (IS_ENABLED(CONFIG_PM_SLEEP))
ret = ahci_platform_suspend_host(dev);
and expect the code to compile and link just fine.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 08/14] ahci-platform: "Library-ise" suspend / resume functionality
Date: Mon, 3 Feb 2014 15:53:45 +0100 [thread overview]
Message-ID: <201402031553.46083.arnd@arndb.de> (raw)
In-Reply-To: <1390417489-5354-9-git-send-email-hdegoede@redhat.com>
On Wednesday 22 January 2014, Hans de Goede wrote:
> --- a/include/linux/ahci_platform.h
> +++ b/include/linux/ahci_platform.h
> @@ -50,4 +50,11 @@ int ahci_platform_init_host(struct platform_device *pdev,
> unsigned int force_port_map,
> unsigned int mask_port_map);
>
> +#ifdef CONFIG_PM_SLEEP
> +int ahci_platform_suspend_host(struct device *dev);
> +int ahci_platform_resume_host(struct device *dev);
> +int ahci_platform_suspend(struct device *dev);
> +int ahci_platform_resume(struct device *dev);
> +#endif
> +
Not sure if the #ifdef does any good here. Normally, we don't hide declarations
so we can do stuff like
if (IS_ENABLED(CONFIG_PM_SLEEP))
ret = ahci_platform_suspend_host(dev);
and expect the code to compile and link just fine.
Arnd
next prev parent reply other threads:[~2014-02-03 14:53 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-22 19:04 [PATCH v5 00/14] ahci: library-ise ahci_platform, add sunxi driver and cleanup imx driver Hans de Goede
2014-01-22 19:04 ` Hans de Goede
[not found] ` <1390417489-5354-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-01-22 19:04 ` [PATCH v5 01/14] libahci: Allow drivers to override start_engine Hans de Goede
2014-01-22 19:04 ` Hans de Goede
2014-01-22 19:04 ` [PATCH v5 02/14] libahci: Move ahci_host_priv declaration to include/linux/ahci.h Hans de Goede
2014-01-22 19:04 ` Hans de Goede
2014-01-22 19:04 ` [PATCH v5 03/14] ahci-platform: Pass ahci_host_priv ptr to ahci_platform_data init method Hans de Goede
2014-01-22 19:04 ` Hans de Goede
2014-01-22 19:04 ` [PATCH v5 04/14] ahci-platform: Add support for devices with more then 1 clock Hans de Goede
2014-01-22 19:04 ` Hans de Goede
2014-01-22 19:04 ` [PATCH v5 05/14] ahci-platform: Add support for an optional regulator for sata-target power Hans de Goede
2014-01-22 19:04 ` Hans de Goede
2014-01-22 19:04 ` [PATCH v5 06/14] ahci-platform: Add enable_ / disable_resources helper functions Hans de Goede
2014-01-22 19:04 ` Hans de Goede
2014-01-22 19:04 ` [PATCH v5 07/14] ahci-platform: "Library-ise" ahci_probe functionality Hans de Goede
2014-01-22 19:04 ` Hans de Goede
2014-01-27 10:39 ` Roger Quadros
2014-01-27 10:39 ` Roger Quadros
[not found] ` <52E63778.5000509-l0cyMroinI0@public.gmane.org>
2014-01-27 10:51 ` Hans de Goede
2014-01-27 10:51 ` Hans de Goede
[not found] ` <52E63A1F.6080301-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-01-27 11:03 ` Roger Quadros
2014-01-27 11:03 ` Roger Quadros
[not found] ` <52E63D08.6080704-l0cyMroinI0@public.gmane.org>
2014-01-27 11:28 ` Hans de Goede
2014-01-27 11:28 ` Hans de Goede
[not found] ` <52E642F7.3000308-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-01-27 14:27 ` Roger Quadros
2014-01-27 14:27 ` Roger Quadros
2014-01-22 19:04 ` [PATCH v5 08/14] ahci-platform: "Library-ise" suspend / resume functionality Hans de Goede
2014-01-22 19:04 ` Hans de Goede
2014-02-03 14:53 ` Arnd Bergmann [this message]
2014-02-03 14:53 ` Arnd Bergmann
[not found] ` <201402031553.46083.arnd-r2nGTMty4D4@public.gmane.org>
2014-02-04 10:20 ` Hans de Goede
2014-02-04 10:20 ` Hans de Goede
2014-01-22 19:04 ` [PATCH v5 09/14] ARM: sunxi: Add support for Allwinner SUNXi SoCs sata to ahci_platform Hans de Goede
2014-01-22 19:04 ` Hans de Goede
2014-01-22 19:04 ` [PATCH v5 10/14] ahci-imx: Port to library-ised ahci_platform Hans de Goede
2014-01-22 19:04 ` Hans de Goede
2014-01-22 19:04 ` [PATCH v5 11/14] ahci-imx: Add imx_ahci_phy_init / _exit helpers Hans de Goede
2014-01-22 19:04 ` Hans de Goede
2014-01-22 19:04 ` [PATCH v5 12/14] ahci-imx: Fix link not coming back up after suspend / resume Hans de Goede
2014-01-22 19:04 ` Hans de Goede
2014-01-22 19:04 ` [PATCH v5 13/14] ARM: sun4i: dts: Add ahci / sata support Hans de Goede
2014-01-22 19:04 ` Hans de Goede
[not found] ` <1390417489-5354-14-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-01-23 8:34 ` Chen-Yu Tsai
2014-01-23 8:34 ` [linux-sunxi] " Chen-Yu Tsai
[not found] ` <CAGb2v65mYK7Lo_KC+sGvYG7P2kDOy7CZgGane2eY8+-pMvH1mw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-01-23 14:48 ` Hans de Goede
2014-01-23 14:48 ` [linux-sunxi] " Hans de Goede
2014-01-31 13:45 ` Maxime Ripard
2014-01-31 13:45 ` Maxime Ripard
2014-02-03 10:35 ` Hans de Goede
2014-02-03 10:35 ` Hans de Goede
[not found] ` <52EF70E2.6070803-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-02-04 9:44 ` Maxime Ripard
2014-02-04 9:44 ` Maxime Ripard
2014-01-22 19:04 ` [PATCH v5 14/14] ARM: sun7i: " Hans de Goede
2014-01-22 19:04 ` Hans de Goede
[not found] ` <1390417489-5354-15-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-01-31 13:46 ` Maxime Ripard
2014-01-31 13:46 ` Maxime Ripard
2014-02-03 22:10 ` Hans de Goede
2014-02-03 22:10 ` Hans de Goede
2014-02-03 16:09 ` [PATCH v5 00/14] ahci: library-ise ahci_platform, add sunxi driver and cleanup imx driver Tejun Heo
2014-02-03 16:09 ` Tejun Heo
[not found] ` <20140203160936.GC30250-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-02-03 22:07 ` Hans de Goede
2014-02-03 22:07 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201402031553.46083.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=Hong-Xing.Zhu@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
--cc=oliver@schinagl.nl \
--cc=rogerq@ti.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.