* [Buildroot] [V2 1/2] luarocks: never wraps script
@ 2014-02-03 11:07 Francois Perrad
2014-02-03 11:07 ` [Buildroot] [V2 2/2] ljlinenoise: new package Francois Perrad
2014-02-03 20:16 ` [Buildroot] [V2 1/2] luarocks: never wraps script Yann E. MORIN
0 siblings, 2 replies; 6+ messages in thread
From: Francois Perrad @ 2014-02-03 11:07 UTC (permalink / raw)
To: buildroot
the wrapper introduces some HOST_DIR paths on target
Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
package/luarocks/luarocks.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/luarocks/luarocks.mk b/package/luarocks/luarocks.mk
index 88ab22a..86e57d2 100644
--- a/package/luarocks/luarocks.mk
+++ b/package/luarocks/luarocks.mk
@@ -37,6 +37,7 @@ define HOST_LUAROCKS_INSTALL_CMDS
echo "external_deps_dirs = { [[$(STAGING_DIR)/usr]] }" >> $(LUAROCKS_CONFIG_FILE)
echo "gcc_rpath = false" >> $(LUAROCKS_CONFIG_FILE)
echo "rocks_trees = { [[$(TARGET_DIR)/usr]] }" >> $(LUAROCKS_CONFIG_FILE)
+ echo "wrap_bin_scripts = false" >> $(LUAROCKS_CONFIG_FILE)
endef
$(eval $(host-generic-package))
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [V2 2/2] ljlinenoise: new package
2014-02-03 11:07 [Buildroot] [V2 1/2] luarocks: never wraps script Francois Perrad
@ 2014-02-03 11:07 ` Francois Perrad
2014-02-03 20:26 ` Yann E. MORIN
2014-02-03 20:16 ` [Buildroot] [V2 1/2] luarocks: never wraps script Yann E. MORIN
1 sibling, 1 reply; 6+ messages in thread
From: Francois Perrad @ 2014-02-03 11:07 UTC (permalink / raw)
To: buildroot
Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
package/Config.in | 1 +
package/ljlinenoise/Config.in | 15 +++++++++++++++
package/ljlinenoise/ljlinenoise.mk | 13 +++++++++++++
3 files changed, 29 insertions(+)
create mode 100644 package/ljlinenoise/Config.in
create mode 100644 package/ljlinenoise/ljlinenoise.mk
diff --git a/package/Config.in b/package/Config.in
index 93d23cb..c757c68 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -370,6 +370,7 @@ source "package/cgilua/Config.in"
source "package/copas/Config.in"
source "package/coxpcall/Config.in"
source "package/lbase64/Config.in"
+source "package/ljlinenoise/Config.in"
source "package/ljsyscall/Config.in"
source "package/lua-cjson/Config.in"
source "package/lua-ev/Config.in"
diff --git a/package/ljlinenoise/Config.in b/package/ljlinenoise/Config.in
new file mode 100644
index 0000000..3d2af35
--- /dev/null
+++ b/package/ljlinenoise/Config.in
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_LJLINENOISE
+ bool "ljlinenoise"
+ select BR2_PACKAGE_LJSYSCALL
+ # ljsyscall is specifically for LuaJIT, not Lua.
+ depends on BR2_PACKAGE_LUAJIT
+ # ljsyscall is only available for some target architectures
+ depends on BR2_i386 || BR2_x86_64 || BR2_powerpc || BR2_arm || BR2_armeb
+ help
+ ljlinenoise is a pure LuaJIT port of linenoise,
+ a small alternative to readline and libedit.
+
+ http://fperrad.github.io/ljlinenoise/
+
+comment "ljlinenoise needs LuaJIT"
+ depends on !BR2_PACKAGE_LUAJIT && (BR2_i386 || BR2_x86_64 || BR2_powerpc || BR2_arm || BR2_armeb)
diff --git a/package/ljlinenoise/ljlinenoise.mk b/package/ljlinenoise/ljlinenoise.mk
new file mode 100644
index 0000000..69f6130
--- /dev/null
+++ b/package/ljlinenoise/ljlinenoise.mk
@@ -0,0 +1,13 @@
+################################################################################
+#
+# ljlinenoise
+#
+################################################################################
+
+LJLINENOISE_VERSION_UPSTREAM = 0.1.1
+LJLINENOISE_VERSION = $(LJLINENOISE_VERSION_UPSTREAM)-1
+LJLINENOISE_SUBDIR = ljlinenoise-$(LJLINENOISE_VERSION_UPSTREAM)
+LJLINENOISE_LICENSE = MIT
+LJLINENOISE_LICENSE_FILES = $(LJLINENOISE_SUBDIR)/COPYRIGHT
+
+$(eval $(luarocks-package))
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [V2 1/2] luarocks: never wraps script
2014-02-03 11:07 [Buildroot] [V2 1/2] luarocks: never wraps script Francois Perrad
2014-02-03 11:07 ` [Buildroot] [V2 2/2] ljlinenoise: new package Francois Perrad
@ 2014-02-03 20:16 ` Yann E. MORIN
1 sibling, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2014-02-03 20:16 UTC (permalink / raw)
To: buildroot
Franc?ois, All,
On 2014-02-03 12:07 +0100, Francois Perrad spake thusly:
> the wrapper introduces some HOST_DIR paths on target
Can you explain a bit more in details what this wrapper is, and why we
do not want it (besides the fact it uses HOST_DIR paths on the target)?
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [V2 2/2] ljlinenoise: new package
2014-02-03 11:07 ` [Buildroot] [V2 2/2] ljlinenoise: new package Francois Perrad
@ 2014-02-03 20:26 ` Yann E. MORIN
2014-02-03 21:56 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Yann E. MORIN @ 2014-02-03 20:26 UTC (permalink / raw)
To: buildroot
Fran?ois, All,
A few nit-picks below...
On 2014-02-03 12:07 +0100, Francois Perrad spake thusly:
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
[--SNIP--]
> diff --git a/package/ljlinenoise/Config.in b/package/ljlinenoise/Config.in
> new file mode 100644
> index 0000000..3d2af35
> --- /dev/null
> +++ b/package/ljlinenoise/Config.in
> @@ -0,0 +1,15 @@
> +config BR2_PACKAGE_LJLINENOISE
> + bool "ljlinenoise"
> + select BR2_PACKAGE_LJSYSCALL
> + # ljsyscall is specifically for LuaJIT, not Lua.
> + depends on BR2_PACKAGE_LUAJIT
> + # ljsyscall is only available for some target architectures
> + depends on BR2_i386 || BR2_x86_64 || BR2_powerpc || BR2_arm || BR2_armeb
No need for the comment, it is obvious from the dependency itself that
ljlinenoise only works on these architectures.
However, it's maybe worth a comment in the commit log.
> + help
> + ljlinenoise is a pure LuaJIT port of linenoise,
> + a small alternative to readline and libedit.
> +
> + http://fperrad.github.io/ljlinenoise/
> +
> +comment "ljlinenoise needs LuaJIT"
> + depends on !BR2_PACKAGE_LUAJIT && (BR2_i386 || BR2_x86_64 || BR2_powerpc || BR2_arm || BR2_armeb)
> diff --git a/package/ljlinenoise/ljlinenoise.mk b/package/ljlinenoise/ljlinenoise.mk
> new file mode 100644
> index 0000000..69f6130
> --- /dev/null
> +++ b/package/ljlinenoise/ljlinenoise.mk
> @@ -0,0 +1,13 @@
> +################################################################################
> +#
> +# ljlinenoise
> +#
> +################################################################################
> +
> +LJLINENOISE_VERSION_UPSTREAM = 0.1.1
> +LJLINENOISE_VERSION = $(LJLINENOISE_VERSION_UPSTREAM)-1
> +LJLINENOISE_SUBDIR = ljlinenoise-$(LJLINENOISE_VERSION_UPSTREAM)
^^
Very small nit-pick: only one space in front of the '=' sing.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [V2 2/2] ljlinenoise: new package
2014-02-03 20:26 ` Yann E. MORIN
@ 2014-02-03 21:56 ` Thomas Petazzoni
2014-02-03 22:04 ` Yann E. MORIN
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2014-02-03 21:56 UTC (permalink / raw)
To: buildroot
Dear Yann E. MORIN,
On Mon, 3 Feb 2014 21:26:31 +0100, Yann E. MORIN wrote:
> > diff --git a/package/ljlinenoise/Config.in b/package/ljlinenoise/Config.in
> > new file mode 100644
> > index 0000000..3d2af35
> > --- /dev/null
> > +++ b/package/ljlinenoise/Config.in
> > @@ -0,0 +1,15 @@
> > +config BR2_PACKAGE_LJLINENOISE
> > + bool "ljlinenoise"
> > + select BR2_PACKAGE_LJSYSCALL
> > + # ljsyscall is specifically for LuaJIT, not Lua.
> > + depends on BR2_PACKAGE_LUAJIT
> > + # ljsyscall is only available for some target architectures
> > + depends on BR2_i386 || BR2_x86_64 || BR2_powerpc || BR2_arm || BR2_armeb
>
> No need for the comment, it is obvious from the dependency itself that
> ljlinenoise only works on these architectures.
Hum, really? These dependencies are inherited from ljsyscall, which is
selected by this package. In such a situation, we normally do something
like:
select BR2_PACKAGE_LIBGLIB2
depends on BR2_USE_WCHAR # libglib2
so having the same comment mentioned here makes sense, IMO, as it helps
understanding where the architecture dependency is coming from.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [V2 2/2] ljlinenoise: new package
2014-02-03 21:56 ` Thomas Petazzoni
@ 2014-02-03 22:04 ` Yann E. MORIN
0 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2014-02-03 22:04 UTC (permalink / raw)
To: buildroot
Thomas, Fran?ois, All,
On 2014-02-03 22:56 +0100, Thomas Petazzoni spake thusly:
> On Mon, 3 Feb 2014 21:26:31 +0100, Yann E. MORIN wrote:
>
> > > diff --git a/package/ljlinenoise/Config.in b/package/ljlinenoise/Config.in
> > > new file mode 100644
> > > index 0000000..3d2af35
> > > --- /dev/null
> > > +++ b/package/ljlinenoise/Config.in
> > > @@ -0,0 +1,15 @@
> > > +config BR2_PACKAGE_LJLINENOISE
> > > + bool "ljlinenoise"
> > > + select BR2_PACKAGE_LJSYSCALL
> > > + # ljsyscall is specifically for LuaJIT, not Lua.
> > > + depends on BR2_PACKAGE_LUAJIT
> > > + # ljsyscall is only available for some target architectures
> > > + depends on BR2_i386 || BR2_x86_64 || BR2_powerpc || BR2_arm || BR2_armeb
> >
> > No need for the comment, it is obvious from the dependency itself that
> > ljlinenoise only works on these architectures.
>
> Hum, really? These dependencies are inherited from ljsyscall, which is
> selected by this package. In such a situation, we normally do something
> like:
>
> select BR2_PACKAGE_LIBGLIB2
> depends on BR2_USE_WCHAR # libglib2
>
> so having the same comment mentioned here makes sense, IMO, as it helps
> understanding where the architecture dependency is coming from.
OK, my bad, I misread 'ljlinenoise' when 'ljsyscall' was properly
written.
Forget what I said about this. Sorry for the noise.
As Thomas said, just post-fix the depends with '# ljsyscall'.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-02-03 22:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-03 11:07 [Buildroot] [V2 1/2] luarocks: never wraps script Francois Perrad
2014-02-03 11:07 ` [Buildroot] [V2 2/2] ljlinenoise: new package Francois Perrad
2014-02-03 20:26 ` Yann E. MORIN
2014-02-03 21:56 ` Thomas Petazzoni
2014-02-03 22:04 ` Yann E. MORIN
2014-02-03 20:16 ` [Buildroot] [V2 1/2] luarocks: never wraps script Yann E. MORIN
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.