From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: David Rientjes <rientjes@google.com>,
Pekka Enberg <penberg@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Christoph Lameter <cl@linux-foundation.org>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: Kernel WARNING splat in 3.14-rc1
Date: Mon, 3 Feb 2014 15:41:05 -0800 [thread overview]
Message-ID: <20140203234105.GA10614@linux.vnet.ibm.com> (raw)
In-Reply-To: <52F0215B.5040209@lwfinger.net>
On Mon, Feb 03, 2014 at 05:08:11PM -0600, Larry Finger wrote:
> On 02/03/2014 02:39 PM, David Rientjes wrote:
> >Commit c65c1877bd68 ("slub: use lockdep_assert_held") incorrectly required
> >that add_full() and remove_full() hold n->list_lock. The lock is only
> >taken when kmem_cache_debug(s), since that's the only time it actually
> >does anything.
> >
> >Require that the lock only be taken under such a condition.
> >
> >Reported-by: Larry Finger <Larry.Finger@lwfinger.net>
> >Signed-off-by: David Rientjes <rientjes@google.com>
>
> You may add a "Tested-by: Larry Finger <Larry.Finger@lwfinger.net>".
> The patch cleans up the splat on my system. Thanks for the quick
> response.
Please feel free to add mine as well:
Tested-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
And also feel free to ignore my patch as well. ;-)
Thanx, Paul
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: David Rientjes <rientjes@google.com>,
Pekka Enberg <penberg@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Christoph Lameter <cl@linux-foundation.org>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: Kernel WARNING splat in 3.14-rc1
Date: Mon, 3 Feb 2014 15:41:05 -0800 [thread overview]
Message-ID: <20140203234105.GA10614@linux.vnet.ibm.com> (raw)
In-Reply-To: <52F0215B.5040209@lwfinger.net>
On Mon, Feb 03, 2014 at 05:08:11PM -0600, Larry Finger wrote:
> On 02/03/2014 02:39 PM, David Rientjes wrote:
> >Commit c65c1877bd68 ("slub: use lockdep_assert_held") incorrectly required
> >that add_full() and remove_full() hold n->list_lock. The lock is only
> >taken when kmem_cache_debug(s), since that's the only time it actually
> >does anything.
> >
> >Require that the lock only be taken under such a condition.
> >
> >Reported-by: Larry Finger <Larry.Finger@lwfinger.net>
> >Signed-off-by: David Rientjes <rientjes@google.com>
>
> You may add a "Tested-by: Larry Finger <Larry.Finger@lwfinger.net>".
> The patch cleans up the splat on my system. Thanks for the quick
> response.
Please feel free to add mine as well:
Tested-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
And also feel free to ignore my patch as well. ;-)
Thanx, Paul
next prev parent reply other threads:[~2014-02-03 23:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-03 20:04 Kernel WARNING splat in 3.14-rc1 Larry Finger
2014-02-03 20:04 ` Larry Finger
2014-02-03 20:39 ` David Rientjes
2014-02-03 20:39 ` David Rientjes
2014-02-03 22:34 ` Christoph Lameter
2014-02-03 22:34 ` Christoph Lameter
2014-02-03 23:08 ` Larry Finger
2014-02-03 23:08 ` Larry Finger
2014-02-03 23:41 ` Paul E. McKenney [this message]
2014-02-03 23:41 ` Paul E. McKenney
2014-02-03 23:44 ` [patch for-3.14] mm, slub: list_lock may not be held in some circumstances David Rientjes
2014-02-03 23:44 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140203234105.GA10614@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=Larry.Finger@lwfinger.net \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.