* [PATCH] staging: cxt1e1: fix pointer-integer size mismatch warning
@ 2014-02-04 7:01 SeongJae Park
2014-02-04 8:23 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: SeongJae Park @ 2014-02-04 7:01 UTC (permalink / raw)
To: gregkh, dulshani.gunawardhana89, shaun, lisa, sima.baymani
Cc: devel, linux-kernel, SeongJae Park
Fix the pointer-integer size mismatch warning below:
drivers/staging/cxt1e1/functions.c: In function ‘VMETRO_TRACE’:
drivers/staging/cxt1e1/functions.c:268:21: warning: cast from pointer
to integer of different size [-Wpointer-to-int-cast]
u_int32_t y = (u_int32_t) x;
^
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
drivers/staging/cxt1e1/functions.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/cxt1e1/functions.c b/drivers/staging/cxt1e1/functions.c
index 95218e2..8f19a39 100644
--- a/drivers/staging/cxt1e1/functions.c
+++ b/drivers/staging/cxt1e1/functions.c
@@ -265,7 +265,7 @@ extern ci_t *CI; /* dummy pointer to board ZERO's data */
void
VMETRO_TRACE (void *x)
{
- u_int32_t y = (u_int32_t) x;
+ u_int32_t y = (u_int32_t)(uintptr_t) x;
pci_write_32 ((u_int32_t *) &CI->cpldbase->leds, y);
}
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: cxt1e1: fix pointer-integer size mismatch warning
2014-02-04 7:01 [PATCH] staging: cxt1e1: fix pointer-integer size mismatch warning SeongJae Park
@ 2014-02-04 8:23 ` Dan Carpenter
2014-02-04 8:29 ` SeongJae Park
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2014-02-04 8:23 UTC (permalink / raw)
To: SeongJae Park
Cc: gregkh, dulshani.gunawardhana89, shaun, lisa, sima.baymani, devel,
linux-kernel
On Tue, Feb 04, 2014 at 04:01:26PM +0900, SeongJae Park wrote:
> Fix the pointer-integer size mismatch warning below:
> drivers/staging/cxt1e1/functions.c: In function ‘VMETRO_TRACE’:
> drivers/staging/cxt1e1/functions.c:268:21: warning: cast from pointer
> to integer of different size [-Wpointer-to-int-cast]
> u_int32_t y = (u_int32_t) x;
> ^
This function isn't called. Just delete it from here and also from the
.h file.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: cxt1e1: fix pointer-integer size mismatch warning
2014-02-04 8:23 ` Dan Carpenter
@ 2014-02-04 8:29 ` SeongJae Park
0 siblings, 0 replies; 3+ messages in thread
From: SeongJae Park @ 2014-02-04 8:29 UTC (permalink / raw)
To: Dan Carpenter
Cc: Greg KH, dulshani.gunawardhana89, shaun, lisa, sima.baymani,
devel, linux-kernel@vger.kernel.org
On Tue, Feb 4, 2014 at 5:23 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Tue, Feb 04, 2014 at 04:01:26PM +0900, SeongJae Park wrote:
>> Fix the pointer-integer size mismatch warning below:
>> drivers/staging/cxt1e1/functions.c: In function ‘VMETRO_TRACE’:
>> drivers/staging/cxt1e1/functions.c:268:21: warning: cast from pointer
>> to integer of different size [-Wpointer-to-int-cast]
>> u_int32_t y = (u_int32_t) x;
>> ^
>
> This function isn't called. Just delete it from here and also from the
> .h file.
>
Nice review. Thank you for reviewing. I will upload new patch soon.
> regards,
> dan carpenter
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-04 8:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-04 7:01 [PATCH] staging: cxt1e1: fix pointer-integer size mismatch warning SeongJae Park
2014-02-04 8:23 ` Dan Carpenter
2014-02-04 8:29 ` SeongJae Park
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.