* [PATCH Resend] mfd: stmpe: Remove unnecessary semicolon
@ 2014-02-04 9:07 Sachin Kamat
2014-02-04 9:16 ` Lee Jones
0 siblings, 1 reply; 3+ messages in thread
From: Sachin Kamat @ 2014-02-04 9:07 UTC (permalink / raw)
To: linux-kernel; +Cc: lee.jones, sachin.kamat
Semicolon is not necessary after the while statement.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/mfd/stmpe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
index 42ccd0544513..4a91f6771fb8 100644
--- a/drivers/mfd/stmpe.c
+++ b/drivers/mfd/stmpe.c
@@ -706,7 +706,7 @@ static int stmpe1801_reset(struct stmpe *stmpe)
if (!(ret & STMPE1801_MSK_SYS_CTRL_RESET))
return 0;
usleep_range(100, 200);
- };
+ }
return -EIO;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH Resend] mfd: stmpe: Remove unnecessary semicolon
2014-02-04 9:07 [PATCH Resend] mfd: stmpe: Remove unnecessary semicolon Sachin Kamat
@ 2014-02-04 9:16 ` Lee Jones
2014-02-04 9:22 ` Sachin Kamat
0 siblings, 1 reply; 3+ messages in thread
From: Lee Jones @ 2014-02-04 9:16 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-kernel
> Semicolon is not necessary after the while statement.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/mfd/stmpe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
> index 42ccd0544513..4a91f6771fb8 100644
> --- a/drivers/mfd/stmpe.c
> +++ b/drivers/mfd/stmpe.c
> @@ -706,7 +706,7 @@ static int stmpe1801_reset(struct stmpe *stmpe)
> if (!(ret & STMPE1801_MSK_SYS_CTRL_RESET))
> return 0;
> usleep_range(100, 200);
> - };
> + }
> return -EIO;
> }
Can you re-submit with a new line between it and the return please?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH Resend] mfd: stmpe: Remove unnecessary semicolon
2014-02-04 9:16 ` Lee Jones
@ 2014-02-04 9:22 ` Sachin Kamat
0 siblings, 0 replies; 3+ messages in thread
From: Sachin Kamat @ 2014-02-04 9:22 UTC (permalink / raw)
To: Lee Jones; +Cc: LKML
On 4 February 2014 14:46, Lee Jones <lee.jones@linaro.org> wrote:
>> Semicolon is not necessary after the while statement.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> ---
>> drivers/mfd/stmpe.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
>> index 42ccd0544513..4a91f6771fb8 100644
>> --- a/drivers/mfd/stmpe.c
>> +++ b/drivers/mfd/stmpe.c
>> @@ -706,7 +706,7 @@ static int stmpe1801_reset(struct stmpe *stmpe)
>> if (!(ret & STMPE1801_MSK_SYS_CTRL_RESET))
>> return 0;
>> usleep_range(100, 200);
>> - };
>> + }
>> return -EIO;
>> }
>
> Can you re-submit with a new line between it and the return please?
Sure. In a minute :)
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-04 9:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-04 9:07 [PATCH Resend] mfd: stmpe: Remove unnecessary semicolon Sachin Kamat
2014-02-04 9:16 ` Lee Jones
2014-02-04 9:22 ` Sachin Kamat
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.