* [PATCH] perf tools: Handle PERF_RECORD_HEADER_EVENT_TYPE properly
@ 2014-02-04 14:37 Jiri Olsa
2014-02-05 5:55 ` Ingo Molnar
2014-02-22 17:54 ` [tip:perf/core] " tip-bot for Jiri Olsa
0 siblings, 2 replies; 5+ messages in thread
From: Jiri Olsa @ 2014-02-04 14:37 UTC (permalink / raw)
To: linux-kernel
Cc: Jiri Olsa, Corey Ashford, Frederic Weisbecker, Ingo Molnar,
Namhyung Kim, Paul Mackerras, Peter Zijlstra,
Arnaldo Carvalho de Melo, David Ahern
We removed event types from data file in following commits:
6065210 perf tools: Remove event types framework completely
44b3c57 perf tools: Remove event types from perf data file
We no longer need this information, because we can get it
directly from tracepoints.
But we still need to handle PERF_RECORD_HEADER_EVENT_TYPE
event for the sake of old perf data files created in pipe
mode like:
$ perf.3.4 record -o - foo >perf.data
$ perf.312 report -i - < perf.data
Reported-by: Stephane Eranian <eranian@google.com>
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: David Ahern <dsahern@gmail.com>
---
tools/perf/util/session.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index 0b39a48..5da6ce7 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -1008,6 +1008,12 @@ static int perf_session__process_user_event(struct perf_session *session, union
if (err == 0)
perf_session__set_id_hdr_size(session);
return err;
+ case PERF_RECORD_HEADER_EVENT_TYPE:
+ /*
+ * Depreceated, but we need to handle it for sake
+ * of old data files create in pipe mode.
+ */
+ return 0;
case PERF_RECORD_HEADER_TRACING_DATA:
/* setup for reading amidst mmap */
lseek(fd, file_offset, SEEK_SET);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] perf tools: Handle PERF_RECORD_HEADER_EVENT_TYPE properly
2014-02-04 14:37 [PATCH] perf tools: Handle PERF_RECORD_HEADER_EVENT_TYPE properly Jiri Olsa
@ 2014-02-05 5:55 ` Ingo Molnar
2014-02-05 9:03 ` Jiri Olsa
2014-02-22 17:54 ` [tip:perf/core] " tip-bot for Jiri Olsa
1 sibling, 1 reply; 5+ messages in thread
From: Ingo Molnar @ 2014-02-05 5:55 UTC (permalink / raw)
To: Jiri Olsa
Cc: linux-kernel, Corey Ashford, Frederic Weisbecker, Ingo Molnar,
Namhyung Kim, Paul Mackerras, Peter Zijlstra,
Arnaldo Carvalho de Melo, David Ahern
* Jiri Olsa <jolsa@redhat.com> wrote:
> We removed event types from data file in following commits:
> 6065210 perf tools: Remove event types framework completely
> 44b3c57 perf tools: Remove event types from perf data file
>
> We no longer need this information, because we can get it
> directly from tracepoints.
>
> But we still need to handle PERF_RECORD_HEADER_EVENT_TYPE
> event for the sake of old perf data files created in pipe
> mode like:
>
> $ perf.3.4 record -o - foo >perf.data
> $ perf.312 report -i - < perf.data
>
> Reported-by: Stephane Eranian <eranian@google.com>
> Signed-off-by: Jiri Olsa <jolsa@redhat.com>
> Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Ingo Molnar <mingo@elte.hu>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: David Ahern <dsahern@gmail.com>
> ---
> tools/perf/util/session.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> index 0b39a48..5da6ce7 100644
> --- a/tools/perf/util/session.c
> +++ b/tools/perf/util/session.c
> @@ -1008,6 +1008,12 @@ static int perf_session__process_user_event(struct perf_session *session, union
> if (err == 0)
> perf_session__set_id_hdr_size(session);
> return err;
> + case PERF_RECORD_HEADER_EVENT_TYPE:
> + /*
> + * Depreceated, but we need to handle it for sake
> + * of old data files create in pipe mode.
> + */
Two small speling nits:
s/Depreceated
/Deprecated
s/create
/created
Ack otherwise.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] perf tools: Handle PERF_RECORD_HEADER_EVENT_TYPE properly
2014-02-05 5:55 ` Ingo Molnar
@ 2014-02-05 9:03 ` Jiri Olsa
2014-02-05 13:24 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 5+ messages in thread
From: Jiri Olsa @ 2014-02-05 9:03 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Corey Ashford, Frederic Weisbecker, Ingo Molnar,
Namhyung Kim, Paul Mackerras, Peter Zijlstra,
Arnaldo Carvalho de Melo, David Ahern
On Wed, Feb 05, 2014 at 06:55:52AM +0100, Ingo Molnar wrote:
>
> * Jiri Olsa <jolsa@redhat.com> wrote:
>
> > We removed event types from data file in following commits:
> > 6065210 perf tools: Remove event types framework completely
> > 44b3c57 perf tools: Remove event types from perf data file
> >
> > We no longer need this information, because we can get it
> > directly from tracepoints.
> >
> > But we still need to handle PERF_RECORD_HEADER_EVENT_TYPE
> > event for the sake of old perf data files created in pipe
> > mode like:
> >
> > $ perf.3.4 record -o - foo >perf.data
> > $ perf.312 report -i - < perf.data
> >
> > Reported-by: Stephane Eranian <eranian@google.com>
> > Signed-off-by: Jiri Olsa <jolsa@redhat.com>
> > Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
> > Cc: Frederic Weisbecker <fweisbec@gmail.com>
> > Cc: Ingo Molnar <mingo@elte.hu>
> > Cc: Namhyung Kim <namhyung@kernel.org>
> > Cc: Paul Mackerras <paulus@samba.org>
> > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> > Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> > Cc: David Ahern <dsahern@gmail.com>
> > ---
> > tools/perf/util/session.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> > index 0b39a48..5da6ce7 100644
> > --- a/tools/perf/util/session.c
> > +++ b/tools/perf/util/session.c
> > @@ -1008,6 +1008,12 @@ static int perf_session__process_user_event(struct perf_session *session, union
> > if (err == 0)
> > perf_session__set_id_hdr_size(session);
> > return err;
> > + case PERF_RECORD_HEADER_EVENT_TYPE:
> > + /*
> > + * Depreceated, but we need to handle it for sake
> > + * of old data files create in pipe mode.
> > + */
>
> Two small speling nits:
>
> s/Depreceated
> /Deprecated
>
> s/create
> /created
>
> Ack otherwise.
>
> Thanks,
>
> Ingo
ugh, my spell checker sux.. ;-\ acme, beer for each correction? ;-)
thanks,
jirka
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] perf tools: Handle PERF_RECORD_HEADER_EVENT_TYPE properly
2014-02-05 9:03 ` Jiri Olsa
@ 2014-02-05 13:24 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 5+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-02-05 13:24 UTC (permalink / raw)
To: Jiri Olsa
Cc: Ingo Molnar, linux-kernel, Corey Ashford, Frederic Weisbecker,
Ingo Molnar, Namhyung Kim, Paul Mackerras, Peter Zijlstra,
David Ahern
Em Wed, Feb 05, 2014 at 10:03:39AM +0100, Jiri Olsa escreveu:
> On Wed, Feb 05, 2014 at 06:55:52AM +0100, Ingo Molnar wrote:
> >
> > * Jiri Olsa <jolsa@redhat.com> wrote:
> >
> > > We removed event types from data file in following commits:
> > > 6065210 perf tools: Remove event types framework completely
> > > 44b3c57 perf tools: Remove event types from perf data file
> > >
> > > We no longer need this information, because we can get it
> > > directly from tracepoints.
> > >
> > > But we still need to handle PERF_RECORD_HEADER_EVENT_TYPE
> > > event for the sake of old perf data files created in pipe
> > > mode like:
> > >
> > > $ perf.3.4 record -o - foo >perf.data
> > > $ perf.312 report -i - < perf.data
> > >
> > > Reported-by: Stephane Eranian <eranian@google.com>
> > > Signed-off-by: Jiri Olsa <jolsa@redhat.com>
> > > Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
> > > Cc: Frederic Weisbecker <fweisbec@gmail.com>
> > > Cc: Ingo Molnar <mingo@elte.hu>
> > > Cc: Namhyung Kim <namhyung@kernel.org>
> > > Cc: Paul Mackerras <paulus@samba.org>
> > > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> > > Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> > > Cc: David Ahern <dsahern@gmail.com>
> > > ---
> > > tools/perf/util/session.c | 6 ++++++
> > > 1 file changed, 6 insertions(+)
> > >
> > > diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> > > index 0b39a48..5da6ce7 100644
> > > --- a/tools/perf/util/session.c
> > > +++ b/tools/perf/util/session.c
> > > @@ -1008,6 +1008,12 @@ static int perf_session__process_user_event(struct perf_session *session, union
> > > if (err == 0)
> > > perf_session__set_id_hdr_size(session);
> > > return err;
> > > + case PERF_RECORD_HEADER_EVENT_TYPE:
> > > + /*
> > > + * Depreceated, but we need to handle it for sake
> > > + * of old data files create in pipe mode.
> > > + */
> >
> > Two small speling nits:
> >
> > s/Depreceated
> > /Deprecated
> >
> > s/create
> > /created
> >
> > Ack otherwise.
> >
> > Thanks,
> >
> > Ingo
>
> ugh, my spell checker sux.. ;-\ acme, beer for each correction? ;-)
two for each, deal.
- Arnaldo
^ permalink raw reply [flat|nested] 5+ messages in thread
* [tip:perf/core] perf tools: Handle PERF_RECORD_HEADER_EVENT_TYPE properly
2014-02-04 14:37 [PATCH] perf tools: Handle PERF_RECORD_HEADER_EVENT_TYPE properly Jiri Olsa
2014-02-05 5:55 ` Ingo Molnar
@ 2014-02-22 17:54 ` tip-bot for Jiri Olsa
1 sibling, 0 replies; 5+ messages in thread
From: tip-bot for Jiri Olsa @ 2014-02-22 17:54 UTC (permalink / raw)
To: linux-tip-commits
Cc: acme, linux-kernel, paulus, eranian, hpa, mingo, a.p.zijlstra,
namhyung, jolsa, fweisbec, dsahern, tglx, cjashfor, mingo
Commit-ID: f67697bd079f4bbcbe7d6d26765a06b18afe0630
Gitweb: http://git.kernel.org/tip/f67697bd079f4bbcbe7d6d26765a06b18afe0630
Author: Jiri Olsa <jolsa@redhat.com>
AuthorDate: Tue, 4 Feb 2014 15:37:48 +0100
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 10 Feb 2014 11:34:31 -0300
perf tools: Handle PERF_RECORD_HEADER_EVENT_TYPE properly
We removed event types from data file in following commits:
6065210 perf tools: Remove event types framework completely
44b3c57 perf tools: Remove event types from perf data file
We no longer need this information, because we can get it directly from
tracepoints.
But we still need to handle PERF_RECORD_HEADER_EVENT_TYPE event for the
sake of old perf data files created in pipe mode like:
$ perf.3.4 record -o - foo >perf.data
$ perf.312 report -i - < perf.data
Reported-by: Stephane Eranian <eranian@google.com>
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1391524668-12546-1-git-send-email-jolsa@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/session.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index 0b39a48..5da6ce7 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -1008,6 +1008,12 @@ static int perf_session__process_user_event(struct perf_session *session, union
if (err == 0)
perf_session__set_id_hdr_size(session);
return err;
+ case PERF_RECORD_HEADER_EVENT_TYPE:
+ /*
+ * Depreceated, but we need to handle it for sake
+ * of old data files create in pipe mode.
+ */
+ return 0;
case PERF_RECORD_HEADER_TRACING_DATA:
/* setup for reading amidst mmap */
lseek(fd, file_offset, SEEK_SET);
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-02-22 17:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-04 14:37 [PATCH] perf tools: Handle PERF_RECORD_HEADER_EVENT_TYPE properly Jiri Olsa
2014-02-05 5:55 ` Ingo Molnar
2014-02-05 9:03 ` Jiri Olsa
2014-02-05 13:24 ` Arnaldo Carvalho de Melo
2014-02-22 17:54 ` [tip:perf/core] " tip-bot for Jiri Olsa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.