From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: "David Lanzendörfer" <david.lanzendoerfer-Z7Kmv9EsliU@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Laurent Pinchart
<laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
Simon Baatz <gmbnomis-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Chris Ball <chris-OsFVWbfNK3isTnJN9+BGXg@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
H Hartley Sweeten
<hsweeten-3FF4nKcrg1dE2c76skzGb0EOCMrvLtNR@public.gmane.org>,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Guennadi Liakhovetski
<g.liakhovetski-Mmb7MZpHnFY@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v2 0/6] ARM: sunxi: Add driver for SD/MMC hosts found on allwinner sunxi SOCs
Date: Wed, 5 Feb 2014 11:39:49 +0100 [thread overview]
Message-ID: <20140205103949.GC3192@lukather> (raw)
In-Reply-To: <20140204191648.29809.14611.stgit-GPtPHOohwllnsqa/0SyWJQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1439 bytes --]
Hi David,
On Tue, Feb 04, 2014 at 08:24:13PM +0100, David Lanzendörfer wrote:
> Hello
> The following patchset adds support for the SD/MMC host found in the Allwinner SoCs.
> It contains all the necessary modifications for clock environment and also the device
> tree script modification which add it to all the boards using it.
> The clock environment function needed for phase offset configuration has
> been proposed and implemented by Emilio.
> This patchset is the second attempt to send this driver upstream.
> I'm looking forward to the acceptance of this patchset into mainline.
I have four comments here:
- Read Documentation/SubmittingPatches, especially Section 5 and 12
(hints, you forgot the clock maintainers for your clock patches
and you didn't put any signed-off-by tags)
- You ignored pretty much all the comments that were made during the
review of the first version. Go through
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-December/219339.html
and address the comments that were made.
- Each of your patches should compile. Fix the order of your
patches.
- Submit a v3, with the changes you made. Otherwise we have no way
of knowing what have been fixed and what didn't
Looking forward for the next iteration!
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/6] ARM: sunxi: Add driver for SD/MMC hosts found on allwinner sunxi SOCs
Date: Wed, 5 Feb 2014 11:39:49 +0100 [thread overview]
Message-ID: <20140205103949.GC3192@lukather> (raw)
In-Reply-To: <20140204191648.29809.14611.stgit@dizzy-6.o2s.ch>
Hi David,
On Tue, Feb 04, 2014 at 08:24:13PM +0100, David Lanzend?rfer wrote:
> Hello
> The following patchset adds support for the SD/MMC host found in the Allwinner SoCs.
> It contains all the necessary modifications for clock environment and also the device
> tree script modification which add it to all the boards using it.
> The clock environment function needed for phase offset configuration has
> been proposed and implemented by Emilio.
> This patchset is the second attempt to send this driver upstream.
> I'm looking forward to the acceptance of this patchset into mainline.
I have four comments here:
- Read Documentation/SubmittingPatches, especially Section 5 and 12
(hints, you forgot the clock maintainers for your clock patches
and you didn't put any signed-off-by tags)
- You ignored pretty much all the comments that were made during the
review of the first version. Go through
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-December/219339.html
and address the comments that were made.
- Each of your patches should compile. Fix the order of your
patches.
- Submit a v3, with the changes you made. Otherwise we have no way
of knowing what have been fixed and what didn't
Looking forward for the next iteration!
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140205/739e5515/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: "David Lanzendörfer" <david.lanzendoerfer@o2s.ch>
Cc: devicetree@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Simon Baatz <gmbnomis@gmail.com>,
Hans de Goede <hdegoede@redhat.com>,
linux-mmc@vger.kernel.org, Chris Ball <chris@printf.net>,
linux-kernel@vger.kernel.org,
H Hartley Sweeten <hsweeten@visionengravers.com>,
linux-sunxi@googlegroups.com, Tejun Heo <tj@kernel.org>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/6] ARM: sunxi: Add driver for SD/MMC hosts found on allwinner sunxi SOCs
Date: Wed, 5 Feb 2014 11:39:49 +0100 [thread overview]
Message-ID: <20140205103949.GC3192@lukather> (raw)
In-Reply-To: <20140204191648.29809.14611.stgit@dizzy-6.o2s.ch>
[-- Attachment #1: Type: text/plain, Size: 1439 bytes --]
Hi David,
On Tue, Feb 04, 2014 at 08:24:13PM +0100, David Lanzendörfer wrote:
> Hello
> The following patchset adds support for the SD/MMC host found in the Allwinner SoCs.
> It contains all the necessary modifications for clock environment and also the device
> tree script modification which add it to all the boards using it.
> The clock environment function needed for phase offset configuration has
> been proposed and implemented by Emilio.
> This patchset is the second attempt to send this driver upstream.
> I'm looking forward to the acceptance of this patchset into mainline.
I have four comments here:
- Read Documentation/SubmittingPatches, especially Section 5 and 12
(hints, you forgot the clock maintainers for your clock patches
and you didn't put any signed-off-by tags)
- You ignored pretty much all the comments that were made during the
review of the first version. Go through
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-December/219339.html
and address the comments that were made.
- Each of your patches should compile. Fix the order of your
patches.
- Submit a v3, with the changes you made. Otherwise we have no way
of knowing what have been fixed and what didn't
Looking forward for the next iteration!
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-02-05 10:39 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 19:24 [PATCH v2 0/6] ARM: sunxi: Add driver for SD/MMC hosts found on allwinner sunxi SOCs David Lanzendörfer
2014-02-04 19:24 ` David Lanzendörfer
2014-02-04 19:24 ` David Lanzendörfer
[not found] ` <20140204191648.29809.14611.stgit-GPtPHOohwllnsqa/0SyWJQ@public.gmane.org>
2014-02-04 19:24 ` [PATCH v2 1/6] ARM: sunxi: Add driver for SD/MMC hosts found on Allwinner sunxi SoCs David Lanzendörfer
2014-02-04 19:24 ` David Lanzendörfer
2014-02-04 19:24 ` David Lanzendörfer
2014-02-04 19:24 ` [PATCH v2 2/6] clk: sunxi: Implement MMC phase control David Lanzendörfer
2014-02-04 19:24 ` David Lanzendörfer
2014-02-04 19:24 ` David Lanzendörfer
2014-02-04 19:25 ` [PATCH v2 3/6] ARM: sunxi: clk: export clk_sunxi_mmc_phase_control David Lanzendörfer
2014-02-04 19:25 ` David Lanzendörfer
2014-02-04 19:25 ` David Lanzendörfer
2014-02-04 19:25 ` [PATCH v2 4/6] ARM: dts: sun7i: Add support for mmc David Lanzendörfer
2014-02-04 19:25 ` David Lanzendörfer
2014-02-04 19:25 ` David Lanzendörfer
2014-02-04 19:25 ` [PATCH v2 5/6] ARM: dts: sun4i: " David Lanzendörfer
2014-02-04 19:25 ` David Lanzendörfer
2014-02-04 19:25 ` David Lanzendörfer
2014-02-04 19:25 ` [PATCH v2 6/6] ARM: dts: sun5i: " David Lanzendörfer
2014-02-04 19:25 ` David Lanzendörfer
2014-02-04 19:25 ` David Lanzendörfer
2014-02-04 19:37 ` [PATCH v2 0/6] ARM: sunxi: Add driver for SD/MMC hosts found on allwinner sunxi SOCs David Lanzendörfer
2014-02-04 19:37 ` David Lanzendörfer
2014-02-04 19:37 ` David Lanzendörfer
2014-02-05 10:39 ` Maxime Ripard [this message]
2014-02-05 10:39 ` Maxime Ripard
2014-02-05 10:39 ` Maxime Ripard
2014-02-05 13:01 ` David Lanzendörfer
2014-02-05 13:01 ` David Lanzendörfer
2014-02-05 13:01 ` David Lanzendörfer
[not found] ` <1676482.sbjAhaSLaV-GPtPHOohwllnsqa/0SyWJQ@public.gmane.org>
2014-02-05 15:47 ` Hans de Goede
2014-02-05 15:47 ` Hans de Goede
2014-02-05 15:47 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140205103949.GC3192@lukather \
--to=maxime.ripard-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=chris-OsFVWbfNK3isTnJN9+BGXg@public.gmane.org \
--cc=david.lanzendoerfer-Z7Kmv9EsliU@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=g.liakhovetski-Mmb7MZpHnFY@public.gmane.org \
--cc=gmbnomis-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hsweeten-3FF4nKcrg1dE2c76skzGb0EOCMrvLtNR@public.gmane.org \
--cc=laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.