From: Mark Brown <broonie@kernel.org>
To: "Opensource [Adam Thomson]" <Adam.Thomson.Opensource@diasemi.com>
Cc: Lee Jones <lee.jones@linaro.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH 4/8] regulator: da9055: Add DT support
Date: Thu, 6 Feb 2014 14:30:50 +0000 [thread overview]
Message-ID: <20140206143050.GU32298@sirena.org.uk> (raw)
In-Reply-To: <2E89032DDAA8B9408CB92943514A03376B7E36B9@SW-EX-MBX02.diasemi.com>
[-- Attachment #1: Type: text/plain, Size: 488 bytes --]
On Thu, Feb 06, 2014 at 12:22:13PM +0000, Opensource [Adam Thomson] wrote:
> Is what I summised but I obviously chose the wrong direction for my fix.
> Will use platform_get_irq_byname() solely, and will make sure all works on
> both DT and non-DT setups. If not I'll dig further.
Yeah. In general I'd say that if you've got two options for something
like this the option that makes the driver smaller or which replaces
more code with data is normally going to be the right way to go.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-02-06 14:30 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 17:48 [PATCH 0/8] da9055: Driver initialisation fixes, add DT support Adam Thomson
2014-02-05 17:48 ` Adam Thomson
2014-02-05 17:48 ` [PATCH 1/8] ASoC: da9055: Fix device registration of PMIC and CODEC devices Adam Thomson
2014-02-05 17:48 ` Adam Thomson
[not found] ` <6a398d176b0b2bf8792d27bd5e2995fd96afb32d.1391614923.git.Adam.Thomson.Opensource-WBD+wuPFNBhBDgjK7y7TUQ@public.gmane.org>
2014-02-05 18:38 ` Mark Brown
2014-02-05 18:38 ` Mark Brown
2014-02-05 17:48 ` [PATCH 2/8] ASoC: da9055: Add DT support for CODEC Adam Thomson
2014-02-05 17:48 ` Adam Thomson
2014-02-05 17:48 ` [PATCH 3/8] mfd: da9055: Add DT support for PMIC Adam Thomson
2014-02-05 17:48 ` Adam Thomson
2014-02-05 17:48 ` [PATCH 4/8] regulator: da9055: Add DT support Adam Thomson
2014-02-05 17:48 ` Adam Thomson
[not found] ` <6d76ae40cd435eaae0323f3e806515130b06a376.1391614923.git.Adam.Thomson.Opensource-WBD+wuPFNBhBDgjK7y7TUQ@public.gmane.org>
2014-02-05 18:36 ` Mark Brown
2014-02-05 18:36 ` Mark Brown
2014-02-06 11:31 ` Opensource [Adam Thomson]
2014-02-06 11:31 ` Opensource [Adam Thomson]
[not found] ` <2E89032DDAA8B9408CB92943514A03376B7E1669-68WUHU125fLzLL1Oxlh9IgLouzNaz+3S@public.gmane.org>
2014-02-06 12:03 ` Mark Brown
2014-02-06 12:03 ` Mark Brown
[not found] ` <20140206120336.GL32298-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-02-06 12:22 ` Opensource [Adam Thomson]
2014-02-06 12:22 ` Opensource [Adam Thomson]
2014-02-06 14:30 ` Mark Brown [this message]
2014-02-05 17:48 ` [PATCH 5/8] onkey: da9055: Remove use of platform_get_irq_byname() Adam Thomson
2014-02-05 17:48 ` Adam Thomson
2014-02-05 17:48 ` [PATCH 6/8] hwmon: " Adam Thomson
2014-02-05 17:48 ` Adam Thomson
2014-02-05 17:48 ` [PATCH 7/8] rtc: " Adam Thomson
2014-02-05 17:48 ` Adam Thomson
2014-02-05 17:48 ` [PATCH 8/8] mfd: da9055: Remove unused resource structures for mfd cells Adam Thomson
2014-02-05 17:48 ` Adam Thomson
[not found] ` <cover.1391614923.git.Adam.Thomson.Opensource-WBD+wuPFNBhBDgjK7y7TUQ@public.gmane.org>
2014-02-06 0:54 ` [PATCH 0/8] da9055: Driver initialisation fixes, add DT support Guenter Roeck
2014-02-06 0:54 ` Guenter Roeck
[not found] ` <20140206005406.GC1308-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2014-02-06 11:46 ` Opensource [Adam Thomson]
2014-02-06 11:46 ` Opensource [Adam Thomson]
[not found] ` <2E89032DDAA8B9408CB92943514A03376B7E368A-68WUHU125fLzLL1Oxlh9IgLouzNaz+3S@public.gmane.org>
2014-02-06 13:22 ` Guenter Roeck
2014-02-06 13:22 ` Guenter Roeck
2014-02-06 13:31 ` Opensource [Adam Thomson]
2014-02-06 13:31 ` Opensource [Adam Thomson]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140206143050.GU32298@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=a.zummo@towertech.it \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.