From: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
To: Adam Thomson
<Adam.Thomson.Opensource-WBD+wuPFNBhBDgjK7y7TUQ@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Dmitry Torokhov
<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Alessandro Zummo
<a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org>
Subject: Re: [PATCH 0/8] da9055: Driver initialisation fixes, add DT support
Date: Wed, 5 Feb 2014 16:54:06 -0800 [thread overview]
Message-ID: <20140206005406.GC1308@roeck-us.net> (raw)
In-Reply-To: <cover.1391614923.git.Adam.Thomson.Opensource-WBD+wuPFNBhBDgjK7y7TUQ@public.gmane.org>
On Wed, Feb 05, 2014 at 05:48:28PM +0000, Adam Thomson wrote:
> This patch series provides the following updates for DA9055 drivers:
>
> - Fixes an issue with da9055 driver initialisation (conflicting device ids) of
> PMIC (MFD) and CODEC drivers.
> - Add initial DT support for DA9055 related drivers, including binding
> documentation.
> - Remove conflicting use of platform_get_irq_byname() in driver probes.
Adam,
You don't really explain what the problem actually is. Can you elaborate ?
Also, I have been using platform_get_irq() to get the interrupt resource
in mfd client drivers and similar situations. Wouldn't this work here as well
if you don't want to use platform_get_irq_byname() ?
Thanks,
Guenter
> - Remove unnecessary resource structures for MFD cells as a result of removing
> use of platform_get_irq_byname().
>
> Adam Thomson (8):
> ASoC: da9055: Fix device registration of PMIC and CODEC devices
> ASoC: da9055: Add DT support for CODEC
> mfd: da9055: Add DT support for PMIC
> regulator: da9055: Add DT support
> onkey: da9055: Remove use of platform_get_irq_byname()
> hwmon: da9055: Remove use of platform_get_irq_byname()
> rtc: da9055: Remove use of platform_get_irq_byname()
> mfd: da9055: Remove unused resource structures for mfd cells.
>
> Documentation/devicetree/bindings/mfd/da9055.txt | 73 ++++++++++++++++++++
> Documentation/devicetree/bindings/sound/da9055.txt | 22 ++++++
> drivers/hwmon/da9055-hwmon.c | 7 +--
> drivers/input/misc/da9055_onkey.c | 9 +--
> drivers/mfd/da9055-core.c | 46 ------------
> drivers/mfd/da9055-i2c.c | 20 +++++-
> drivers/regulator/da9055-regulator.c | 59 ++++++++++++++--
> drivers/rtc/rtc-da9055.c | 3 +-
> sound/soc/codecs/da9055.c | 19 +++++-
> 9 files changed, 188 insertions(+), 70 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/mfd/da9055.txt
> create mode 100644 Documentation/devicetree/bindings/sound/da9055.txt
>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Cc: Mark Brown <broonie@kernel.org>, Lee Jones <lee.jones@linaro.org>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Alessandro Zummo <a.zummo@towertech.it>
Subject: Re: [PATCH 0/8] da9055: Driver initialisation fixes, add DT support
Date: Wed, 5 Feb 2014 16:54:06 -0800 [thread overview]
Message-ID: <20140206005406.GC1308@roeck-us.net> (raw)
In-Reply-To: <cover.1391614923.git.Adam.Thomson.Opensource@diasemi.com>
On Wed, Feb 05, 2014 at 05:48:28PM +0000, Adam Thomson wrote:
> This patch series provides the following updates for DA9055 drivers:
>
> - Fixes an issue with da9055 driver initialisation (conflicting device ids) of
> PMIC (MFD) and CODEC drivers.
> - Add initial DT support for DA9055 related drivers, including binding
> documentation.
> - Remove conflicting use of platform_get_irq_byname() in driver probes.
Adam,
You don't really explain what the problem actually is. Can you elaborate ?
Also, I have been using platform_get_irq() to get the interrupt resource
in mfd client drivers and similar situations. Wouldn't this work here as well
if you don't want to use platform_get_irq_byname() ?
Thanks,
Guenter
> - Remove unnecessary resource structures for MFD cells as a result of removing
> use of platform_get_irq_byname().
>
> Adam Thomson (8):
> ASoC: da9055: Fix device registration of PMIC and CODEC devices
> ASoC: da9055: Add DT support for CODEC
> mfd: da9055: Add DT support for PMIC
> regulator: da9055: Add DT support
> onkey: da9055: Remove use of platform_get_irq_byname()
> hwmon: da9055: Remove use of platform_get_irq_byname()
> rtc: da9055: Remove use of platform_get_irq_byname()
> mfd: da9055: Remove unused resource structures for mfd cells.
>
> Documentation/devicetree/bindings/mfd/da9055.txt | 73 ++++++++++++++++++++
> Documentation/devicetree/bindings/sound/da9055.txt | 22 ++++++
> drivers/hwmon/da9055-hwmon.c | 7 +--
> drivers/input/misc/da9055_onkey.c | 9 +--
> drivers/mfd/da9055-core.c | 46 ------------
> drivers/mfd/da9055-i2c.c | 20 +++++-
> drivers/regulator/da9055-regulator.c | 59 ++++++++++++++--
> drivers/rtc/rtc-da9055.c | 3 +-
> sound/soc/codecs/da9055.c | 19 +++++-
> 9 files changed, 188 insertions(+), 70 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/mfd/da9055.txt
> create mode 100644 Documentation/devicetree/bindings/sound/da9055.txt
>
>
next prev parent reply other threads:[~2014-02-06 0:54 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 17:48 [PATCH 0/8] da9055: Driver initialisation fixes, add DT support Adam Thomson
2014-02-05 17:48 ` Adam Thomson
2014-02-05 17:48 ` [PATCH 1/8] ASoC: da9055: Fix device registration of PMIC and CODEC devices Adam Thomson
2014-02-05 17:48 ` Adam Thomson
[not found] ` <6a398d176b0b2bf8792d27bd5e2995fd96afb32d.1391614923.git.Adam.Thomson.Opensource-WBD+wuPFNBhBDgjK7y7TUQ@public.gmane.org>
2014-02-05 18:38 ` Mark Brown
2014-02-05 18:38 ` Mark Brown
2014-02-05 17:48 ` [PATCH 2/8] ASoC: da9055: Add DT support for CODEC Adam Thomson
2014-02-05 17:48 ` Adam Thomson
2014-02-05 17:48 ` [PATCH 3/8] mfd: da9055: Add DT support for PMIC Adam Thomson
2014-02-05 17:48 ` Adam Thomson
2014-02-05 17:48 ` [PATCH 4/8] regulator: da9055: Add DT support Adam Thomson
2014-02-05 17:48 ` Adam Thomson
[not found] ` <6d76ae40cd435eaae0323f3e806515130b06a376.1391614923.git.Adam.Thomson.Opensource-WBD+wuPFNBhBDgjK7y7TUQ@public.gmane.org>
2014-02-05 18:36 ` Mark Brown
2014-02-05 18:36 ` Mark Brown
2014-02-06 11:31 ` Opensource [Adam Thomson]
2014-02-06 11:31 ` Opensource [Adam Thomson]
[not found] ` <2E89032DDAA8B9408CB92943514A03376B7E1669-68WUHU125fLzLL1Oxlh9IgLouzNaz+3S@public.gmane.org>
2014-02-06 12:03 ` Mark Brown
2014-02-06 12:03 ` Mark Brown
[not found] ` <20140206120336.GL32298-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-02-06 12:22 ` Opensource [Adam Thomson]
2014-02-06 12:22 ` Opensource [Adam Thomson]
2014-02-06 14:30 ` Mark Brown
2014-02-05 17:48 ` [PATCH 5/8] onkey: da9055: Remove use of platform_get_irq_byname() Adam Thomson
2014-02-05 17:48 ` Adam Thomson
2014-02-05 17:48 ` [PATCH 6/8] hwmon: " Adam Thomson
2014-02-05 17:48 ` Adam Thomson
2014-02-05 17:48 ` [PATCH 7/8] rtc: " Adam Thomson
2014-02-05 17:48 ` Adam Thomson
2014-02-05 17:48 ` [PATCH 8/8] mfd: da9055: Remove unused resource structures for mfd cells Adam Thomson
2014-02-05 17:48 ` Adam Thomson
[not found] ` <cover.1391614923.git.Adam.Thomson.Opensource-WBD+wuPFNBhBDgjK7y7TUQ@public.gmane.org>
2014-02-06 0:54 ` Guenter Roeck [this message]
2014-02-06 0:54 ` [PATCH 0/8] da9055: Driver initialisation fixes, add DT support Guenter Roeck
[not found] ` <20140206005406.GC1308-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2014-02-06 11:46 ` Opensource [Adam Thomson]
2014-02-06 11:46 ` Opensource [Adam Thomson]
[not found] ` <2E89032DDAA8B9408CB92943514A03376B7E368A-68WUHU125fLzLL1Oxlh9IgLouzNaz+3S@public.gmane.org>
2014-02-06 13:22 ` Guenter Roeck
2014-02-06 13:22 ` Guenter Roeck
2014-02-06 13:31 ` Opensource [Adam Thomson]
2014-02-06 13:31 ` Opensource [Adam Thomson]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140206005406.GC1308@roeck-us.net \
--to=linux-0h96xk9xttrk1umjsbkqmq@public.gmane.org \
--cc=Adam.Thomson.Opensource-WBD+wuPFNBhBDgjK7y7TUQ@public.gmane.org \
--cc=a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.