From: Peter Zijlstra <peterz@infradead.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Tom Musta <tommusta@gmail.com>,
linux-kernel@vger.kernel.org, Torsten Duwe <duwe@lst.de>,
Anton Blanchard <anton@samba.org>,
Scott Wood <scottwood@freescale.com>,
Paul Mackerras <paulus@samba.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] Convert powerpc simple spinlocks into ticket locks
Date: Fri, 7 Feb 2014 17:10:04 +0100 [thread overview]
Message-ID: <20140207161004.GD9987@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <87C29DBB-41E7-4B6C-9089-3C7756FBAE07@kernel.crashing.org>
On Fri, Feb 07, 2014 at 09:51:16AM -0600, Kumar Gala wrote:
>
> On Feb 7, 2014, at 3:02 AM, Torsten Duwe <duwe@lst.de> wrote:
>
> > On Thu, Feb 06, 2014 at 02:19:52PM -0600, Scott Wood wrote:
> >> On Thu, 2014-02-06 at 18:37 +0100, Torsten Duwe wrote:
> >>> On Thu, Feb 06, 2014 at 05:38:37PM +0100, Peter Zijlstra wrote:
> >>
> >>>> Can you pair lwarx with sthcx ? I couldn't immediately find the answer
> >>>> in the PowerISA doc. If so I think you can do better by being able to
> >>>> atomically load both tickets but only storing the head without affecting
> >>>> the tail.
> >
> > Can I simply write the half word, without a reservation, or will the HW caches
> > mess up the other half? Will it ruin the cache coherency on some (sub)architectures?
>
> The coherency should be fine, I just can’t remember if you’ll lose the reservation by doing this.
It should; I suppose; seeing how you 'destroy' the state it got from the
load.
> >> Plus, sthcx doesn't exist on all PPC chips.
> >
> > Which ones are lacking it? Do all have at least a simple 16-bit store?
>
> Everything implements a simple 16-bit store, just not everything implements the store conditional of 16-bit data.
Ok, so then the last version I posted should work on those machines.
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Torsten Duwe <duwe@lst.de>, Scott Wood <scottwood@freescale.com>,
Tom Musta <tommusta@gmail.com>,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Anton Blanchard <anton@samba.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] Convert powerpc simple spinlocks into ticket locks
Date: Fri, 7 Feb 2014 17:10:04 +0100 [thread overview]
Message-ID: <20140207161004.GD9987@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <87C29DBB-41E7-4B6C-9089-3C7756FBAE07@kernel.crashing.org>
On Fri, Feb 07, 2014 at 09:51:16AM -0600, Kumar Gala wrote:
>
> On Feb 7, 2014, at 3:02 AM, Torsten Duwe <duwe@lst.de> wrote:
>
> > On Thu, Feb 06, 2014 at 02:19:52PM -0600, Scott Wood wrote:
> >> On Thu, 2014-02-06 at 18:37 +0100, Torsten Duwe wrote:
> >>> On Thu, Feb 06, 2014 at 05:38:37PM +0100, Peter Zijlstra wrote:
> >>
> >>>> Can you pair lwarx with sthcx ? I couldn't immediately find the answer
> >>>> in the PowerISA doc. If so I think you can do better by being able to
> >>>> atomically load both tickets but only storing the head without affecting
> >>>> the tail.
> >
> > Can I simply write the half word, without a reservation, or will the HW caches
> > mess up the other half? Will it ruin the cache coherency on some (sub)architectures?
>
> The coherency should be fine, I just can’t remember if you’ll lose the reservation by doing this.
It should; I suppose; seeing how you 'destroy' the state it got from the
load.
> >> Plus, sthcx doesn't exist on all PPC chips.
> >
> > Which ones are lacking it? Do all have at least a simple 16-bit store?
>
> Everything implements a simple 16-bit store, just not everything implements the store conditional of 16-bit data.
Ok, so then the last version I posted should work on those machines.
next prev parent reply other threads:[~2014-02-07 16:10 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 10:37 [PATCH] Convert powerpc simple spinlocks into ticket locks Torsten Duwe
2014-02-06 10:37 ` Torsten Duwe
2014-02-06 15:53 ` Benjamin Herrenschmidt
2014-02-06 15:53 ` Benjamin Herrenschmidt
2014-02-06 16:38 ` Peter Zijlstra
2014-02-06 16:38 ` Peter Zijlstra
2014-02-06 17:37 ` Torsten Duwe
2014-02-06 17:37 ` Torsten Duwe
2014-02-06 18:08 ` Peter Zijlstra
2014-02-06 18:08 ` Peter Zijlstra
2014-02-06 19:28 ` Tom Musta
2014-02-10 2:54 ` Benjamin Herrenschmidt
2014-02-10 2:54 ` Benjamin Herrenschmidt
2014-02-07 8:24 ` Torsten Duwe
2014-02-07 8:24 ` Torsten Duwe
2014-02-06 20:19 ` Scott Wood
2014-02-06 20:19 ` Scott Wood
2014-02-07 9:02 ` Torsten Duwe
2014-02-07 9:02 ` Torsten Duwe
2014-02-07 10:31 ` Peter Zijlstra
2014-02-07 10:31 ` Peter Zijlstra
2014-02-07 10:36 ` Peter Zijlstra
2014-02-07 10:36 ` Peter Zijlstra
2014-02-07 10:45 ` Peter Zijlstra
2014-02-07 10:45 ` Peter Zijlstra
2014-02-07 11:49 ` Torsten Duwe
2014-02-07 11:49 ` Torsten Duwe
2014-02-07 12:28 ` Peter Zijlstra
2014-02-07 12:28 ` Peter Zijlstra
2014-02-07 15:18 ` Peter Zijlstra
2014-02-07 15:18 ` Peter Zijlstra
2014-02-07 15:43 ` Peter Zijlstra
2014-02-07 15:43 ` Peter Zijlstra
2014-02-07 17:08 ` Torsten Duwe
2014-02-07 17:08 ` Torsten Duwe
2014-02-07 17:19 ` Peter Zijlstra
2014-02-07 17:19 ` Peter Zijlstra
2014-02-07 15:51 ` Kumar Gala
2014-02-07 15:51 ` Kumar Gala
2014-02-07 16:10 ` Peter Zijlstra [this message]
2014-02-07 16:10 ` Peter Zijlstra
2014-02-10 3:05 ` Benjamin Herrenschmidt
2014-02-10 3:05 ` Benjamin Herrenschmidt
2014-02-10 3:02 ` Benjamin Herrenschmidt
2014-02-10 3:02 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140207161004.GD9987@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=anton@samba.org \
--cc=duwe@lst.de \
--cc=galak@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=scottwood@freescale.com \
--cc=tommusta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.