From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Jean-Francois Moine <moinejf@free.fr>
Cc: devel@driverdev.osuosl.org, alsa-devel@alsa-project.org,
Sascha Hauer <kernel@pengutronix.de>,
Takashi Iwai <tiwai@suse.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
dri-devel@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH RFC 0/2] drivers/base: simplify simple DT-based components
Date: Sat, 8 Feb 2014 00:23:54 +0000 [thread overview]
Message-ID: <20140208002354.GI26684@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20140207185911.GG26684@n2100.arm.linux.org.uk>
On Fri, Feb 07, 2014 at 06:59:11PM +0000, Russell King - ARM Linux wrote:
> Sorry. Deferred probe does work, it's been tested with imx-drm, not
> only from the master component but also the sub-components. There's
> no problem here.
Here's the proof that it also works with the Cubox, and armada DRM:
[drm] Initialized drm 1.1.0 20060810
...
armada-drm armada-510-drm: master bind failed: -517
i2c 0-0070: Driver tda998x requests probe deferral
...
tda998x 0-0070: found TDA19988
armada-drm armada-510-drm: bound 0-0070 (ops tda998x_ops)
So, in the above sequence, the armada DRM driver was bound to its driver
initially, but the TDA998x driver wasn't.
Then, the TDA998x driver is bound, which completes the requirements for
the DRM master. So the system attempts to bind.
In doing so, the master probe function discovers a missing clock (because
the SIL5531 driver hasn't probed) and it returns -EPROBE_DEFER. This
causes the probe of the TDA998x to be deferred.
Later, deferred probes are run - at this time the SIL5531 driver has
probed its device, and the clocks are now available. So when the TDA998x
driver is re-probed, it retriggers the binding attempt, and as the clock
can now be found, the system is bound and the DRM system for the device
is initialised.
I've just committed a patch locally which makes Armada DRM fully use
the component helper, which removes in totality the four armada_output.*
and armada_slave.* files since they're no longer required:
[cubox-3.13 e2713ff5ac2f] DRM: armada: remove non-component support
7 files changed, 8 insertions(+), 437 deletions(-)
delete mode 100644 drivers/gpu/drm/armada/armada_output.c
delete mode 100644 drivers/gpu/drm/armada/armada_output.h
delete mode 100644 drivers/gpu/drm/armada/armada_slave.c
delete mode 100644 drivers/gpu/drm/armada/armada_slave.h
--
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".
WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC 0/2] drivers/base: simplify simple DT-based components
Date: Sat, 8 Feb 2014 00:23:54 +0000 [thread overview]
Message-ID: <20140208002354.GI26684@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20140207185911.GG26684@n2100.arm.linux.org.uk>
On Fri, Feb 07, 2014 at 06:59:11PM +0000, Russell King - ARM Linux wrote:
> Sorry. Deferred probe does work, it's been tested with imx-drm, not
> only from the master component but also the sub-components. There's
> no problem here.
Here's the proof that it also works with the Cubox, and armada DRM:
[drm] Initialized drm 1.1.0 20060810
...
armada-drm armada-510-drm: master bind failed: -517
i2c 0-0070: Driver tda998x requests probe deferral
...
tda998x 0-0070: found TDA19988
armada-drm armada-510-drm: bound 0-0070 (ops tda998x_ops)
So, in the above sequence, the armada DRM driver was bound to its driver
initially, but the TDA998x driver wasn't.
Then, the TDA998x driver is bound, which completes the requirements for
the DRM master. So the system attempts to bind.
In doing so, the master probe function discovers a missing clock (because
the SIL5531 driver hasn't probed) and it returns -EPROBE_DEFER. This
causes the probe of the TDA998x to be deferred.
Later, deferred probes are run - at this time the SIL5531 driver has
probed its device, and the clocks are now available. So when the TDA998x
driver is re-probed, it retriggers the binding attempt, and as the clock
can now be found, the system is bound and the DRM system for the device
is initialised.
I've just committed a patch locally which makes Armada DRM fully use
the component helper, which removes in totality the four armada_output.*
and armada_slave.* files since they're no longer required:
[cubox-3.13 e2713ff5ac2f] DRM: armada: remove non-component support
7 files changed, 8 insertions(+), 437 deletions(-)
delete mode 100644 drivers/gpu/drm/armada/armada_output.c
delete mode 100644 drivers/gpu/drm/armada/armada_output.h
delete mode 100644 drivers/gpu/drm/armada/armada_slave.c
delete mode 100644 drivers/gpu/drm/armada/armada_slave.h
--
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Jean-Francois Moine <moinejf@free.fr>
Cc: devel@driverdev.osuosl.org, alsa-devel@alsa-project.org,
Daniel Vetter <daniel@ffwll.ch>, Takashi Iwai <tiwai@suse.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
dri-devel@lists.freedesktop.org,
Sascha Hauer <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH RFC 0/2] drivers/base: simplify simple DT-based components
Date: Sat, 8 Feb 2014 00:23:54 +0000 [thread overview]
Message-ID: <20140208002354.GI26684@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20140207185911.GG26684@n2100.arm.linux.org.uk>
On Fri, Feb 07, 2014 at 06:59:11PM +0000, Russell King - ARM Linux wrote:
> Sorry. Deferred probe does work, it's been tested with imx-drm, not
> only from the master component but also the sub-components. There's
> no problem here.
Here's the proof that it also works with the Cubox, and armada DRM:
[drm] Initialized drm 1.1.0 20060810
...
armada-drm armada-510-drm: master bind failed: -517
i2c 0-0070: Driver tda998x requests probe deferral
...
tda998x 0-0070: found TDA19988
armada-drm armada-510-drm: bound 0-0070 (ops tda998x_ops)
So, in the above sequence, the armada DRM driver was bound to its driver
initially, but the TDA998x driver wasn't.
Then, the TDA998x driver is bound, which completes the requirements for
the DRM master. So the system attempts to bind.
In doing so, the master probe function discovers a missing clock (because
the SIL5531 driver hasn't probed) and it returns -EPROBE_DEFER. This
causes the probe of the TDA998x to be deferred.
Later, deferred probes are run - at this time the SIL5531 driver has
probed its device, and the clocks are now available. So when the TDA998x
driver is re-probed, it retriggers the binding attempt, and as the clock
can now be found, the system is bound and the DRM system for the device
is initialised.
I've just committed a patch locally which makes Armada DRM fully use
the component helper, which removes in totality the four armada_output.*
and armada_slave.* files since they're no longer required:
[cubox-3.13 e2713ff5ac2f] DRM: armada: remove non-component support
7 files changed, 8 insertions(+), 437 deletions(-)
delete mode 100644 drivers/gpu/drm/armada/armada_output.c
delete mode 100644 drivers/gpu/drm/armada/armada_output.h
delete mode 100644 drivers/gpu/drm/armada/armada_slave.c
delete mode 100644 drivers/gpu/drm/armada/armada_slave.h
--
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".
next prev parent reply other threads:[~2014-02-08 0:23 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 17:11 [PATCH RFC 0/2] drivers/base: simplify simple DT-based components Jean-Francois Moine
2014-02-07 17:11 ` Jean-Francois Moine
2014-02-07 17:11 ` Jean-Francois Moine
2014-02-07 15:55 ` [PATCH RFC 1/2] drivers/base: permit base components to omit the bind/unbind ops Jean-Francois Moine
2014-02-07 15:55 ` Jean-Francois Moine
2014-02-07 15:55 ` Jean-Francois Moine
2014-02-07 17:34 ` Russell King - ARM Linux
2014-02-07 17:34 ` Russell King - ARM Linux
2014-02-07 17:34 ` Russell King - ARM Linux
2014-02-07 16:53 ` [PATCH RFC 2/2] drivers/base: declare phandle DT nodes as components Jean-Francois Moine
2014-02-07 16:53 ` Jean-Francois Moine
2014-02-07 17:43 ` Russell King - ARM Linux
2014-02-07 17:43 ` Russell King - ARM Linux
2014-02-07 17:43 ` Russell King - ARM Linux
2014-02-07 17:33 ` [PATCH RFC 0/2] drivers/base: simplify simple DT-based components Russell King - ARM Linux
2014-02-07 17:33 ` Russell King - ARM Linux
2014-02-07 17:33 ` Russell King - ARM Linux
2014-02-07 18:42 ` Jean-Francois Moine
2014-02-07 18:42 ` Jean-Francois Moine
2014-02-07 18:59 ` Russell King - ARM Linux
2014-02-07 18:59 ` Russell King - ARM Linux
2014-02-07 18:59 ` Russell King - ARM Linux
2014-02-08 0:23 ` Russell King - ARM Linux [this message]
2014-02-08 0:23 ` Russell King - ARM Linux
2014-02-08 0:23 ` Russell King - ARM Linux
2014-02-07 20:23 ` Russell King - ARM Linux
2014-02-07 20:23 ` Russell King - ARM Linux
2014-02-07 20:23 ` Russell King - ARM Linux
2014-02-09 9:22 ` Jean-Francois Moine
2014-02-09 9:22 ` Jean-Francois Moine
2014-02-09 9:22 ` Jean-Francois Moine
2014-02-09 10:04 ` Russell King - ARM Linux
2014-02-09 10:04 ` Russell King - ARM Linux
2014-02-09 10:04 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140208002354.GI26684@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=daniel@ffwll.ch \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=moinejf@free.fr \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.