All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: "Russell King - ARM Linux" <linux@arm.linux.org.uk>
Cc: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	Liviu Dudau <Liviu.Dudau@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	"mohit.kumar@st.com" <mohit.kumar@st.com>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] PCI: ARM: add support for virtual PCI host controller
Date: Sun, 9 Feb 2014 21:18:19 +0100	[thread overview]
Message-ID: <201402092118.19701.arnd@arndb.de> (raw)
In-Reply-To: <20140206203114.GW26684@n2100.arm.linux.org.uk>

On Thursday 06 February 2014, Russell King - ARM Linux wrote:
> On Thu, Feb 06, 2014 at 09:28:52AM +0100, Arnd Bergmann wrote:
> > It certainly seems workable. OTOH if we just manage to do a
> > helper that scans the OF ranges, allocates the I/O window,
> > remaps it and calls the existing pci_add_resource_offset()
> > helper, PCI host drivers don't need to worry about the
> > io_offsets computation either and just need to pull out the
> > correct window locations if they need to set up the hardware
> > translation windows (which I'd hope we can often let the boot
> > loader take care of).

...

> So, whenever you enumerate a PCI bus, and read the resource information
> out of the BARs, you must know how that address region specified in
> the BAR as a bus address maps to the host address space.
> 

None of that contradicts what I wrote. Please try to understand what
I suggested, which is to have a common way to communicate that
information from DT to the PCI core without involving the PCI host
bridge driver.

All the bus scanning is done in common code, which already knows
how to factor in io_offset and mem_offset. The mem_offset can be
trivially computed from the ranges property, and the io_offset
is known by the time we call pci_ioremap_io() or rather a
replacement such as the one I proposed that also contains an
allocator.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] PCI: ARM: add support for virtual PCI host controller
Date: Sun, 9 Feb 2014 21:18:19 +0100	[thread overview]
Message-ID: <201402092118.19701.arnd@arndb.de> (raw)
In-Reply-To: <20140206203114.GW26684@n2100.arm.linux.org.uk>

On Thursday 06 February 2014, Russell King - ARM Linux wrote:
> On Thu, Feb 06, 2014 at 09:28:52AM +0100, Arnd Bergmann wrote:
> > It certainly seems workable. OTOH if we just manage to do a
> > helper that scans the OF ranges, allocates the I/O window,
> > remaps it and calls the existing pci_add_resource_offset()
> > helper, PCI host drivers don't need to worry about the
> > io_offsets computation either and just need to pull out the
> > correct window locations if they need to set up the hardware
> > translation windows (which I'd hope we can often let the boot
> > loader take care of).

...

> So, whenever you enumerate a PCI bus, and read the resource information
> out of the BARs, you must know how that address region specified in
> the BAR as a bus address maps to the host address space.
> 

None of that contradicts what I wrote. Please try to understand what
I suggested, which is to have a common way to communicate that
information from DT to the PCI core without involving the PCI host
bridge driver.

All the bus scanning is done in common code, which already knows
how to factor in io_offset and mem_offset. The mem_offset can be
trivially computed from the ranges property, and the io_offset
is known by the time we call pci_ioremap_io() or rather a
replacement such as the one I proposed that also contains an
allocator.

	Arnd

  reply	other threads:[~2014-02-09 20:19 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-04 16:53 [PATCH 0/3] ARM: PCI: implement virtual PCI host controller Will Deacon
2014-02-04 16:53 ` Will Deacon
2014-02-04 16:53 ` [PATCH 1/3] ARM: bios32: use pci_enable_resource to enable PCI resources Will Deacon
2014-02-04 16:53   ` Will Deacon
2014-02-12  1:06   ` Bjorn Helgaas
2014-02-12  1:06     ` Bjorn Helgaas
2014-02-12 16:18     ` Will Deacon
2014-02-12 16:18       ` Will Deacon
2014-02-04 16:53 ` [PATCH 2/3] PCI: ARM: add support for virtual PCI host controller Will Deacon
2014-02-04 16:53   ` Will Deacon
2014-02-04 19:13   ` Arnd Bergmann
2014-02-04 19:13     ` Arnd Bergmann
2014-02-05 19:09     ` Will Deacon
2014-02-05 19:09       ` Will Deacon
2014-02-05 19:27       ` Jason Gunthorpe
2014-02-05 19:27         ` Jason Gunthorpe
2014-02-05 19:41         ` Peter Maydell
2014-02-05 19:41           ` Peter Maydell
2014-02-05 20:26       ` Arnd Bergmann
2014-02-05 20:26         ` Arnd Bergmann
2014-02-05 20:53         ` Jason Gunthorpe
2014-02-05 20:53           ` Jason Gunthorpe
2014-02-06  8:28           ` Arnd Bergmann
2014-02-06  8:28             ` Arnd Bergmann
2014-02-06 20:31             ` Russell King - ARM Linux
2014-02-06 20:31               ` Russell King - ARM Linux
2014-02-09 20:18               ` Arnd Bergmann [this message]
2014-02-09 20:18                 ` Arnd Bergmann
2014-02-09 20:34                 ` Russell King - ARM Linux
2014-02-09 20:34                   ` Russell King - ARM Linux
2014-02-11 19:15                   ` Arnd Bergmann
2014-02-11 19:15                     ` Arnd Bergmann
2014-02-07 11:46         ` Will Deacon
2014-02-07 11:46           ` Will Deacon
2014-02-07 17:54           ` Jason Gunthorpe
2014-02-07 17:54             ` Jason Gunthorpe
2014-02-12 18:10             ` Will Deacon
2014-02-12 18:10               ` Will Deacon
2014-02-12 18:19               ` Jason Gunthorpe
2014-02-12 18:19                 ` Jason Gunthorpe
2014-02-12 18:21                 ` Will Deacon
2014-02-12 18:21                   ` Will Deacon
2014-02-09 20:30           ` Arnd Bergmann
2014-02-09 20:30             ` Arnd Bergmann
2014-02-10 17:34             ` Jason Gunthorpe
2014-02-10 17:34               ` Jason Gunthorpe
2014-02-11 10:42               ` Arnd Bergmann
2014-02-11 10:42                 ` Arnd Bergmann
2014-02-12 19:43                 ` Jason Gunthorpe
2014-02-12 19:43                   ` Jason Gunthorpe
2014-02-12 20:07                   ` Arnd Bergmann
2014-02-12 20:07                     ` Arnd Bergmann
2014-02-12 20:33                     ` Bjorn Helgaas
2014-02-12 20:33                       ` Bjorn Helgaas
2014-02-12 21:15                   ` Thomas Petazzoni
2014-02-12 21:15                     ` Thomas Petazzoni
2014-02-12 22:24                     ` Jason Gunthorpe
2014-02-12 22:24                       ` Jason Gunthorpe
2014-02-12 19:49                 ` Will Deacon
2014-02-12 19:49                   ` Will Deacon
2014-02-06  8:54   ` Anup Patel
2014-02-06  8:54     ` Anup Patel
2014-02-06 10:26     ` Arnd Bergmann
2014-02-06 10:26       ` Arnd Bergmann
2014-02-06 10:52       ` Anup Patel
2014-02-06 10:52         ` Anup Patel
2014-02-06 10:54     ` Liviu Dudau
2014-02-06 10:54       ` Liviu Dudau
2014-02-06 11:00       ` Will Deacon
2014-02-06 11:00         ` Will Deacon
2014-02-06 11:28         ` Arnd Bergmann
2014-02-06 11:28           ` Arnd Bergmann
2014-02-04 16:53 ` [PATCH 3/3] ARM: mach-virt: allow PCI support to be selected Will Deacon
2014-02-04 16:53   ` Will Deacon
2014-04-03 22:07 ` [PATCH 0/3] ARM: PCI: implement virtual PCI host controller Bjorn Helgaas
2014-04-03 22:07   ` Bjorn Helgaas
2014-04-14 17:13   ` Will Deacon
2014-04-14 17:13     ` Will Deacon
2014-04-14 18:48     ` Arnd Bergmann
2014-04-14 18:48       ` Arnd Bergmann
2014-04-15 14:47       ` Will Deacon
2014-04-15 14:47         ` Will Deacon
2014-04-15 15:26         ` Arnd Bergmann
2014-04-15 15:26           ` Arnd Bergmann
2014-04-16 13:58           ` Will Deacon
2014-04-16 13:58             ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201402092118.19701.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=Liviu.Dudau@arm.com \
    --cc=bhelgaas@google.com \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mohit.kumar@st.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.