All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joe Perches <joe@perches.com>, Andy Whitcroft <apw@canonical.com>
Cc: linux-kernel@vger.kernel.org
Subject: WARNING: Unnecessary parentheses - maybe == should be = ?
Date: Mon, 10 Feb 2014 12:27:10 +0300	[thread overview]
Message-ID: <20140210092710.GA10899@elgon.mountain> (raw)

These messages are terrifying...  We do not want to encourage a million
first patch submitters to start introducing = vs == bugs.

Did you look through the warning messages this generates?  Was it ever
appropriate to change the == to =?

Please remove the second part of that message.

Also there needs to be a mailing list for checkpatch.pl.  LKML is a
write only archive, but it's not a discussion list.

Also the seq_puts() warning messages should be put under --strict
because we have to fight against people submitting those patches.

regards,
dan carpenter

             reply	other threads:[~2014-02-10  9:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-10  9:27 Dan Carpenter [this message]
2014-02-10 17:19 ` WARNING: Unnecessary parentheses - maybe == should be = ? Joe Perches
2014-02-10 20:24   ` Dan Carpenter
2014-02-10 21:59     ` Joe Perches
2014-02-26  9:29       ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140210092710.GA10899@elgon.mountain \
    --to=dan.carpenter@oracle.com \
    --cc=apw@canonical.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.