From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>, linux-kernel@vger.kernel.org
Subject: Re: WARNING: Unnecessary parentheses - maybe == should be = ?
Date: Wed, 26 Feb 2014 12:29:54 +0300 [thread overview]
Message-ID: <20140226092954.GW26776@mwanda> (raw)
In-Reply-To: <1392069596.2507.23.camel@joe-AO722>
On Mon, Feb 10, 2014 at 01:59:56PM -0800, Joe Perches wrote:
> On Mon, 2014-02-10 at 23:24 +0300, Dan Carpenter wrote:
> > On Mon, Feb 10, 2014 at 09:19:46AM -0800, Joe Perches wrote:
> > > On Mon, 2014-02-10 at 12:27 +0300, Dan Carpenter wrote:
> > > > We do not want to encourage a million
> > > > first patch submitters to start introducing = vs == bugs.
> > > Definitely true and I didn't think of that.
> > So long as we can re-phrase it then I don't have a problem with the
> > warning.
>
> Do you have a suggested phrasing?
>
Unnecessary parentheses - this is C not LISP dummy.
regards,
dan carpenter
prev parent reply other threads:[~2014-02-26 9:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 9:27 WARNING: Unnecessary parentheses - maybe == should be = ? Dan Carpenter
2014-02-10 17:19 ` Joe Perches
2014-02-10 20:24 ` Dan Carpenter
2014-02-10 21:59 ` Joe Perches
2014-02-26 9:29 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140226092954.GW26776@mwanda \
--to=dan.carpenter@oracle.com \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.