Re: [PATCH 5/7] ARM: mx53-qsrb: enable USB OTG in host mode

From: "Eric Bénard" <eric@eukrea.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 5/7] ARM: mx53-qsrb: enable USB OTG in host mode
Date: Mon, 10 Feb 2014 09:28:54 +0100	[thread overview]
Message-ID: <20140210092854.5bf29d36@e6520eb> (raw)
In-Reply-To: <20140210081617.GF17250@pengutronix.de>

Hi Sascha,

Le Mon, 10 Feb 2014 09:16:17 +0100,
Sascha Hauer <s.hauer@pengutronix.de> a écrit :
> On Sat, Feb 08, 2014 at 03:16:10PM +0100, Eric Bénard wrote:
> >  &usbotg {
> > -       status = "okay";
> > +	phy_type = "utmi";
> > +	dr_mode = "host";
> > +	status = "okay";
> >  };
> 
> Do we need a barebox specific option to specify dr_mode? I mean barebox
> cannot do otg, so we need to specify dr_mode to host or device, but with
> the above change Linux is limited to host mode aswell.
> 
in chipidea-imx.c there is :

	mode = of_usb_get_dr_mode(ci->dev->device_node, NULL);

	switch (mode) {
	case USB_DR_MODE_HOST:
	default:
		ci->mode = IMX_USB_MODE_HOST;
		break;
	case USB_DR_MODE_PERIPHERAL:
		ci->mode = IMX_USB_MODE_DEVICE;
		break;
	}

so we could omit the dr_mode=host as it will default to host.

Eric

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox