From: Lee Jones <lee.jones@linaro.org>
To: Jingoo Han <jg1.han@samsung.com>
Cc: 'Andrew Morton' <akpm@linux-foundation.org>,
'Levente Kurusa' <levex@linux.com>,
'LKML' <linux-kernel@vger.kernel.org>,
'Jean-Christophe Plagniol-Villard' <plagnioj@jcrosoft.com>,
'Tomi Valkeinen' <tomi.valkeinen@ti.com>,
'FBDEV list' <linux-fbdev@vger.kernel.org>,
'Bryan Wu' <cooloney@gmail.com>
Subject: Re: [PATCH] backlight: replace kfree with put_device
Date: Mon, 10 Feb 2014 11:13:49 +0000 [thread overview]
Message-ID: <20140210111349.GA21522@lee--X1> (raw)
In-Reply-To: <003701cf25f6$3807c6d0$a8175470$%han@samsung.com>
> > As per the comments on device_register, we shouldn't call kfree()
> > right after a device_register() failure. Instead call put_device(),
> > which in turn will call bl_device_release resulting in a kfree to the
> > full structure.
> >
> > Signed-off-by: Levente Kurusa <levex@linux.com>
>
> (+cc Bryan Wu, Lee Jones)
>
> Acked-by: Jingoo Han <jg1.han@samsung.com>
Applied to temporary Backlight repo [1], thanks.
[1] git://git.linaro.org/people/lee.jones/backlight.git
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Andrew Morton'" <akpm@linux-foundation.org>,
"'Levente Kurusa'" <levex@linux.com>,
"'LKML'" <linux-kernel@vger.kernel.org>,
"'Jean-Christophe Plagniol-Villard'" <plagnioj@jcrosoft.com>,
"'Tomi Valkeinen'" <tomi.valkeinen@ti.com>,
"'FBDEV list'" <linux-fbdev@vger.kernel.org>,
"'Bryan Wu'" <cooloney@gmail.com>
Subject: Re: [PATCH] backlight: replace kfree with put_device
Date: Mon, 10 Feb 2014 11:13:49 +0000 [thread overview]
Message-ID: <20140210111349.GA21522@lee--X1> (raw)
In-Reply-To: <003701cf25f6$3807c6d0$a8175470$%han@samsung.com>
> > As per the comments on device_register, we shouldn't call kfree()
> > right after a device_register() failure. Instead call put_device(),
> > which in turn will call bl_device_release resulting in a kfree to the
> > full structure.
> >
> > Signed-off-by: Levente Kurusa <levex@linux.com>
>
> (+cc Bryan Wu, Lee Jones)
>
> Acked-by: Jingoo Han <jg1.han@samsung.com>
Applied to temporary Backlight repo [1], thanks.
[1] git://git.linaro.org/people/lee.jones/backlight.git
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-02-10 11:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 8:43 [PATCH] backlight: replace kfree with put_device Levente Kurusa
2014-02-07 8:43 ` Levente Kurusa
2014-02-10 0:22 ` Jingoo Han
2014-02-10 0:22 ` Jingoo Han
2014-02-10 11:13 ` Lee Jones [this message]
2014-02-10 11:13 ` Lee Jones
2014-02-10 17:37 ` Bryan Wu
2014-02-10 17:37 ` Bryan Wu
2014-02-10 17:47 ` Lee Jones
2014-02-10 17:47 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140210111349.GA21522@lee--X1 \
--to=lee.jones@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=cooloney@gmail.com \
--cc=jg1.han@samsung.com \
--cc=levex@linux.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.