diff for duplicates of <20140210180159.GF26997@lee--X1> diff --git a/a/1.txt b/N1/1.txt index 4618624..da42f4a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,28 +1,30 @@ -PiA+ID4gPiBNaWdodCBiZSB3b3J0aCB0YWtpbmcgdGhlIG9wcG9ydHVuaXR5IHRvIHN3YXAgb3V0 -IHRoZXNlIG1hZ2ljIG51bWJlcnMKPiA+ID4gPiBub3cuCj4gPiA+IAo+ID4gPiBUaGVyZSdzIG5v -dGhpbmcgbWFnaWMgYWJvdXQgdGhlbSwgdGhleSB0ZWxsIHRoZSBkcml2ZXIgaG93IG1hbnkgZmFu -cwo+ID4gPiBlYWNoIGRldmljZSBzdXBwb3J0cy4gSWYgeW91IGRvbid0IHBhc3MgdGhlbSBhcyBk -cml2ZXJfZGF0YSB5b3UnbGwgaGF2ZQo+ID4gPiB0byBkZXJpdmUgdGhlbSBmcm9tIHRoZSBkZXZp -Y2UgbmFtZSBpbiB0aGUgcHJvYmUgZnVuY3Rpb24uCj4gPiAKPiA+IFRoZXkncmUgbWFnaWMgaW4g -dGhhdCB0aGV5J3JlIG5vdCBlYXNpbHkgaWRlbnRpZmlhYmxlLiBJbiB0aGUgZmV3Cj4gPiBtb21l -bnRzIHRoYXQgSSBsb29rZWQgYXQgdGhlIHBhdGNoIEkgYXNzdW1lZCB0aGV5IHdlcmUgZGV2aWNl -Cj4gPiBJRHMuIFRoZXkgc2hvdWxkIGJlIGNsZWFybHkgZGVmaW5lZC4KPiAKPiBUaGV5IGNvdWxk -IGhhdmUgYmVlbiBkZXZpY2UgSURzLCBzb21lIGRyaXZlcnMgZG8gdGhhdCwgYW5kIHRoYXQgd291 -bGQKPiBoYXZlIGJlZW4gZXF1YWxseSBmaW5lLiBkcml2ZXJfZGF0YSBjYW4gYmUgYW55dGhpbmcu -IEJlc3QgdGhpbmcgdG8gZG8KPiBpcyB0byBkb2N1bWVudCBpdCByaWdodCBhYm92ZSB0aGUgZGV2 -aWNlIGlkIGFycmF5IGlmIHlvdSByZWFsbHkgZmluZCBpdAo+IGNvbmZ1c2luZyAoSSBkb24ndC4p -IEkgZG9uJ3Qga25vdyB3aGF0IGVsc2UgZXhhY3RseSB5b3UgaGFkIGluIG1pbmQsCj4gYnV0ICNk -ZWZpbmluZyBGT1VSX0ZBTlMgYXMgNCBhbmQgT05FX0ZBTiBhcyAxIGFuZCB1c2luZyB0aGF0IGRv -ZXNuJ3QKPiBzdHJpa2UgbWUgYXMgdGhlIGJlc3QgY29kaW5nIHByYWN0aWNlLgoKT24gdGhlIGNv -bnRyYXJ5LiBQZXJoYXBzIHRoZSBub21lbmNsYXR1cmUgY2FuIGJlIHdvcmtlZCBvbiBhIGxpdHRs -ZSwKYnV0IGlmIEkgc2F3IHRoZSBhZm9yZW1lbnRpb25lZCBkZWZpbmVzIEkgd291bGQgaGF2ZSBr -bm93biBpbnN0YW50bHkKd2hhdCB3YXMgYmVpbmcgZGVmaW5lZCB3aXRob3V0IHNlYXJjaGluZyBm -b3IgY28tbG9jYXRlZCBjb21tZW50cy4gVGh1cwplbGV2YXRpbmcgdGhlIHJlcXVpcmVtZW50IGZv -ciBtZSB0byBldmVuIG1lbnRpb24gaXQuIEV2ZW4gd2hlbiB3ZQp1c2UgdGhlIC5kYXRhIGVsZW1l -bnQgZm9yIHZlcnkgc2ltcGxlIGluZm9ybWF0aW9uIHN1Y2ggYXMgZGV2aWNlIElEcwp3ZSBkbyBz -byB3aXRoIGEgI2RlZmluZS4KCi0tIApMZWUgSm9uZXMKTGluYXJvIFNUTWljcm9lbGVjdHJvbmlj -cyBMYW5kaW5nIFRlYW0gTGVhZApMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBm -b3IgQVJNIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19f -X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbG0tc2Vuc29ycyBt -YWlsaW5nIGxpc3QKbG0tc2Vuc29yc0BsbS1zZW5zb3JzLm9yZwpodHRwOi8vbGlzdHMubG0tc2Vu -c29ycy5vcmcvbWFpbG1hbi9saXN0aW5mby9sbS1zZW5zb3Jz +> > > > Might be worth taking the opportunity to swap out these magic numbers +> > > > now. +> > > +> > > There's nothing magic about them, they tell the driver how many fans +> > > each device supports. If you don't pass them as driver_data you'll have +> > > to derive them from the device name in the probe function. +> > +> > They're magic in that they're not easily identifiable. In the few +> > moments that I looked at the patch I assumed they were device +> > IDs. They should be clearly defined. +> +> They could have been device IDs, some drivers do that, and that would +> have been equally fine. driver_data can be anything. Best thing to do +> is to document it right above the device id array if you really find it +> confusing (I don't.) I don't know what else exactly you had in mind, +> but #defining FOUR_FANS as 4 and ONE_FAN as 1 and using that doesn't +> strike me as the best coding practice. + +On the contrary. Perhaps the nomenclature can be worked on a little, +but if I saw the aforementioned defines I would have known instantly +what was being defined without searching for co-located comments. Thus +elevating the requirement for me to even mention it. Even when we +use the .data element for very simple information such as device IDs +we do so with a #define. + +-- +Lee Jones +Linaro STMicroelectronics Landing Team Lead +Linaro.org │ Open source software for ARM SoCs +Follow Linaro: Facebook | Twitter | Blog diff --git a/a/content_digest b/N1/content_digest index 71f642e..a18d1ab 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,7 +4,7 @@ "ref\020140210165853.GD26997@lee--X1\0" "ref\020140210184323.456e921c@endymion.delvare\0" "From\0Lee Jones <lee.jones@linaro.org>\0" - "Subject\0Re: [lm-sensors] [PATCH] hwmon: (max6650) Rename the device ids to contain the hwmon suffix\0" + "Subject\0Re: [PATCH] hwmon: (max6650) Rename the device ids to contain the hwmon suffix\0" "Date\0Mon, 10 Feb 2014 18:01:59 +0000\0" "To\0Jean Delvare <jdelvare@suse.de>\0" "Cc\0Laszlo Papp <lpapp@kde.org>" @@ -12,33 +12,35 @@ " lm-sensors@lm-sensors.org\0" "\00:1\0" "b\0" - "PiA+ID4gPiBNaWdodCBiZSB3b3J0aCB0YWtpbmcgdGhlIG9wcG9ydHVuaXR5IHRvIHN3YXAgb3V0\n" - "IHRoZXNlIG1hZ2ljIG51bWJlcnMKPiA+ID4gPiBub3cuCj4gPiA+IAo+ID4gPiBUaGVyZSdzIG5v\n" - "dGhpbmcgbWFnaWMgYWJvdXQgdGhlbSwgdGhleSB0ZWxsIHRoZSBkcml2ZXIgaG93IG1hbnkgZmFu\n" - "cwo+ID4gPiBlYWNoIGRldmljZSBzdXBwb3J0cy4gSWYgeW91IGRvbid0IHBhc3MgdGhlbSBhcyBk\n" - "cml2ZXJfZGF0YSB5b3UnbGwgaGF2ZQo+ID4gPiB0byBkZXJpdmUgdGhlbSBmcm9tIHRoZSBkZXZp\n" - "Y2UgbmFtZSBpbiB0aGUgcHJvYmUgZnVuY3Rpb24uCj4gPiAKPiA+IFRoZXkncmUgbWFnaWMgaW4g\n" - "dGhhdCB0aGV5J3JlIG5vdCBlYXNpbHkgaWRlbnRpZmlhYmxlLiBJbiB0aGUgZmV3Cj4gPiBtb21l\n" - "bnRzIHRoYXQgSSBsb29rZWQgYXQgdGhlIHBhdGNoIEkgYXNzdW1lZCB0aGV5IHdlcmUgZGV2aWNl\n" - "Cj4gPiBJRHMuIFRoZXkgc2hvdWxkIGJlIGNsZWFybHkgZGVmaW5lZC4KPiAKPiBUaGV5IGNvdWxk\n" - "IGhhdmUgYmVlbiBkZXZpY2UgSURzLCBzb21lIGRyaXZlcnMgZG8gdGhhdCwgYW5kIHRoYXQgd291\n" - "bGQKPiBoYXZlIGJlZW4gZXF1YWxseSBmaW5lLiBkcml2ZXJfZGF0YSBjYW4gYmUgYW55dGhpbmcu\n" - "IEJlc3QgdGhpbmcgdG8gZG8KPiBpcyB0byBkb2N1bWVudCBpdCByaWdodCBhYm92ZSB0aGUgZGV2\n" - "aWNlIGlkIGFycmF5IGlmIHlvdSByZWFsbHkgZmluZCBpdAo+IGNvbmZ1c2luZyAoSSBkb24ndC4p\n" - "IEkgZG9uJ3Qga25vdyB3aGF0IGVsc2UgZXhhY3RseSB5b3UgaGFkIGluIG1pbmQsCj4gYnV0ICNk\n" - "ZWZpbmluZyBGT1VSX0ZBTlMgYXMgNCBhbmQgT05FX0ZBTiBhcyAxIGFuZCB1c2luZyB0aGF0IGRv\n" - "ZXNuJ3QKPiBzdHJpa2UgbWUgYXMgdGhlIGJlc3QgY29kaW5nIHByYWN0aWNlLgoKT24gdGhlIGNv\n" - "bnRyYXJ5LiBQZXJoYXBzIHRoZSBub21lbmNsYXR1cmUgY2FuIGJlIHdvcmtlZCBvbiBhIGxpdHRs\n" - "ZSwKYnV0IGlmIEkgc2F3IHRoZSBhZm9yZW1lbnRpb25lZCBkZWZpbmVzIEkgd291bGQgaGF2ZSBr\n" - "bm93biBpbnN0YW50bHkKd2hhdCB3YXMgYmVpbmcgZGVmaW5lZCB3aXRob3V0IHNlYXJjaGluZyBm\n" - "b3IgY28tbG9jYXRlZCBjb21tZW50cy4gVGh1cwplbGV2YXRpbmcgdGhlIHJlcXVpcmVtZW50IGZv\n" - "ciBtZSB0byBldmVuIG1lbnRpb24gaXQuIEV2ZW4gd2hlbiB3ZQp1c2UgdGhlIC5kYXRhIGVsZW1l\n" - "bnQgZm9yIHZlcnkgc2ltcGxlIGluZm9ybWF0aW9uIHN1Y2ggYXMgZGV2aWNlIElEcwp3ZSBkbyBz\n" - "byB3aXRoIGEgI2RlZmluZS4KCi0tIApMZWUgSm9uZXMKTGluYXJvIFNUTWljcm9lbGVjdHJvbmlj\n" - "cyBMYW5kaW5nIFRlYW0gTGVhZApMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBm\n" - "b3IgQVJNIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19f\n" - "X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbG0tc2Vuc29ycyBt\n" - "YWlsaW5nIGxpc3QKbG0tc2Vuc29yc0BsbS1zZW5zb3JzLm9yZwpodHRwOi8vbGlzdHMubG0tc2Vu\n" - c29ycy5vcmcvbWFpbG1hbi9saXN0aW5mby9sbS1zZW5zb3Jz + "> > > > Might be worth taking the opportunity to swap out these magic numbers\n" + "> > > > now.\n" + "> > > \n" + "> > > There's nothing magic about them, they tell the driver how many fans\n" + "> > > each device supports. If you don't pass them as driver_data you'll have\n" + "> > > to derive them from the device name in the probe function.\n" + "> > \n" + "> > They're magic in that they're not easily identifiable. In the few\n" + "> > moments that I looked at the patch I assumed they were device\n" + "> > IDs. They should be clearly defined.\n" + "> \n" + "> They could have been device IDs, some drivers do that, and that would\n" + "> have been equally fine. driver_data can be anything. Best thing to do\n" + "> is to document it right above the device id array if you really find it\n" + "> confusing (I don't.) I don't know what else exactly you had in mind,\n" + "> but #defining FOUR_FANS as 4 and ONE_FAN as 1 and using that doesn't\n" + "> strike me as the best coding practice.\n" + "\n" + "On the contrary. Perhaps the nomenclature can be worked on a little,\n" + "but if I saw the aforementioned defines I would have known instantly\n" + "what was being defined without searching for co-located comments. Thus\n" + "elevating the requirement for me to even mention it. Even when we\n" + "use the .data element for very simple information such as device IDs\n" + "we do so with a #define.\n" + "\n" + "-- \n" + "Lee Jones\n" + "Linaro STMicroelectronics Landing Team Lead\n" + "Linaro.org \342\224\202 Open source software for ARM SoCs\n" + Follow Linaro: Facebook | Twitter | Blog -728a2121874f1a463264d9e4c0ad637caba6f04a216a514ca33f6275e1f1ed73 +f444f7a982404fff651daa6b181ae583d0cddd16e36c3c5cadf044fe7c817cf6
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.