From: Lee Jones <lee.jones@linaro.org>
To: Jean Delvare <jdelvare@suse.de>
Cc: Laszlo Papp <lpapp@kde.org>,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [PATCH] hwmon: (max6650) Rename the device ids to contain the hwmon suffix
Date: Mon, 10 Feb 2014 18:01:59 +0000 [thread overview]
Message-ID: <20140210180159.GF26997@lee--X1> (raw)
In-Reply-To: <20140210184323.456e921c@endymion.delvare>
PiA+ID4gPiBNaWdodCBiZSB3b3J0aCB0YWtpbmcgdGhlIG9wcG9ydHVuaXR5IHRvIHN3YXAgb3V0
IHRoZXNlIG1hZ2ljIG51bWJlcnMKPiA+ID4gPiBub3cuCj4gPiA+IAo+ID4gPiBUaGVyZSdzIG5v
dGhpbmcgbWFnaWMgYWJvdXQgdGhlbSwgdGhleSB0ZWxsIHRoZSBkcml2ZXIgaG93IG1hbnkgZmFu
cwo+ID4gPiBlYWNoIGRldmljZSBzdXBwb3J0cy4gSWYgeW91IGRvbid0IHBhc3MgdGhlbSBhcyBk
cml2ZXJfZGF0YSB5b3UnbGwgaGF2ZQo+ID4gPiB0byBkZXJpdmUgdGhlbSBmcm9tIHRoZSBkZXZp
Y2UgbmFtZSBpbiB0aGUgcHJvYmUgZnVuY3Rpb24uCj4gPiAKPiA+IFRoZXkncmUgbWFnaWMgaW4g
dGhhdCB0aGV5J3JlIG5vdCBlYXNpbHkgaWRlbnRpZmlhYmxlLiBJbiB0aGUgZmV3Cj4gPiBtb21l
bnRzIHRoYXQgSSBsb29rZWQgYXQgdGhlIHBhdGNoIEkgYXNzdW1lZCB0aGV5IHdlcmUgZGV2aWNl
Cj4gPiBJRHMuIFRoZXkgc2hvdWxkIGJlIGNsZWFybHkgZGVmaW5lZC4KPiAKPiBUaGV5IGNvdWxk
IGhhdmUgYmVlbiBkZXZpY2UgSURzLCBzb21lIGRyaXZlcnMgZG8gdGhhdCwgYW5kIHRoYXQgd291
bGQKPiBoYXZlIGJlZW4gZXF1YWxseSBmaW5lLiBkcml2ZXJfZGF0YSBjYW4gYmUgYW55dGhpbmcu
IEJlc3QgdGhpbmcgdG8gZG8KPiBpcyB0byBkb2N1bWVudCBpdCByaWdodCBhYm92ZSB0aGUgZGV2
aWNlIGlkIGFycmF5IGlmIHlvdSByZWFsbHkgZmluZCBpdAo+IGNvbmZ1c2luZyAoSSBkb24ndC4p
IEkgZG9uJ3Qga25vdyB3aGF0IGVsc2UgZXhhY3RseSB5b3UgaGFkIGluIG1pbmQsCj4gYnV0ICNk
ZWZpbmluZyBGT1VSX0ZBTlMgYXMgNCBhbmQgT05FX0ZBTiBhcyAxIGFuZCB1c2luZyB0aGF0IGRv
ZXNuJ3QKPiBzdHJpa2UgbWUgYXMgdGhlIGJlc3QgY29kaW5nIHByYWN0aWNlLgoKT24gdGhlIGNv
bnRyYXJ5LiBQZXJoYXBzIHRoZSBub21lbmNsYXR1cmUgY2FuIGJlIHdvcmtlZCBvbiBhIGxpdHRs
ZSwKYnV0IGlmIEkgc2F3IHRoZSBhZm9yZW1lbnRpb25lZCBkZWZpbmVzIEkgd291bGQgaGF2ZSBr
bm93biBpbnN0YW50bHkKd2hhdCB3YXMgYmVpbmcgZGVmaW5lZCB3aXRob3V0IHNlYXJjaGluZyBm
b3IgY28tbG9jYXRlZCBjb21tZW50cy4gVGh1cwplbGV2YXRpbmcgdGhlIHJlcXVpcmVtZW50IGZv
ciBtZSB0byBldmVuIG1lbnRpb24gaXQuIEV2ZW4gd2hlbiB3ZQp1c2UgdGhlIC5kYXRhIGVsZW1l
bnQgZm9yIHZlcnkgc2ltcGxlIGluZm9ybWF0aW9uIHN1Y2ggYXMgZGV2aWNlIElEcwp3ZSBkbyBz
byB3aXRoIGEgI2RlZmluZS4KCi0tIApMZWUgSm9uZXMKTGluYXJvIFNUTWljcm9lbGVjdHJvbmlj
cyBMYW5kaW5nIFRlYW0gTGVhZApMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBm
b3IgQVJNIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbG0tc2Vuc29ycyBt
YWlsaW5nIGxpc3QKbG0tc2Vuc29yc0BsbS1zZW5zb3JzLm9yZwpodHRwOi8vbGlzdHMubG0tc2Vu
c29ycy5vcmcvbWFpbG1hbi9saXN0aW5mby9sbS1zZW5zb3Jz
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Jean Delvare <jdelvare@suse.de>
Cc: Laszlo Papp <lpapp@kde.org>,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [PATCH] hwmon: (max6650) Rename the device ids to contain the hwmon suffix
Date: Mon, 10 Feb 2014 18:01:59 +0000 [thread overview]
Message-ID: <20140210180159.GF26997@lee--X1> (raw)
In-Reply-To: <20140210184323.456e921c@endymion.delvare>
> > > > Might be worth taking the opportunity to swap out these magic numbers
> > > > now.
> > >
> > > There's nothing magic about them, they tell the driver how many fans
> > > each device supports. If you don't pass them as driver_data you'll have
> > > to derive them from the device name in the probe function.
> >
> > They're magic in that they're not easily identifiable. In the few
> > moments that I looked at the patch I assumed they were device
> > IDs. They should be clearly defined.
>
> They could have been device IDs, some drivers do that, and that would
> have been equally fine. driver_data can be anything. Best thing to do
> is to document it right above the device id array if you really find it
> confusing (I don't.) I don't know what else exactly you had in mind,
> but #defining FOUR_FANS as 4 and ONE_FAN as 1 and using that doesn't
> strike me as the best coding practice.
On the contrary. Perhaps the nomenclature can be worked on a little,
but if I saw the aforementioned defines I would have known instantly
what was being defined without searching for co-located comments. Thus
elevating the requirement for me to even mention it. Even when we
use the .data element for very simple information such as device IDs
we do so with a #define.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-02-10 18:01 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 15:25 [lm-sensors] [PATCH] hwmon: (max6650) Rename the device ids to contain the hwmon suffix Laszlo Papp
2014-02-10 15:25 ` Laszlo Papp
2014-02-10 16:08 ` [lm-sensors] " Lee Jones
2014-02-10 16:08 ` Lee Jones
2014-02-10 16:38 ` [lm-sensors] " Jean Delvare
2014-02-10 16:38 ` Jean Delvare
2014-02-10 16:53 ` linux
2014-02-10 16:53 ` linux
2014-02-10 18:59 ` Laszlo Papp
2014-02-10 18:59 ` Laszlo Papp
2014-02-10 23:10 ` Guenter Roeck
2014-02-10 23:10 ` Guenter Roeck
2014-02-11 3:23 ` Laszlo Papp
2014-02-11 3:23 ` Laszlo Papp
2014-02-11 3:35 ` Laszlo Papp
2014-02-11 3:35 ` Laszlo Papp
2014-02-10 16:58 ` Lee Jones
2014-02-10 16:58 ` Lee Jones
2014-02-10 17:43 ` Jean Delvare
2014-02-10 17:43 ` Jean Delvare
2014-02-10 18:01 ` Lee Jones [this message]
2014-02-10 18:01 ` Lee Jones
2014-02-10 18:15 ` [lm-sensors] " Jean Delvare
2014-02-10 18:15 ` Jean Delvare
2014-02-10 18:24 ` Lee Jones
2014-02-10 18:24 ` Lee Jones
2014-02-10 18:27 ` Laszlo Papp
2014-02-10 18:27 ` Laszlo Papp
2014-02-10 18:55 ` [lm-sensors] " Jean Delvare
2014-02-10 18:55 ` Jean Delvare
2014-02-10 17:06 ` Laszlo Papp
2014-02-10 17:06 ` Laszlo Papp
2014-02-10 17:09 ` Laszlo Papp
2014-02-10 17:09 ` Laszlo Papp
2014-02-11 3:13 ` Laszlo Papp
2014-02-11 3:13 ` Laszlo Papp
2014-02-11 7:50 ` Jean Delvare
2014-02-11 7:50 ` Jean Delvare
2014-02-11 8:19 ` Laszlo Papp
2014-02-11 8:19 ` Laszlo Papp
2014-02-11 8:28 ` Laszlo Papp
2014-02-11 8:28 ` Laszlo Papp
2014-02-11 8:49 ` Jean Delvare
2014-02-11 8:49 ` Jean Delvare
2014-02-11 9:08 ` Laszlo Papp
2014-02-11 9:08 ` Laszlo Papp
2014-02-11 9:57 ` Lee Jones
2014-02-11 9:57 ` Lee Jones
2014-02-11 15:15 ` Laszlo Papp
2014-02-11 15:15 ` Laszlo Papp
2014-02-11 8:50 ` Lee Jones
2014-02-11 8:50 ` Lee Jones
2014-02-11 8:58 ` Laszlo Papp
2014-02-11 8:58 ` Laszlo Papp
2014-02-11 9:14 ` Laszlo Papp
2014-02-11 9:14 ` Laszlo Papp
2014-02-11 9:47 ` Lee Jones
2014-02-11 9:47 ` Lee Jones
2014-02-11 9:50 ` Laszlo Papp
2014-02-11 9:50 ` Laszlo Papp
2014-02-11 10:22 ` Laszlo Papp
2014-02-11 10:22 ` Laszlo Papp
2014-02-11 11:09 ` Laszlo Papp
2014-02-11 11:09 ` Laszlo Papp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140210180159.GF26997@lee--X1 \
--to=lee.jones@linaro.org \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=lpapp@kde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.