From: Lee Jones <lee.jones@linaro.org>
To: Laszlo Papp <lpapp@kde.org>
Cc: Jean Delvare <jdelvare@suse.de>,
LKML <linux-kernel@vger.kernel.org>,
lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [PATCH] hwmon: (max6650) Rename the device ids to contain the hwmon suffix
Date: Tue, 11 Feb 2014 09:47:26 +0000 [thread overview]
Message-ID: <20140211094726.GH32042@lee--X1> (raw)
In-Reply-To: <CAOMwXhPfmXDKcov_+HHDTCaieGDiMEi+6CV_OnYDM3c8+S+bfA@mail.gmail.com>
PiA+PiA+PiBPbiBNb24sIEZlYiAxMCwgMjAxNCBhdCA0OjM4IFBNLCBKZWFuIERlbHZhcmUgPGpk
ZWx2YXJlQHN1c2UuZGU+IHdyb3RlOgo+ID4+ID4+ID4gQWRkaXRpb25hbGx5LCBkYXNoZXMgYXJl
IGV4cGxpY2l0bHkgZm9yYmlkZGVuIGluIGh3bW9uCj4gPj4gPj4gPiBkZXZpY2UgbmFtZXMuCj4g
Pj4gPj4KPiA+PiA+PiBBbHNvLCB3aGVyZSBpcyB0aGF0IGRvY3VtZW50ZWQ/Cj4gPj4gPgo+ID4+
ID4gSW4gRG9jdW1lbnRhdGlvbi9od21vbi9zeXNmcy1pbnRlcmZhY2U6Cj4gPj4gPgo+ID4+ID4g
KioqKioqKioqKioqKioqKioqKioqCj4gPj4gPiAqIEdsb2JhbCBhdHRyaWJ1dGVzICoKPiA+PiA+
ICoqKioqKioqKioqKioqKioqKioqKgo+ID4+ID4KPiA+PiA+IG5hbWUgICAgICAgICAgICBUaGUg
Y2hpcCBuYW1lLgo+ID4+ID4gICAgICAgICAgICAgICAgIFRoaXMgc2hvdWxkIGJlIGEgc2hvcnQs
IGxvd2VyY2FzZSBzdHJpbmcsIG5vdCBjb250YWluaW5nCj4gPj4gPiAgICAgICAgICAgICAgICAg
c3BhY2VzIG5vciBkYXNoZXMsIHJlcHJlc2VudGluZyB0aGUgY2hpcCBuYW1lLiBUaGlzIGlzCj4g
Pj4gPiAgICAgICAgICAgICAgICAgdGhlIG9ubHkgbWFuZGF0b3J5IGF0dHJpYnV0ZS4KPiA+PiA+
ICAgICAgICAgICAgICAgICBJMkMgZGV2aWNlcyBnZXQgdGhpcyBhdHRyaWJ1dGUgY3JlYXRlZCBh
dXRvbWF0aWNhbGx5Lgo+ID4+ID4gICAgICAgICAgICAgICAgIFJPCj4gPj4KPiA+PiBUaW1lIHRv
IHJldmlzaXQgdGhpcyBkZWNpc2lvbi4uLi4KPiA+Pgo+ID4+IFNvLCBiYXNlZCBvbiB0aGUgZmFj
dCB0aGF0IGNoaWxkcmVuIGRldmljZSBuYW1lcyB1c3VhbGx5IGNvbnRhaW4KPiA+PiBkYXNoZXMs
IEkgZG8gbm90IHVuZGVyc3RhbmQgd2h5IGh3bW9uIHdvdWxkIGJlIGFueSBzcGVjaWFsIGluIHRo
aXMKPiA+PiByZWdhcmQuIEl0IGlzIHBvc3NpYmxlIHRoYXQgdGhlIGh3bW9uIGRldmVsb3BlcnMg
aGF2ZSBub3QgZmFjZWQgbXVjaAo+ID4+IE1GRCBzaXR1YXRpb24gYmVmb3JlLCBhbmQgc28sIHRo
aXMgd2FzIG5vdCBjb25zaWRlcmVkIHRvIGJlIGhhbmRsZWQKPiA+PiBsaWtlIGluIG90aGVyIHN1
YnN5c3RlbXMuCj4gPj4KPiA+PiBJIGFtIHByb3Bvc2luZyB0byBjaGFuZ2UgdGhpcyAicnVsZSIu
Li4gIEFueSBvYmplY3Rpb24/Cj4gPgo+ID4gUHJpb3IgdG8gcHJvcG9zaW5nIHN1Y2ggYW4gaW52
YXNpdmUgY2hhbmdlIHdoaWNoIGlzIGhpZ2hseSBsaWtlbHkgdG8KPiA+IGNvbWUgdXAgYWdhaW5z
dCBoZWF2eSBvcHBvc2l0aW9uLAo+IAo+IEl0IGlzIHBvc3NpYmxlIHRoYXQgc29tZW9uZSBkb2Vz
IG5vdCB1bmRlcnN0YW5kIHdoeSB5b3UgdGhpbmsgaXQgbWF5Cj4gYmUgaW52YXNpdmUsIHJpZ2h0
PyBDb3VsZCB5b3UgcGxlYXNlIGV4cGxhaW4gdGhlIHJlYXNvbiBmb3IgdGhhdD8KClRoZSByZWFz
b24gaXMgYSBnb29kIG9uZS4gSW4gdGhlIGtlcm5lbCB3ZSBtYWtlIGV2ZXJ5IGF0dGVtcHQgbm90
IHRvCmJyZWFrIHVzZXJzcGFjZS4gQnkgdGhhdCBJIG1lYW4gX2FueV8gdXNlcnNwYWNlIGFwcGxp
Y2F0aW9uLiBVc2Vyc3BhY2UKYXBwbGljYXRpb25zIHdoaWNoIGludGVyZmFjZSB3aXRoIHRoZSBr
ZXJuZWwgY2FuIGRvIHNvIHZpYSBhIHZhcmlldHkgb2YKbWV0aG9kcy4gT25lIG9mIHRob3NlIGlz
IFN5c2ZzLCB3aGVyZSB0aGlzIG5hbWUgeW91IGFyZSBhdHRlbXB0aW5nIHRvCmNoYW5nZSBhcHBl
YXJzLiBUaGUgdXNlcnNwYWNlIGFwcGxpY2F0aW9ucyBhbHJlYWR5IG1lbnRpb25lZCBwYXJzZSBm
b3IKdGhlc2UgZGV2aWNlcywgcmVnZXg6aW5nIGZvciAnLScgc2VwYXJhdG9ycy4gSWYgeW91IGFk
ZCBhbiBhZGRpdGlvbmFsCictJyBzZXBhcmF0b3IgdGhlcmUgaXMgYSBjaGFuY2UgdGhhdCB0aGVz
ZSBhcHBsaWNhdGlvbnMgd2lsbCBnZXQKY29uZnVzZWQgYW5kIGJyZWFrIHdpdGhvdXQgd2Fybmlu
Zy4gCgotLSAKTGVlIEpvbmVzCkxpbmFybyBTVE1pY3JvZWxlY3Ryb25pY3MgTGFuZGluZyBUZWFt
IExlYWQKTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFSTSBTb0NzCkZv
bGxvdyBMaW5hcm86IEZhY2Vib29rIHwgVHdpdHRlciB8IEJsb2cKCl9fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxtLXNlbnNvcnMgbWFpbGluZyBsaXN0Cmxt
LXNlbnNvcnNAbG0tc2Vuc29ycy5vcmcKaHR0cDovL2xpc3RzLmxtLXNlbnNvcnMub3JnL21haWxt
YW4vbGlzdGluZm8vbG0tc2Vuc29ycw=
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Laszlo Papp <lpapp@kde.org>
Cc: Jean Delvare <jdelvare@suse.de>,
LKML <linux-kernel@vger.kernel.org>,
lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [PATCH] hwmon: (max6650) Rename the device ids to contain the hwmon suffix
Date: Tue, 11 Feb 2014 09:47:26 +0000 [thread overview]
Message-ID: <20140211094726.GH32042@lee--X1> (raw)
In-Reply-To: <CAOMwXhPfmXDKcov_+HHDTCaieGDiMEi+6CV_OnYDM3c8+S+bfA@mail.gmail.com>
> >> >> On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare <jdelvare@suse.de> wrote:
> >> >> > Additionally, dashes are explicitly forbidden in hwmon
> >> >> > device names.
> >> >>
> >> >> Also, where is that documented?
> >> >
> >> > In Documentation/hwmon/sysfs-interface:
> >> >
> >> > *********************
> >> > * Global attributes *
> >> > *********************
> >> >
> >> > name The chip name.
> >> > This should be a short, lowercase string, not containing
> >> > spaces nor dashes, representing the chip name. This is
> >> > the only mandatory attribute.
> >> > I2C devices get this attribute created automatically.
> >> > RO
> >>
> >> Time to revisit this decision....
> >>
> >> So, based on the fact that children device names usually contain
> >> dashes, I do not understand why hwmon would be any special in this
> >> regard. It is possible that the hwmon developers have not faced much
> >> MFD situation before, and so, this was not considered to be handled
> >> like in other subsystems.
> >>
> >> I am proposing to change this "rule"... Any objection?
> >
> > Prior to proposing such an invasive change which is highly likely to
> > come up against heavy opposition,
>
> It is possible that someone does not understand why you think it may
> be invasive, right? Could you please explain the reason for that?
The reason is a good one. In the kernel we make every attempt not to
break userspace. By that I mean _any_ userspace application. Userspace
applications which interface with the kernel can do so via a variety of
methods. One of those is Sysfs, where this name you are attempting to
change appears. The userspace applications already mentioned parse for
these devices, regex:ing for '-' separators. If you add an additional
'-' separator there is a chance that these applications will get
confused and break without warning.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-02-11 9:47 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 15:25 [lm-sensors] [PATCH] hwmon: (max6650) Rename the device ids to contain the hwmon suffix Laszlo Papp
2014-02-10 15:25 ` Laszlo Papp
2014-02-10 16:08 ` [lm-sensors] " Lee Jones
2014-02-10 16:08 ` Lee Jones
2014-02-10 16:38 ` [lm-sensors] " Jean Delvare
2014-02-10 16:38 ` Jean Delvare
2014-02-10 16:53 ` linux
2014-02-10 16:53 ` linux
2014-02-10 18:59 ` Laszlo Papp
2014-02-10 18:59 ` Laszlo Papp
2014-02-10 23:10 ` Guenter Roeck
2014-02-10 23:10 ` Guenter Roeck
2014-02-11 3:23 ` Laszlo Papp
2014-02-11 3:23 ` Laszlo Papp
2014-02-11 3:35 ` Laszlo Papp
2014-02-11 3:35 ` Laszlo Papp
2014-02-10 16:58 ` Lee Jones
2014-02-10 16:58 ` Lee Jones
2014-02-10 17:43 ` Jean Delvare
2014-02-10 17:43 ` Jean Delvare
2014-02-10 18:01 ` [lm-sensors] " Lee Jones
2014-02-10 18:01 ` Lee Jones
2014-02-10 18:15 ` [lm-sensors] " Jean Delvare
2014-02-10 18:15 ` Jean Delvare
2014-02-10 18:24 ` Lee Jones
2014-02-10 18:24 ` Lee Jones
2014-02-10 18:27 ` Laszlo Papp
2014-02-10 18:27 ` Laszlo Papp
2014-02-10 18:55 ` [lm-sensors] " Jean Delvare
2014-02-10 18:55 ` Jean Delvare
2014-02-10 17:06 ` Laszlo Papp
2014-02-10 17:06 ` Laszlo Papp
2014-02-10 17:09 ` Laszlo Papp
2014-02-10 17:09 ` Laszlo Papp
2014-02-11 3:13 ` Laszlo Papp
2014-02-11 3:13 ` Laszlo Papp
2014-02-11 7:50 ` Jean Delvare
2014-02-11 7:50 ` Jean Delvare
2014-02-11 8:19 ` Laszlo Papp
2014-02-11 8:19 ` Laszlo Papp
2014-02-11 8:28 ` Laszlo Papp
2014-02-11 8:28 ` Laszlo Papp
2014-02-11 8:49 ` Jean Delvare
2014-02-11 8:49 ` Jean Delvare
2014-02-11 9:08 ` Laszlo Papp
2014-02-11 9:08 ` Laszlo Papp
2014-02-11 9:57 ` Lee Jones
2014-02-11 9:57 ` Lee Jones
2014-02-11 15:15 ` Laszlo Papp
2014-02-11 15:15 ` Laszlo Papp
2014-02-11 8:50 ` Lee Jones
2014-02-11 8:50 ` Lee Jones
2014-02-11 8:58 ` Laszlo Papp
2014-02-11 8:58 ` Laszlo Papp
2014-02-11 9:14 ` Laszlo Papp
2014-02-11 9:14 ` Laszlo Papp
2014-02-11 9:47 ` Lee Jones [this message]
2014-02-11 9:47 ` Lee Jones
2014-02-11 9:50 ` Laszlo Papp
2014-02-11 9:50 ` Laszlo Papp
2014-02-11 10:22 ` Laszlo Papp
2014-02-11 10:22 ` Laszlo Papp
2014-02-11 11:09 ` Laszlo Papp
2014-02-11 11:09 ` Laszlo Papp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140211094726.GH32042@lee--X1 \
--to=lee.jones@linaro.org \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=lpapp@kde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.