From: Stephen Boyd <sboyd@codeaurora.org>
To: Kumar Gala <galak@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org
Subject: Re: [PATCH v3 2/5] clocksource: qcom: Move clocksource code out of mach-msm
Date: Mon, 10 Feb 2014 21:38:42 -0800 [thread overview]
Message-ID: <20140211053842.GE10784@codeaurora.org> (raw)
In-Reply-To: <1391725484-6673-3-git-send-email-galak@codeaurora.org>
On 02/06, Kumar Gala wrote:
> diff --git a/arch/arm/mach-msm/timer.c b/drivers/clocksource/qcom-timer.c
> similarity index 98%
> rename from arch/arm/mach-msm/timer.c
> rename to drivers/clocksource/qcom-timer.c
> index fd16449..dca829e 100644
> --- a/arch/arm/mach-msm/timer.c
> +++ b/drivers/clocksource/qcom-timer.c
> @@ -1,7 +1,7 @@
> /*
> *
> * Copyright (C) 2007 Google, Inc.
> - * Copyright (c) 2009-2012, The Linux Foundation. All rights reserved.
> + * Copyright (c) 2009-2012,2014, The Linux Foundation. All rights reserved.
> *
> * This software is licensed under the terms of the GNU General Public
> * License version 2, as published by the Free Software Foundation, and
> @@ -26,10 +26,6 @@
> #include <linux/of_irq.h>
> #include <linux/sched_clock.h>
>
> -#include <asm/mach/time.h>
> -
> -#include "common.h"
> -
This will cause sparse warnings because we no longer have the header included.
CHECK drivers/clocksource/qcom-timer.c
drivers/clocksource/qcom-timer.c:304:13: warning: symbol 'msm7x01_timer_init' was not declared. Should it be static?
drivers/clocksource/qcom-timer.c:317:13: warning: symbol 'msm7x30_timer_init' was not declared. Should it be static?
drivers/clocksource/qcom-timer.c:324:13: warning: symbol 'qsd8x50_timer_init' was not declared. Should it be static?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/5] clocksource: qcom: Move clocksource code out of mach-msm
Date: Mon, 10 Feb 2014 21:38:42 -0800 [thread overview]
Message-ID: <20140211053842.GE10784@codeaurora.org> (raw)
In-Reply-To: <1391725484-6673-3-git-send-email-galak@codeaurora.org>
On 02/06, Kumar Gala wrote:
> diff --git a/arch/arm/mach-msm/timer.c b/drivers/clocksource/qcom-timer.c
> similarity index 98%
> rename from arch/arm/mach-msm/timer.c
> rename to drivers/clocksource/qcom-timer.c
> index fd16449..dca829e 100644
> --- a/arch/arm/mach-msm/timer.c
> +++ b/drivers/clocksource/qcom-timer.c
> @@ -1,7 +1,7 @@
> /*
> *
> * Copyright (C) 2007 Google, Inc.
> - * Copyright (c) 2009-2012, The Linux Foundation. All rights reserved.
> + * Copyright (c) 2009-2012,2014, The Linux Foundation. All rights reserved.
> *
> * This software is licensed under the terms of the GNU General Public
> * License version 2, as published by the Free Software Foundation, and
> @@ -26,10 +26,6 @@
> #include <linux/of_irq.h>
> #include <linux/sched_clock.h>
>
> -#include <asm/mach/time.h>
> -
> -#include "common.h"
> -
This will cause sparse warnings because we no longer have the header included.
CHECK drivers/clocksource/qcom-timer.c
drivers/clocksource/qcom-timer.c:304:13: warning: symbol 'msm7x01_timer_init' was not declared. Should it be static?
drivers/clocksource/qcom-timer.c:317:13: warning: symbol 'msm7x30_timer_init' was not declared. Should it be static?
drivers/clocksource/qcom-timer.c:324:13: warning: symbol 'qsd8x50_timer_init' was not declared. Should it be static?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-02-11 5:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 22:24 [PATCH v3 0/5] Split mach-msm into legacy and mach-qcom (multiplatform) Kumar Gala
2014-02-06 22:24 ` Kumar Gala
2014-02-06 22:24 ` [PATCH v3 1/5] ARM: msm: kill off hotplug.c Kumar Gala
2014-02-06 22:24 ` Kumar Gala
2014-02-06 22:24 ` [PATCH v3 2/5] clocksource: qcom: Move clocksource code out of mach-msm Kumar Gala
2014-02-06 22:24 ` Kumar Gala
2014-02-11 5:38 ` Stephen Boyd [this message]
2014-02-11 5:38 ` Stephen Boyd
2014-02-06 22:24 ` [PATCH v3 3/5] ARM: qcom: Split Qualcomm support into legacy and multiplatform Kumar Gala
2014-02-06 22:24 ` Kumar Gala
2014-02-08 3:26 ` Stephen Boyd
2014-02-08 3:26 ` Stephen Boyd
2014-02-11 15:13 ` Kumar Gala
2014-02-11 15:13 ` Kumar Gala
2014-02-11 18:10 ` Bryan Huntsman
2014-02-11 18:10 ` Bryan Huntsman
2014-02-06 22:24 ` [PATCH v3 4/5] clocksource: qcom: split building of legacy vs multiplatform support Kumar Gala
2014-02-06 22:24 ` Kumar Gala
2014-02-06 22:24 ` [PATCH v3 5/5] ARM: qcom: Rename various msm prefixed functions to qcom Kumar Gala
2014-02-06 22:24 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140211053842.GE10784@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=daniel.lezcano@linaro.org \
--cc=galak@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.