* [PATCH] watchdog: ts72xx_wdt: make 'ts72xx_wdt_pdev' static
@ 2014-02-11 6:59 Jingoo Han
2014-02-11 10:09 ` 'Mika Westerberg'
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jingoo Han @ 2014-02-11 6:59 UTC (permalink / raw)
To: 'Wim Van Sebroeck'
Cc: linux-watchdog, 'Guenter Roeck', 'Jingoo Han',
'Mika Westerberg'
Make 'ts72xx_wdt_pdev' static, because it is used only in this
file. It also fixes the following sparse warning.
warning: symbol 'ts72xx_wdt_pdev' was not declared. Should it be static?
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/watchdog/ts72xx_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/ts72xx_wdt.c b/drivers/watchdog/ts72xx_wdt.c
index 6959fa0..afa9d6e 100644
--- a/drivers/watchdog/ts72xx_wdt.c
+++ b/drivers/watchdog/ts72xx_wdt.c
@@ -61,7 +61,7 @@ struct ts72xx_wdt {
struct platform_device *pdev;
};
-struct platform_device *ts72xx_wdt_pdev;
+static struct platform_device *ts72xx_wdt_pdev;
/*
* TS-72xx Watchdog supports following timeouts (value written
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] watchdog: ts72xx_wdt: make 'ts72xx_wdt_pdev' static
2014-02-11 6:59 [PATCH] watchdog: ts72xx_wdt: make 'ts72xx_wdt_pdev' static Jingoo Han
@ 2014-02-11 10:09 ` 'Mika Westerberg'
2014-02-11 20:21 ` Guenter Roeck
2014-02-24 19:54 ` Wim Van Sebroeck
2 siblings, 0 replies; 4+ messages in thread
From: 'Mika Westerberg' @ 2014-02-11 10:09 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Wim Van Sebroeck', linux-watchdog,
'Guenter Roeck'
On Tue, Feb 11, 2014 at 03:59:38PM +0900, Jingoo Han wrote:
> Make 'ts72xx_wdt_pdev' static, because it is used only in this
> file. It also fixes the following sparse warning.
>
> warning: symbol 'ts72xx_wdt_pdev' was not declared. Should it be static?
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] watchdog: ts72xx_wdt: make 'ts72xx_wdt_pdev' static
2014-02-11 6:59 [PATCH] watchdog: ts72xx_wdt: make 'ts72xx_wdt_pdev' static Jingoo Han
2014-02-11 10:09 ` 'Mika Westerberg'
@ 2014-02-11 20:21 ` Guenter Roeck
2014-02-24 19:54 ` Wim Van Sebroeck
2 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2014-02-11 20:21 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Wim Van Sebroeck', linux-watchdog,
'Mika Westerberg'
On Tue, Feb 11, 2014 at 03:59:38PM +0900, Jingoo Han wrote:
> Make 'ts72xx_wdt_pdev' static, because it is used only in this
> file. It also fixes the following sparse warning.
>
> warning: symbol 'ts72xx_wdt_pdev' was not declared. Should it be static?
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] watchdog: ts72xx_wdt: make 'ts72xx_wdt_pdev' static
2014-02-11 6:59 [PATCH] watchdog: ts72xx_wdt: make 'ts72xx_wdt_pdev' static Jingoo Han
2014-02-11 10:09 ` 'Mika Westerberg'
2014-02-11 20:21 ` Guenter Roeck
@ 2014-02-24 19:54 ` Wim Van Sebroeck
2 siblings, 0 replies; 4+ messages in thread
From: Wim Van Sebroeck @ 2014-02-24 19:54 UTC (permalink / raw)
To: Jingoo Han
Cc: linux-watchdog, 'Guenter Roeck',
'Mika Westerberg'
Hi Jingoo,
> Make 'ts72xx_wdt_pdev' static, because it is used only in this
> file. It also fixes the following sparse warning.
>
> warning: symbol 'ts72xx_wdt_pdev' was not declared. Should it be static?
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/watchdog/ts72xx_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/ts72xx_wdt.c b/drivers/watchdog/ts72xx_wdt.c
> index 6959fa0..afa9d6e 100644
> --- a/drivers/watchdog/ts72xx_wdt.c
> +++ b/drivers/watchdog/ts72xx_wdt.c
> @@ -61,7 +61,7 @@ struct ts72xx_wdt {
> struct platform_device *pdev;
> };
>
> -struct platform_device *ts72xx_wdt_pdev;
> +static struct platform_device *ts72xx_wdt_pdev;
>
> /*
> * TS-72xx Watchdog supports following timeouts (value written
> --
> 1.7.10.4
>
>
This patch has been added to linux-watchdog-next.
Kind regards,
Wim.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-02-24 19:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-11 6:59 [PATCH] watchdog: ts72xx_wdt: make 'ts72xx_wdt_pdev' static Jingoo Han
2014-02-11 10:09 ` 'Mika Westerberg'
2014-02-11 20:21 ` Guenter Roeck
2014-02-24 19:54 ` Wim Van Sebroeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.