* [PATCH 1/2] staging: android: binder: use whitespace consistently
@ 2014-02-08 2:59 SeongJae Park
2014-02-08 2:59 ` [PATCH 2/2] staging: android: remove unused constant, BINDER_SET_IDLE_PRIORITY SeongJae Park
0 siblings, 1 reply; 4+ messages in thread
From: SeongJae Park @ 2014-02-08 2:59 UTC (permalink / raw)
To: gregkh; +Cc: arve, swetland, devel, linux-kernel, SeongJae Park
Whitespace between #define keyword and BINDER_* constants are space in
some point and tab in some point. Using space or tab is just writer's
choice. But, let's use them more consistently.
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
drivers/staging/android/binder.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/android/binder.h b/drivers/staging/android/binder.h
index cbe34516..c4c1ed6 100644
--- a/drivers/staging/android/binder.h
+++ b/drivers/staging/android/binder.h
@@ -85,11 +85,11 @@ struct binder_version {
#define BINDER_CURRENT_PROTOCOL_VERSION 7
#define BINDER_WRITE_READ _IOWR('b', 1, struct binder_write_read)
-#define BINDER_SET_IDLE_TIMEOUT _IOW('b', 3, __s64)
-#define BINDER_SET_MAX_THREADS _IOW('b', 5, __u32)
-#define BINDER_SET_IDLE_PRIORITY _IOW('b', 6, __s32)
-#define BINDER_SET_CONTEXT_MGR _IOW('b', 7, __s32)
-#define BINDER_THREAD_EXIT _IOW('b', 8, __s32)
+#define BINDER_SET_IDLE_TIMEOUT _IOW('b', 3, __s64)
+#define BINDER_SET_MAX_THREADS _IOW('b', 5, __u32)
+#define BINDER_SET_IDLE_PRIORITY _IOW('b', 6, __s32)
+#define BINDER_SET_CONTEXT_MGR _IOW('b', 7, __s32)
+#define BINDER_THREAD_EXIT _IOW('b', 8, __s32)
#define BINDER_VERSION _IOWR('b', 9, struct binder_version)
/*
--
1.8.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] staging: android: remove unused constant, BINDER_SET_IDLE_PRIORITY
2014-02-08 2:59 [PATCH 1/2] staging: android: binder: use whitespace consistently SeongJae Park
@ 2014-02-08 2:59 ` SeongJae Park
2014-02-11 20:22 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: SeongJae Park @ 2014-02-08 2:59 UTC (permalink / raw)
To: gregkh; +Cc: arve, swetland, devel, linux-kernel, SeongJae Park
Remove constant BINDER_SET_IDLE_PRIORITY because it is not used from
anywhere.
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
drivers/staging/android/binder.h | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/android/binder.h b/drivers/staging/android/binder.h
index c4c1ed6..6d08e61 100644
--- a/drivers/staging/android/binder.h
+++ b/drivers/staging/android/binder.h
@@ -87,10 +87,9 @@ struct binder_version {
#define BINDER_WRITE_READ _IOWR('b', 1, struct binder_write_read)
#define BINDER_SET_IDLE_TIMEOUT _IOW('b', 3, __s64)
#define BINDER_SET_MAX_THREADS _IOW('b', 5, __u32)
-#define BINDER_SET_IDLE_PRIORITY _IOW('b', 6, __s32)
-#define BINDER_SET_CONTEXT_MGR _IOW('b', 7, __s32)
-#define BINDER_THREAD_EXIT _IOW('b', 8, __s32)
-#define BINDER_VERSION _IOWR('b', 9, struct binder_version)
+#define BINDER_SET_CONTEXT_MGR _IOW('b', 6, __s32)
+#define BINDER_THREAD_EXIT _IOW('b', 7, __s32)
+#define BINDER_VERSION _IOWR('b', 8, struct binder_version)
/*
* NOTE: Two special error codes you should check for when calling
--
1.8.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] staging: android: remove unused constant, BINDER_SET_IDLE_PRIORITY
2014-02-08 2:59 ` [PATCH 2/2] staging: android: remove unused constant, BINDER_SET_IDLE_PRIORITY SeongJae Park
@ 2014-02-11 20:22 ` Greg KH
2014-02-12 3:16 ` SeongJae Park
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2014-02-11 20:22 UTC (permalink / raw)
To: SeongJae Park; +Cc: devel, swetland, arve, linux-kernel
On Sat, Feb 08, 2014 at 11:59:41AM +0900, SeongJae Park wrote:
> Remove constant BINDER_SET_IDLE_PRIORITY because it is not used from
> anywhere.
>
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
> ---
> drivers/staging/android/binder.h | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/android/binder.h b/drivers/staging/android/binder.h
> index c4c1ed6..6d08e61 100644
> --- a/drivers/staging/android/binder.h
> +++ b/drivers/staging/android/binder.h
> @@ -87,10 +87,9 @@ struct binder_version {
> #define BINDER_WRITE_READ _IOWR('b', 1, struct binder_write_read)
> #define BINDER_SET_IDLE_TIMEOUT _IOW('b', 3, __s64)
> #define BINDER_SET_MAX_THREADS _IOW('b', 5, __u32)
> -#define BINDER_SET_IDLE_PRIORITY _IOW('b', 6, __s32)
> -#define BINDER_SET_CONTEXT_MGR _IOW('b', 7, __s32)
> -#define BINDER_THREAD_EXIT _IOW('b', 8, __s32)
> -#define BINDER_VERSION _IOWR('b', 9, struct binder_version)
> +#define BINDER_SET_CONTEXT_MGR _IOW('b', 6, __s32)
> +#define BINDER_THREAD_EXIT _IOW('b', 7, __s32)
> +#define BINDER_VERSION _IOWR('b', 8, struct binder_version)
And you just broke all userspace code that uses this interface :(
Please be more careful, and test your patches properly.
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] staging: android: remove unused constant, BINDER_SET_IDLE_PRIORITY
2014-02-11 20:22 ` Greg KH
@ 2014-02-12 3:16 ` SeongJae Park
0 siblings, 0 replies; 4+ messages in thread
From: SeongJae Park @ 2014-02-12 3:16 UTC (permalink / raw)
To: Greg KH; +Cc: devel, Brian Swetland, arve, linux-kernel@vger.kernel.org
On Wed, Feb 12, 2014 at 5:22 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Sat, Feb 08, 2014 at 11:59:41AM +0900, SeongJae Park wrote:
>> Remove constant BINDER_SET_IDLE_PRIORITY because it is not used from
>> anywhere.
>
>>
>> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
>> ---
>> drivers/staging/android/binder.h | 7 +++----
>> 1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/staging/android/binder.h b/drivers/staging/android/binder.h
>> index c4c1ed6..6d08e61 100644
>> --- a/drivers/staging/android/binder.h
>> +++ b/drivers/staging/android/binder.h
>> @@ -87,10 +87,9 @@ struct binder_version {
>> #define BINDER_WRITE_READ _IOWR('b', 1, struct binder_write_read)
>> #define BINDER_SET_IDLE_TIMEOUT _IOW('b', 3, __s64)
>> #define BINDER_SET_MAX_THREADS _IOW('b', 5, __u32)
>> -#define BINDER_SET_IDLE_PRIORITY _IOW('b', 6, __s32)
>> -#define BINDER_SET_CONTEXT_MGR _IOW('b', 7, __s32)
>> -#define BINDER_THREAD_EXIT _IOW('b', 8, __s32)
>> -#define BINDER_VERSION _IOWR('b', 9, struct binder_version)
>> +#define BINDER_SET_CONTEXT_MGR _IOW('b', 6, __s32)
>> +#define BINDER_THREAD_EXIT _IOW('b', 7, __s32)
>> +#define BINDER_VERSION _IOWR('b', 8, struct binder_version)
>
> And you just broke all userspace code that uses this interface :(
>
> Please be more careful, and test your patches properly.
Definitely my fault... Sorry.
I will be more careful and will not do such mistake again.
>
> greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-02-12 3:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-08 2:59 [PATCH 1/2] staging: android: binder: use whitespace consistently SeongJae Park
2014-02-08 2:59 ` [PATCH 2/2] staging: android: remove unused constant, BINDER_SET_IDLE_PRIORITY SeongJae Park
2014-02-11 20:22 ` Greg KH
2014-02-12 3:16 ` SeongJae Park
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.