All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	intel-gfx@lists.freedesktop.org,
	Enrico Tagliavini <enrico.tagliavini@gmail.com>,
	Bjoern C <lkml@call-home.ch>,
	Alexandru DAMIAN <alexandru.damian@intel.com>
Subject: Re: [PATCH v3 2/2] drm/i915: Prevent MI_DISPLAY_FLIP straddling two cachelines on IVB
Date: Tue, 11 Feb 2014 22:34:48 +0200	[thread overview]
Message-ID: <20140211203448.GX3891@intel.com> (raw)
In-Reply-To: <20140211201854.GF11275@nuc-i3427.alporthouse.com>

On Tue, Feb 11, 2014 at 08:19:13PM +0000, Chris Wilson wrote:
> On Tue, Feb 11, 2014 at 07:52:06PM +0200, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > According to BSpec the entire MI_DISPLAY_FLIP packet must be contained
> > in a single cacheline. Make sure that happens.
> > 
> > v2: Use intel_ring_begin_cacheline_safe()
> > v3: Use intel_ring_cacheline_align() (Chris)
> > 
> > Cc: Bjoern C <lkml@call-home.ch>
> > Cc: Alexandru DAMIAN <alexandru.damian@intel.com>
> > Cc: Enrico Tagliavini <enrico.tagliavini@gmail.com>
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=74053
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> I would have used intel_ring_align_cacheline() as it seems more natural
> for me to say...

I had it as intel_ring_align_to_cacheline(), but then changed it when I
saw Daniel's suggestion for the name. So you can blame Daniel for this ;)
But I have no emotional attachment to the chosen name. So if you prefer
we rename it, I'm fine with that.

-- 
Ville Syrjälä
Intel OTC

  reply	other threads:[~2014-02-11 20:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-11 17:52 [PATCH 0/2] drm/i915: IVB MI_DISPLAY_FLIP cacheline trick v2 ville.syrjala
2014-02-11 17:52 ` [PATCH 1/2] drm/i915: Add intel_ring_cachline_align() ville.syrjala
2014-02-11 17:52 ` [PATCH v3 2/2] drm/i915: Prevent MI_DISPLAY_FLIP straddling two cachelines on IVB ville.syrjala
2014-02-11 20:19   ` Chris Wilson
2014-02-11 20:34     ` Ville Syrjälä [this message]
2014-02-11 22:01     ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140211203448.GX3891@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=alexandru.damian@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=enrico.tagliavini@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lkml@call-home.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.