From: Bjorn Helgaas <bhelgaas@google.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Marta Rybczynska <rybczynska@gmail.com>,
linux-pci@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] PCI hotplug: cpqphp: hex vs decimal typo in cpqhpc_probe()
Date: Tue, 11 Feb 2014 23:23:06 +0000 [thread overview]
Message-ID: <20140211232306.GB21057@google.com> (raw)
In-Reply-To: <20140210152350.GA24189@elgon.mountain>
On Mon, Feb 10, 2014 at 06:23:50PM +0300, Dan Carpenter wrote:
> This is a static checker fix and I can't test it, but from the context
> it definitely looks like hexidecimal 0x20 was intended here instead of
> decimal 20.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied to pci/misc for v3.15, thanks a lot!
Bjorn
> diff --git a/drivers/pci/hotplug/cpqphp_core.c b/drivers/pci/hotplug/cpqphp_core.c
> index 31273e155e6c..037e2612c5bd 100644
> --- a/drivers/pci/hotplug/cpqphp_core.c
> +++ b/drivers/pci/hotplug/cpqphp_core.c
> @@ -920,12 +920,12 @@ static int cpqhpc_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> bus->max_bus_speed = PCI_SPEED_100MHz_PCIX;
> break;
> }
> - if (bus_cap & 20) {
> + if (bus_cap & 0x20) {
> dbg("bus max supports 66MHz PCI-X\n");
> bus->max_bus_speed = PCI_SPEED_66MHz_PCIX;
> break;
> }
> - if (bus_cap & 10) {
> + if (bus_cap & 0x10) {
> dbg("bus max supports 66MHz PCI\n");
> bus->max_bus_speed = PCI_SPEED_66MHz;
> break;
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <bhelgaas@google.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Marta Rybczynska <rybczynska@gmail.com>,
linux-pci@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] PCI hotplug: cpqphp: hex vs decimal typo in cpqhpc_probe()
Date: Tue, 11 Feb 2014 16:23:06 -0700 [thread overview]
Message-ID: <20140211232306.GB21057@google.com> (raw)
In-Reply-To: <20140210152350.GA24189@elgon.mountain>
On Mon, Feb 10, 2014 at 06:23:50PM +0300, Dan Carpenter wrote:
> This is a static checker fix and I can't test it, but from the context
> it definitely looks like hexidecimal 0x20 was intended here instead of
> decimal 20.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied to pci/misc for v3.15, thanks a lot!
Bjorn
> diff --git a/drivers/pci/hotplug/cpqphp_core.c b/drivers/pci/hotplug/cpqphp_core.c
> index 31273e155e6c..037e2612c5bd 100644
> --- a/drivers/pci/hotplug/cpqphp_core.c
> +++ b/drivers/pci/hotplug/cpqphp_core.c
> @@ -920,12 +920,12 @@ static int cpqhpc_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> bus->max_bus_speed = PCI_SPEED_100MHz_PCIX;
> break;
> }
> - if (bus_cap & 20) {
> + if (bus_cap & 0x20) {
> dbg("bus max supports 66MHz PCI-X\n");
> bus->max_bus_speed = PCI_SPEED_66MHz_PCIX;
> break;
> }
> - if (bus_cap & 10) {
> + if (bus_cap & 0x10) {
> dbg("bus max supports 66MHz PCI\n");
> bus->max_bus_speed = PCI_SPEED_66MHz;
> break;
next prev parent reply other threads:[~2014-02-11 23:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 15:23 [patch] PCI hotplug: cpqphp: hex vs decimal typo in cpqhpc_probe() Dan Carpenter
2014-02-10 15:23 ` Dan Carpenter
2014-02-11 23:23 ` Bjorn Helgaas [this message]
2014-02-11 23:23 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140211232306.GB21057@google.com \
--to=bhelgaas@google.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rybczynska@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.