From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Emmanuel Grumbach <egrumbach@gmail.com>
Cc: linux-wireless@vger.kernel.org,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Subject: Re: [PATCH] iwlwifi: disable TX AMPDU by default for iwldvm
Date: Wed, 12 Feb 2014 10:21:51 +0100 [thread overview]
Message-ID: <20140212092150.GC1315@redhat.com> (raw)
In-Reply-To: <20140212091008.GB1315@redhat.com>
On Wed, Feb 12, 2014 at 10:10:08AM +0100, Stanislaw Gruszka wrote:
> On Wed, Feb 12, 2014 at 10:54:29AM +0200, Emmanuel Grumbach wrote:
> > From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> >
> > We have had a bug in TX AMPDU in iwldvm for a very long
> > time. This bug has been raised in many bugzillas and threads
> > on linux-wireless mailing list.
> >
> > The bug is in firmware and we won't be able to fix it in the
> > near future. Hence, we prefer to disable TX AMPDU by default
> > in iwldvm. This doesn't affect iwlmvm which supports 7160 /
> > 3160 and up.
>
> ...
>
> > #define IWL_DISABLE_HT_ALL BIT(0)
> > -#define IWL_DISABLE_HT_TXAGG BIT(1)
>
> Whouln't simple change, by setting disable_11=2 by default, make
> the same effect, and allow easly to enable TX aggregation (without
> kernel recompile) ?
Also, does the bug affect all iwldvm devices ? They have different
firmware images, so I wonder if this is needed for all DVM devices.
Stanislaw
next prev parent reply other threads:[~2014-02-12 9:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 8:51 pull request: iwlwifi 2013-02-12 Emmanuel Grumbach
2014-02-12 8:54 ` [PATCH] iwlwifi: disable TX AMPDU by default for iwldvm Emmanuel Grumbach
2014-02-12 9:10 ` Stanislaw Gruszka
2014-02-12 9:21 ` Stanislaw Gruszka [this message]
2014-02-12 9:35 ` Grumbach, Emmanuel
2014-02-12 9:43 ` Sujith Manoharan
2014-02-12 9:45 ` Grumbach, Emmanuel
2014-02-12 9:53 ` Sujith Manoharan
2014-02-12 10:41 ` Stanislaw Gruszka
2014-02-12 9:08 ` pull request: iwlwifi 2014-02-12 (FIXED) Emmanuel Grumbach
2014-02-12 9:09 ` [PATCH] iwlwifi: disable TX AMPDU by default for iwldvm Emmanuel Grumbach
2014-02-12 11:19 ` [RFC] iwlwifi: refactor the TX / RX ampdu override Emmanuel Grumbach
2014-02-12 12:13 ` Stanislaw Gruszka
2014-02-12 12:27 ` Grumbach, Emmanuel
2014-02-12 14:04 ` Stanislaw Gruszka
2014-02-12 20:28 ` Emmanuel Grumbach
2014-02-13 7:54 ` Stanislaw Gruszka
2014-02-13 12:28 ` [PATCH] iwlwifi: disable TX AMPDU by default for iwldvm Emmanuel Grumbach
2014-02-12 11:02 ` pull request: iwlwifi 2014-02-12 (FIXED) Emmanuel Grumbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140212092150.GC1315@redhat.com \
--to=sgruszka@redhat.com \
--cc=egrumbach@gmail.com \
--cc=emmanuel.grumbach@intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.