Re: [RFC] iwlwifi: refactor the TX / RX ampdu override

[Stanislaw Gruszka <sgruszka@redhat.com>]

On Wed, Feb 12, 2014 at 10:28:00PM +0200, Emmanuel Grumbach wrote:
> On 02/12/2014 04:04 PM, Stanislaw Gruszka wrote:
> > On Wed, Feb 12, 2014 at 12:27:05PM +0000, Grumbach, Emmanuel wrote:
> >>> I think we can keep IWL_DISABLE_HT_ALL option. I should be possible to
> >>> make some per-device type default settings and if disable_11n == 0 use
> >>> them. Otherwise use settings from module parameter. Will that work ?
> >>
> >> I'd prefer to have the default based on the iwldvm vs. iwlmvm instead of adding yet another per-HW field. But yeah - it is possible.
> > 
> > I re-think changing default settings do disable TX AGG and must tell
> > that this is very odd. I would prefer to stay defaults as they are now.
> > Users can disable TX aggregation using module option.
> 
> I disagree. We have bugs there - it is pretty much obvious. I remember a
> tracing from 2.6.39 which was before the re-architecture I made in the
> driver with clear FW bugs. I don't remember what device though.
> This is why I want to disable this by default.

Sure, it's up to you. But anyway, disabling feature because it buggy,
after having it run for 5 years or so, it's odd :-) 

Stanislaw