From: Borislav Petkov <bp@alien8.de>
To: Tejun Heo <tj@kernel.org>
Cc: Prarit Bhargava <prarit@redhat.com>,
linux-edac@vger.kernel.org,
Doug Thompson <dougthompson@xmission.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] edac, poll timeout cannot be zero
Date: Wed, 12 Feb 2014 17:36:44 +0100 [thread overview]
Message-ID: <20140212163644.GG5121@pd.tnic> (raw)
In-Reply-To: <20140212162311.GB26809@htj.dyndns.org>
On Wed, Feb 12, 2014 at 11:23:11AM -0500, Tejun Heo wrote:
> Hah... can't you just do it on object initialization? It's a bit
> nasty and fragile to game initialization state.
>
> > or so... I.e., what PREPARE_WORK() does?
>
> It allows you to change the callback without breaking the
> synchronization. Of course, if there's a pending work item, it may or
> may not execute the newly assigned function. It's also a bit nasty
> and has only few users in the whole kernel and I think we might wanna
> get rid of them.
Yeah, no, I certainly don't have to touch wq inner organs - I was
wondering whether there's such functionality already. The simple patch I
sent earlier should be good enough then.
Thanks!
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2014-02-12 16:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-03 20:05 [PATCH] edac, poll timeout cannot be zero Prarit Bhargava
2014-02-12 15:07 ` Borislav Petkov
2014-02-12 15:16 ` Tejun Heo
2014-02-12 15:57 ` Borislav Petkov
2014-02-12 16:23 ` Tejun Heo
2014-02-12 16:36 ` Borislav Petkov [this message]
2014-02-12 17:22 ` [PATCH] EDAC: Correct workqueue setup path Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140212163644.GG5121@pd.tnic \
--to=bp@alien8.de \
--cc=dougthompson@xmission.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prarit@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.