* [patch] ext4: remove an unneeded check in mext_page_mkuptodate()
@ 2014-02-06 12:45 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2014-02-06 12:45 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: Andreas Dilger, linux-ext4, kernel-janitors
"err" is zero here, there is no need to check again.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c
index 773b503bd18c..f39a88abe32c 100644
--- a/fs/ext4/move_extent.c
+++ b/fs/ext4/move_extent.c
@@ -861,8 +861,7 @@ mext_page_mkuptodate(struct page *page, unsigned from, unsigned to)
}
if (!buffer_mapped(bh)) {
zero_user(page, block_start, blocksize);
- if (!err)
- set_buffer_uptodate(bh);
+ set_buffer_uptodate(bh);
continue;
}
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch] ext4: remove an unneeded check in mext_page_mkuptodate()
@ 2014-02-06 12:45 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2014-02-06 12:45 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: Andreas Dilger, linux-ext4, kernel-janitors
"err" is zero here, there is no need to check again.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c
index 773b503bd18c..f39a88abe32c 100644
--- a/fs/ext4/move_extent.c
+++ b/fs/ext4/move_extent.c
@@ -861,8 +861,7 @@ mext_page_mkuptodate(struct page *page, unsigned from, unsigned to)
}
if (!buffer_mapped(bh)) {
zero_user(page, block_start, blocksize);
- if (!err)
- set_buffer_uptodate(bh);
+ set_buffer_uptodate(bh);
continue;
}
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] ext4: remove an unneeded check in mext_page_mkuptodate()
2014-02-06 12:45 ` Dan Carpenter
@ 2014-02-12 17:25 ` Theodore Ts'o
-1 siblings, 0 replies; 4+ messages in thread
From: Theodore Ts'o @ 2014-02-12 17:25 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Andreas Dilger, linux-ext4, kernel-janitors
On Thu, Feb 06, 2014 at 03:45:50PM +0300, Dan Carpenter wrote:
> "err" is zero here, there is no need to check again.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] ext4: remove an unneeded check in mext_page_mkuptodate()
@ 2014-02-12 17:25 ` Theodore Ts'o
0 siblings, 0 replies; 4+ messages in thread
From: Theodore Ts'o @ 2014-02-12 17:25 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Andreas Dilger, linux-ext4, kernel-janitors
On Thu, Feb 06, 2014 at 03:45:50PM +0300, Dan Carpenter wrote:
> "err" is zero here, there is no need to check again.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-02-12 17:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-06 12:45 [patch] ext4: remove an unneeded check in mext_page_mkuptodate() Dan Carpenter
2014-02-06 12:45 ` Dan Carpenter
2014-02-12 17:25 ` Theodore Ts'o
2014-02-12 17:25 ` Theodore Ts'o
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.