From: Lee Jones <lee.jones@linaro.org>
To: Jean Delvare <jdelvare@suse.de>
Cc: Laszlo Papp <lpapp@kde.org>,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver
Date: Thu, 13 Feb 2014 11:16:07 +0000 [thread overview]
Message-ID: <20140213111607.GK32508@lee--X1> (raw)
In-Reply-To: <20140213111530.2a2b4982@endymion.delvare>
T24gVGh1LCAxMyBGZWIgMjAxNCwgSmVhbiBEZWx2YXJlIHdyb3RlOgoKPiBPbiBUaHUsIDEzIEZl
YiAyMDE0IDA5OjU4OjE3ICswMDAwLCBMZWUgSm9uZXMgd3JvdGU6Cj4gPiA+IFRoZSBNRkQgZHJp
dmVyIGhhcyBub3cgYmVlbiBhZGRlZCwgc28gdGhpcyBkcml2ZXIgaXMgbm93IGJlaW5nIGFkb3B0
ZWQgdG8gYmUgYQo+ID4gPiBzdWJkZXZpY2UgZHJpdmVyIG9uIHRvcCBvZiBpdC4gVGhpcyBtZWFu
cywgdGhlIGkyYyBkcml2ZXIgdXNhZ2UgaXMgYmVpbmcKPiA+ID4gY29udmVydGVkIHRvIHBsYXRm
b3JtIGRyaXZlciB1c2FnZSBhbGwgYXJvdW5kLgo+ID4gPiAKPiA+ID4gU2lnbmVkLW9mZi1ieTog
TGFzemxvIFBhcHAgPGxwYXBwQGtkZS5vcmc+Cj4gPiA+IC0tLQo+ID4gPiBUaGlzIHBhdGNoIGhh
cyBiZWVuIGNvbXBpbGUgdGVzdGVkIG9ubHkgYW5kIHdpbGwgYmUgdGVzdGVkIHdpdGggcmVhbCBo
YXJkd2FyZSwKPiA+ID4gYnV0IGVhcmx5IHJldmlld3MgdG8gY2F0Y2ggYW55IHRyaXZpYWwgaXNz
dWVzIHdvdWxkIGJlIHdlbGNvbWUuCj4gPiA+ICBkcml2ZXJzL2h3bW9uL0tjb25maWcgICB8ICAg
MiArLQo+ID4gPiAgZHJpdmVycy9od21vbi9tYXg2NjUwLmMgfCAxNTUgKysrKysrKysrKysrKysr
KysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gPiA+ICAyIGZpbGVzIGNoYW5nZWQs
IDc5IGluc2VydGlvbnMoKyksIDc4IGRlbGV0aW9ucygtKQo+ID4gCj4gPiA8c25pcD4KPiA+IAo+
ID4gPiAgLyoKPiA+ID4gICAqIEluc21vZCBwYXJhbWV0ZXJzCj4gPiA+IEBAIC0xMDUsMjQgKzEw
OCwyMyBAQCBtb2R1bGVfcGFyYW0oY2xvY2ssIGludCwgU19JUlVHTyk7Cj4gPiA+ICAKPiA+ID4g
ICNkZWZpbmUgRElWX0ZST01fUkVHKHJlZykgKDEgPDwgKHJlZyAmIDcpKQo+ID4gPiAgCj4gPiA+
IC1zdGF0aWMgaW50IG1heDY2NTBfcHJvYmUoc3RydWN0IGkyY19jbGllbnQgKmNsaWVudCwKPiA+
ID4gLQkJCSBjb25zdCBzdHJ1Y3QgaTJjX2RldmljZV9pZCAqaWQpOwo+ID4gPiAtc3RhdGljIGlu
dCBtYXg2NjUwX2luaXRfY2xpZW50KHN0cnVjdCBpMmNfY2xpZW50ICpjbGllbnQpOwo+ID4gPiAt
c3RhdGljIGludCBtYXg2NjUwX3JlbW92ZShzdHJ1Y3QgaTJjX2NsaWVudCAqY2xpZW50KTsKPiA+
ID4gK3N0YXRpYyBpbnQgbWF4NjY1MF9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2
KTsKPiA+ID4gK3N0YXRpYyBpbnQgbWF4NjY1MF9pbml0X2NsaWVudChzdHJ1Y3QgcGxhdGZvcm1f
ZGV2aWNlICpwZGV2KTsKPiA+ID4gK3N0YXRpYyBpbnQgbWF4NjY1MF9yZW1vdmUoc3RydWN0IHBs
YXRmb3JtX2RldmljZSAqcGRldik7Cj4gPiA+ICBzdGF0aWMgc3RydWN0IG1heDY2NTBfZGF0YSAq
bWF4NjY1MF91cGRhdGVfZGV2aWNlKHN0cnVjdCBkZXZpY2UgKmRldik7Cj4gPiAKPiA+IEl0IHdv
dWxkIGJlIGdvb2QgdG8gcmVtb3ZlIHRoZXNlIGZvcndhcmQgZGVjbGFyYXRpb25zIGluIHRoZSBm
dXR1cmUuCj4gPiAKPiA+IElmIG5vIG9uZSB2b2x1bnRlZXJzIEknbGwgaGFwcGlseSBkbyBpdC4K
PiAKPiBHdWVudGVyIGp1c3QgZGlkOgo+IAo+IGh0dHA6Ly9saXN0cy5sbS1zZW5zb3JzLm9yZy9w
aXBlcm1haWwvbG0tc2Vuc29ycy8yMDE0LUZlYnJ1YXJ5LzA0MTIyNC5odG1sCgpOaWNlLCBGV0lX
OgogIEFja2VkLWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPiAgCgo+IEFueSBj
aGFuZ2UgdG8gdGhlIG1heDY2NTAgZHJpdmVyIHNob3VsZCBnbyBvbiB0b3Agb2YgaGlzIHBhdGNo
IHNlcmllcwo+IHRvIGF2b2lkIGNvbmZsaWN0czoKPiAKPiBodHRwOi8vbGlzdHMubG0tc2Vuc29y
cy5vcmcvcGlwZXJtYWlsL2xtLXNlbnNvcnMvMjAxNC1GZWJydWFyeS8wNDEyMjMuaHRtbAoKRG8g
eW91IGhhdmUgYSB0cmVlIExhc3psbyBjYW4gcmViYXNlIG9uIHRvcCBvZj8KCi0tIApMZWUgSm9u
ZXMKTGluYXJvIFNUTWljcm9lbGVjdHJvbmljcyBMYW5kaW5nIFRlYW0gTGVhZApMaW5hcm8ub3Jn
IOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQVJNIFNvQ3MKRm9sbG93IExpbmFybzogRmFj
ZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX18KbG0tc2Vuc29ycyBtYWlsaW5nIGxpc3QKbG0tc2Vuc29yc0BsbS1zZW5z
b3JzLm9yZwpodHRwOi8vbGlzdHMubG0tc2Vuc29ycy5vcmcvbWFpbG1hbi9saXN0aW5mby9sbS1z
ZW5zb3Jz
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Jean Delvare <jdelvare@suse.de>
Cc: Laszlo Papp <lpapp@kde.org>,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver
Date: Thu, 13 Feb 2014 11:16:07 +0000 [thread overview]
Message-ID: <20140213111607.GK32508@lee--X1> (raw)
In-Reply-To: <20140213111530.2a2b4982@endymion.delvare>
On Thu, 13 Feb 2014, Jean Delvare wrote:
> On Thu, 13 Feb 2014 09:58:17 +0000, Lee Jones wrote:
> > > The MFD driver has now been added, so this driver is now being adopted to be a
> > > subdevice driver on top of it. This means, the i2c driver usage is being
> > > converted to platform driver usage all around.
> > >
> > > Signed-off-by: Laszlo Papp <lpapp@kde.org>
> > > ---
> > > This patch has been compile tested only and will be tested with real hardware,
> > > but early reviews to catch any trivial issues would be welcome.
> > > drivers/hwmon/Kconfig | 2 +-
> > > drivers/hwmon/max6650.c | 155 ++++++++++++++++++++++++------------------------
> > > 2 files changed, 79 insertions(+), 78 deletions(-)
> >
> > <snip>
> >
> > > /*
> > > * Insmod parameters
> > > @@ -105,24 +108,23 @@ module_param(clock, int, S_IRUGO);
> > >
> > > #define DIV_FROM_REG(reg) (1 << (reg & 7))
> > >
> > > -static int max6650_probe(struct i2c_client *client,
> > > - const struct i2c_device_id *id);
> > > -static int max6650_init_client(struct i2c_client *client);
> > > -static int max6650_remove(struct i2c_client *client);
> > > +static int max6650_probe(struct platform_device *pdev);
> > > +static int max6650_init_client(struct platform_device *pdev);
> > > +static int max6650_remove(struct platform_device *pdev);
> > > static struct max6650_data *max6650_update_device(struct device *dev);
> >
> > It would be good to remove these forward declarations in the future.
> >
> > If no one volunteers I'll happily do it.
>
> Guenter just did:
>
> http://lists.lm-sensors.org/pipermail/lm-sensors/2014-February/041224.html
Nice, FWIW:
Acked-by: Lee Jones <lee.jones@linaro.org>
> Any change to the max6650 driver should go on top of his patch series
> to avoid conflicts:
>
> http://lists.lm-sensors.org/pipermail/lm-sensors/2014-February/041223.html
Do you have a tree Laszlo can rebase on top of?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-02-13 11:16 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 8:50 [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver Laszlo Papp
2014-02-13 8:50 ` Laszlo Papp
2014-02-13 9:58 ` [lm-sensors] " Lee Jones
2014-02-13 9:58 ` Lee Jones
2014-02-13 10:15 ` [lm-sensors] " Jean Delvare
2014-02-13 10:15 ` Jean Delvare
2014-02-13 10:38 ` Laszlo Papp
2014-02-13 10:38 ` Laszlo Papp
2014-02-13 10:46 ` Laszlo Papp
2014-02-13 10:46 ` Laszlo Papp
2014-02-13 11:07 ` Jean Delvare
2014-02-13 11:07 ` Jean Delvare
2014-02-13 11:29 ` Laszlo Papp
2014-02-13 11:29 ` Laszlo Papp
2014-02-13 11:33 ` Lee Jones
2014-02-13 11:33 ` Lee Jones
2014-02-13 12:27 ` Laszlo Papp
2014-02-13 12:27 ` Laszlo Papp
2014-02-13 12:40 ` Lee Jones
2014-02-13 12:40 ` Lee Jones
2014-02-14 7:03 ` Laszlo Papp
2014-02-14 7:03 ` Laszlo Papp
2014-02-14 9:02 ` Lee Jones
2014-02-14 9:02 ` Lee Jones
2014-02-14 9:20 ` Laszlo Papp
2014-02-14 9:20 ` Laszlo Papp
2014-02-14 10:17 ` Lee Jones
2014-02-14 10:17 ` Lee Jones
2014-02-13 12:57 ` Jean Delvare
2014-02-13 12:57 ` Jean Delvare
2014-02-13 13:19 ` Laszlo Papp
2014-02-13 13:19 ` Laszlo Papp
2014-02-13 16:16 ` Guenter Roeck
2014-02-13 16:16 ` Guenter Roeck
2014-02-13 16:53 ` Laszlo Papp
2014-02-13 16:53 ` Laszlo Papp
2014-02-14 9:13 ` Lee Jones
2014-02-14 9:13 ` Lee Jones
2014-02-13 11:16 ` Lee Jones [this message]
2014-02-13 11:16 ` Lee Jones
2014-02-13 11:58 ` Jean Delvare
2014-02-13 11:58 ` Jean Delvare
2014-02-13 16:29 ` Guenter Roeck
2014-02-13 16:29 ` Guenter Roeck
2014-02-13 10:55 ` Laszlo Papp
2014-02-13 10:55 ` Laszlo Papp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140213111607.GK32508@lee--X1 \
--to=lee.jones@linaro.org \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=lpapp@kde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.