* [PATCH] dm: make dm_table_alloc_md_mempools static
@ 2014-02-13 18:43 Mikulas Patocka
2014-02-13 19:16 ` Mike Snitzer
0 siblings, 1 reply; 4+ messages in thread
From: Mikulas Patocka @ 2014-02-13 18:43 UTC (permalink / raw)
To: Mike Snitzer; +Cc: dm-devel, Alasdair G. Kergon
Make the function dm_table_alloc_md_mempools static because it is not
called from another module.
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
---
drivers/md/dm-table.c | 2 +-
drivers/md/dm.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
Index: linux-3.14-rc1/drivers/md/dm-table.c
===================================================================
--- linux-3.14-rc1.orig/drivers/md/dm-table.c 2014-02-06 13:37:06.000000000 +0100
+++ linux-3.14-rc1/drivers/md/dm-table.c 2014-02-06 13:37:17.000000000 +0100
@@ -957,7 +957,7 @@ bool dm_table_request_based(struct dm_ta
return dm_table_get_type(t) == DM_TYPE_REQUEST_BASED;
}
-int dm_table_alloc_md_mempools(struct dm_table *t)
+static int dm_table_alloc_md_mempools(struct dm_table *t)
{
unsigned type = dm_table_get_type(t);
unsigned per_bio_data_size = 0;
Index: linux-3.14-rc1/drivers/md/dm.h
===================================================================
--- linux-3.14-rc1.orig/drivers/md/dm.h 2014-02-06 13:36:53.000000000 +0100
+++ linux-3.14-rc1/drivers/md/dm.h 2014-02-06 13:37:01.000000000 +0100
@@ -73,7 +73,6 @@ unsigned dm_table_get_type(struct dm_tab
struct target_type *dm_table_get_immutable_target_type(struct dm_table *t);
bool dm_table_request_based(struct dm_table *t);
bool dm_table_supports_discards(struct dm_table *t);
-int dm_table_alloc_md_mempools(struct dm_table *t);
void dm_table_free_md_mempools(struct dm_table *t);
struct dm_md_mempools *dm_table_get_md_mempools(struct dm_table *t);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: dm: make dm_table_alloc_md_mempools static
2014-02-13 18:43 [PATCH] dm: make dm_table_alloc_md_mempools static Mikulas Patocka
@ 2014-02-13 19:16 ` Mike Snitzer
2014-02-13 19:19 ` Mikulas Patocka
0 siblings, 1 reply; 4+ messages in thread
From: Mike Snitzer @ 2014-02-13 19:16 UTC (permalink / raw)
To: Mikulas Patocka; +Cc: dm-devel, Alasdair G. Kergon
On Thu, Feb 13 2014 at 1:43pm -0500,
Mikulas Patocka <mpatocka@redhat.com> wrote:
> Make the function dm_table_alloc_md_mempools static because it is not
> called from another module.
Doesn't the same apply to dm_table_free_md_mempools?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: dm: make dm_table_alloc_md_mempools static
2014-02-13 19:16 ` Mike Snitzer
@ 2014-02-13 19:19 ` Mikulas Patocka
2014-02-13 19:20 ` Mike Snitzer
0 siblings, 1 reply; 4+ messages in thread
From: Mikulas Patocka @ 2014-02-13 19:19 UTC (permalink / raw)
To: Mike Snitzer; +Cc: dm-devel, Alasdair G. Kergon
On Thu, 13 Feb 2014, Mike Snitzer wrote:
> On Thu, Feb 13 2014 at 1:43pm -0500,
> Mikulas Patocka <mpatocka@redhat.com> wrote:
>
> > Make the function dm_table_alloc_md_mempools static because it is not
> > called from another module.
>
> Doesn't the same apply to dm_table_free_md_mempools?
No, it is called from dm.c and defined in dm-table.c
Mikulas
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: dm: make dm_table_alloc_md_mempools static
2014-02-13 19:19 ` Mikulas Patocka
@ 2014-02-13 19:20 ` Mike Snitzer
0 siblings, 0 replies; 4+ messages in thread
From: Mike Snitzer @ 2014-02-13 19:20 UTC (permalink / raw)
To: Mikulas Patocka; +Cc: dm-devel, Alasdair G. Kergon
On Thu, Feb 13 2014 at 2:19pm -0500,
Mikulas Patocka <mpatocka@redhat.com> wrote:
>
>
> On Thu, 13 Feb 2014, Mike Snitzer wrote:
>
> > On Thu, Feb 13 2014 at 1:43pm -0500,
> > Mikulas Patocka <mpatocka@redhat.com> wrote:
> >
> > > Make the function dm_table_alloc_md_mempools static because it is not
> > > called from another module.
> >
> > Doesn't the same apply to dm_table_free_md_mempools?
>
> No, it is called from dm.c and defined in dm-table.c
Ah, yeah.. I was thinking of exports.. sorry.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-02-13 19:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-13 18:43 [PATCH] dm: make dm_table_alloc_md_mempools static Mikulas Patocka
2014-02-13 19:16 ` Mike Snitzer
2014-02-13 19:19 ` Mikulas Patocka
2014-02-13 19:20 ` Mike Snitzer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.