[Cocci] Patch macros

[Cocci] Patch macros

[Andi Kleen]

Hi,

I was trying to replace static asmlinkage with static. However
it always gives a cocci parsing error. I assume the problem is that
asmlinkage is really a macro (for __attribute__((visible)) in
my case). How to handle this in cocci?

Thanks,

-Andi

@@
type T;
@@
- static asmlinkage T
+ static T


-- 
ak at linux.intel.com -- Speaking for myself only

[Cocci] Patch macros

[Julia Lawall]

On Fri, 14 Feb 2014, Andi Kleen wrote:

>
> Hi,
>
> I was trying to replace static asmlinkage with static. However
> it always gives a cocci parsing error. I assume the problem is that
> asmlinkage is really a macro (for __attribute__((visible)) in
> my case). How to handle this in cocci?

Unfortunately, I don't think it is possible.  The Coccinelle C parser
doesn't have any notion of asmlinkage, and so it skips over it.

julia

>
> Thanks,
>
> -Andi
>
> @@
> type T;
> @@
> - static asmlinkage T
> + static T
>
>
> --
> ak at linux.intel.com -- Speaking for myself only
> _______________________________________________
> Cocci mailing list
> Cocci at systeme.lip6.fr
> https://systeme.lip6.fr/mailman/listinfo/cocci
>

[Cocci] Patch macros

[Andi Kleen]

On Fri, Feb 14, 2014 at 04:51:18PM +0100, Julia Lawall wrote:
> On Fri, 14 Feb 2014, Andi Kleen wrote:
> 
> >
> > Hi,
> >
> > I was trying to replace static asmlinkage with static. However
> > it always gives a cocci parsing error. I assume the problem is that
> > asmlinkage is really a macro (for __attribute__((visible)) in
> > my case). How to handle this in cocci?
> 
> Unfortunately, I don't think it is possible.  The Coccinelle C parser
> doesn't have any notion of asmlinkage, and so it skips over it.

I was hoping there was a way to tell cocci about the macros.

Ok, back to sed then for this.

Thanks Julia.

-Andi

[Cocci] Patch macros

[Julia Lawall]

On Fri, 14 Feb 2014, Andi Kleen wrote:

> On Fri, Feb 14, 2014 at 04:51:18PM +0100, Julia Lawall wrote:
> > On Fri, 14 Feb 2014, Andi Kleen wrote:
> > 
> > >
> > > Hi,
> > >
> > > I was trying to replace static asmlinkage with static. However
> > > it always gives a cocci parsing error. I assume the problem is that
> > > asmlinkage is really a macro (for __attribute__((visible)) in
> > > my case). How to handle this in cocci?
> > 
> > Unfortunately, I don't think it is possible.  The Coccinelle C parser
> > doesn't have any notion of asmlinkage, and so it skips over it.
> 
> I was hoping there was a way to tell cocci about the macros.

It can be informed about some macros, but unfortunately in this position 
it doesn't expect anything at all.  It considers the __attribute__ things 
to be nonexistent as well.

julia