From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Mika Westerberg
<mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Andy Shevchenko
<andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] i2c: designware-pci: Add Baytrail PCI IDs
Date: Sat, 15 Feb 2014 16:27:37 +0100 [thread overview]
Message-ID: <20140215152736.GF2579@katana> (raw)
In-Reply-To: <1391524279-23409-1-git-send-email-mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 686 bytes --]
On Tue, Feb 04, 2014 at 04:31:19PM +0200, Mika Westerberg wrote:
> Intel Baytrail I2C controllers can be enumerated from PCI as well as from
> ACPI. In order to support this add the Baytrail PCI IDs to the driver.
>
> Signed-off-by: Mika Westerberg <mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Basically fine, one question:
> - snprintf(adap->name, sizeof(adap->name), "i2c-designware-pci-%d",
> - adap->nr);
> +
> + if (adap->nr < 0)
> + snprintf(adap->name, sizeof(adap->name), "i2c-designware-pci");
> + else
> + snprintf(adap->name, sizeof(adap->name),
> + "i2c-designware-pci-%d", adap->nr);
Maybe we just drop the "-%d" suffix entirely?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: linux-i2c@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: designware-pci: Add Baytrail PCI IDs
Date: Sat, 15 Feb 2014 16:27:37 +0100 [thread overview]
Message-ID: <20140215152736.GF2579@katana> (raw)
In-Reply-To: <1391524279-23409-1-git-send-email-mika.westerberg@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 662 bytes --]
On Tue, Feb 04, 2014 at 04:31:19PM +0200, Mika Westerberg wrote:
> Intel Baytrail I2C controllers can be enumerated from PCI as well as from
> ACPI. In order to support this add the Baytrail PCI IDs to the driver.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Basically fine, one question:
> - snprintf(adap->name, sizeof(adap->name), "i2c-designware-pci-%d",
> - adap->nr);
> +
> + if (adap->nr < 0)
> + snprintf(adap->name, sizeof(adap->name), "i2c-designware-pci");
> + else
> + snprintf(adap->name, sizeof(adap->name),
> + "i2c-designware-pci-%d", adap->nr);
Maybe we just drop the "-%d" suffix entirely?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-02-15 15:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 14:31 [PATCH] i2c: designware-pci: Add Baytrail PCI IDs Mika Westerberg
2014-02-04 14:31 ` Mika Westerberg
[not found] ` <1391524279-23409-1-git-send-email-mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-02-15 15:27 ` Wolfram Sang [this message]
2014-02-15 15:27 ` Wolfram Sang
2014-02-17 8:11 ` Mika Westerberg
2014-02-17 8:11 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140215152736.GF2579@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.