From: Guenter Roeck <linux@roeck-us.net>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: linux-watchdog@vger.kernel.org, Wim Van Sebroeck <wim@iguana.be>
Subject: Re: [PATCH] watchdog: shwdt: Remove unused variable
Date: Sat, 15 Feb 2014 09:52:04 -0800 [thread overview]
Message-ID: <20140215175204.GF19001@roeck-us.net> (raw)
In-Reply-To: <1392456187-30082-1-git-send-email-shc_work@mail.ru>
On Sat, Feb 15, 2014 at 01:23:07PM +0400, Alexander Shiyan wrote:
> Variable "wdt" is not used anywhere in the function sh_wdt_remove().
> This patch removes this variable.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Though you might as well remove the matching platform_set_drvdata()
which is also unnecessary.
> ---
> drivers/watchdog/shwdt.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/watchdog/shwdt.c b/drivers/watchdog/shwdt.c
> index af3528f..d04d02b 100644
> --- a/drivers/watchdog/shwdt.c
> +++ b/drivers/watchdog/shwdt.c
> @@ -293,8 +293,6 @@ static int sh_wdt_probe(struct platform_device *pdev)
>
> static int sh_wdt_remove(struct platform_device *pdev)
> {
> - struct sh_wdt *wdt = platform_get_drvdata(pdev);
> -
> watchdog_unregister_device(&sh_wdt_dev);
>
> pm_runtime_disable(&pdev->dev);
> --
> 1.8.3.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-02-15 17:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-15 9:23 [PATCH] watchdog: shwdt: Remove unused variable Alexander Shiyan
2014-02-15 17:52 ` Guenter Roeck [this message]
2014-02-15 17:57 ` Alexander Shiyan
2014-02-24 20:00 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140215175204.GF19001@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-watchdog@vger.kernel.org \
--cc=shc_work@mail.ru \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.