* [PATCH] watchdog: shwdt: Remove unused variable
@ 2014-02-15 9:23 Alexander Shiyan
2014-02-15 17:52 ` Guenter Roeck
2014-02-24 20:00 ` Wim Van Sebroeck
0 siblings, 2 replies; 4+ messages in thread
From: Alexander Shiyan @ 2014-02-15 9:23 UTC (permalink / raw)
To: linux-watchdog; +Cc: Wim Van Sebroeck, Alexander Shiyan
Variable "wdt" is not used anywhere in the function sh_wdt_remove().
This patch removes this variable.
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
drivers/watchdog/shwdt.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/watchdog/shwdt.c b/drivers/watchdog/shwdt.c
index af3528f..d04d02b 100644
--- a/drivers/watchdog/shwdt.c
+++ b/drivers/watchdog/shwdt.c
@@ -293,8 +293,6 @@ static int sh_wdt_probe(struct platform_device *pdev)
static int sh_wdt_remove(struct platform_device *pdev)
{
- struct sh_wdt *wdt = platform_get_drvdata(pdev);
-
watchdog_unregister_device(&sh_wdt_dev);
pm_runtime_disable(&pdev->dev);
--
1.8.3.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] watchdog: shwdt: Remove unused variable
2014-02-15 9:23 [PATCH] watchdog: shwdt: Remove unused variable Alexander Shiyan
@ 2014-02-15 17:52 ` Guenter Roeck
2014-02-15 17:57 ` Alexander Shiyan
2014-02-24 20:00 ` Wim Van Sebroeck
1 sibling, 1 reply; 4+ messages in thread
From: Guenter Roeck @ 2014-02-15 17:52 UTC (permalink / raw)
To: Alexander Shiyan; +Cc: linux-watchdog, Wim Van Sebroeck
On Sat, Feb 15, 2014 at 01:23:07PM +0400, Alexander Shiyan wrote:
> Variable "wdt" is not used anywhere in the function sh_wdt_remove().
> This patch removes this variable.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Though you might as well remove the matching platform_set_drvdata()
which is also unnecessary.
> ---
> drivers/watchdog/shwdt.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/watchdog/shwdt.c b/drivers/watchdog/shwdt.c
> index af3528f..d04d02b 100644
> --- a/drivers/watchdog/shwdt.c
> +++ b/drivers/watchdog/shwdt.c
> @@ -293,8 +293,6 @@ static int sh_wdt_probe(struct platform_device *pdev)
>
> static int sh_wdt_remove(struct platform_device *pdev)
> {
> - struct sh_wdt *wdt = platform_get_drvdata(pdev);
> -
> watchdog_unregister_device(&sh_wdt_dev);
>
> pm_runtime_disable(&pdev->dev);
> --
> 1.8.3.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] watchdog: shwdt: Remove unused variable
2014-02-15 17:52 ` Guenter Roeck
@ 2014-02-15 17:57 ` Alexander Shiyan
0 siblings, 0 replies; 4+ messages in thread
From: Alexander Shiyan @ 2014-02-15 17:57 UTC (permalink / raw)
To: Guenter Roeck; +Cc: linux-watchdog, Wim Van Sebroeck
Суббота, 15 февраля 2014, 9:52 -08:00 от Guenter Roeck <linux@roeck-us.net>:
> On Sat, Feb 15, 2014 at 01:23:07PM +0400, Alexander Shiyan wrote:
> > Variable "wdt" is not used anywhere in the function sh_wdt_remove().
> > This patch removes this variable.
> >
> > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
> Though you might as well remove the matching platform_set_drvdata()
> which is also unnecessary.
Indeed. I'll do it in the next series. Thanks.
---
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] watchdog: shwdt: Remove unused variable
2014-02-15 9:23 [PATCH] watchdog: shwdt: Remove unused variable Alexander Shiyan
2014-02-15 17:52 ` Guenter Roeck
@ 2014-02-24 20:00 ` Wim Van Sebroeck
1 sibling, 0 replies; 4+ messages in thread
From: Wim Van Sebroeck @ 2014-02-24 20:00 UTC (permalink / raw)
To: Alexander Shiyan; +Cc: linux-watchdog
Hi Alexander,
> Variable "wdt" is not used anywhere in the function sh_wdt_remove().
> This patch removes this variable.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> drivers/watchdog/shwdt.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/watchdog/shwdt.c b/drivers/watchdog/shwdt.c
> index af3528f..d04d02b 100644
> --- a/drivers/watchdog/shwdt.c
> +++ b/drivers/watchdog/shwdt.c
> @@ -293,8 +293,6 @@ static int sh_wdt_probe(struct platform_device *pdev)
>
> static int sh_wdt_remove(struct platform_device *pdev)
> {
> - struct sh_wdt *wdt = platform_get_drvdata(pdev);
> -
> watchdog_unregister_device(&sh_wdt_dev);
>
> pm_runtime_disable(&pdev->dev);
> --
> 1.8.3.2
>
This patch has been added to linux-watchdog-next.
Kind regards,
Wim.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-02-24 20:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-15 9:23 [PATCH] watchdog: shwdt: Remove unused variable Alexander Shiyan
2014-02-15 17:52 ` Guenter Roeck
2014-02-15 17:57 ` Alexander Shiyan
2014-02-24 20:00 ` Wim Van Sebroeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.