From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Cody P Schafer <cody@linux.vnet.ibm.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
LKML <linux-kernel@vger.kernel.org>,
Michael Ellerman <michael@ellerman.id.au>,
Ingo Molnar <mingo@redhat.com>, Paul Mackerras <paulus@samba.org>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Linux PPC <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v2 03/11] sysfs: create bin_attributes under the requested group
Date: Sat, 15 Feb 2014 12:15:15 -0800 [thread overview]
Message-ID: <20140215201515.GA28316@kroah.com> (raw)
In-Reply-To: <1392415338-16288-4-git-send-email-cody@linux.vnet.ibm.com>
On Fri, Feb 14, 2014 at 02:02:07PM -0800, Cody P Schafer wrote:
> bin_attributes created/updated in create_files() (such as those listed
> via (struct device).attribute_groups) were not placed under the
> specified group, and instead appeared in the base kobj directory.
>
> Fix this by making bin_attributes use creating code similar to normal
> attributes.
>
> A quick grep shows that no one is using bin_attrs in a named attribute
> group yet, so we can do this without breaking anything in usespace.
>
> Note that I do not add is_visible() support to
> bin_attributes, though that could be done as well.
is_visible() support would be nice to add if you get a chance.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Cody P Schafer <cody@linux.vnet.ibm.com>
Cc: Linux PPC <linuxppc-dev@lists.ozlabs.org>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Ingo Molnar <mingo@redhat.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Michael Ellerman <michael@ellerman.id.au>
Subject: Re: [PATCH v2 03/11] sysfs: create bin_attributes under the requested group
Date: Sat, 15 Feb 2014 12:15:15 -0800 [thread overview]
Message-ID: <20140215201515.GA28316@kroah.com> (raw)
In-Reply-To: <1392415338-16288-4-git-send-email-cody@linux.vnet.ibm.com>
On Fri, Feb 14, 2014 at 02:02:07PM -0800, Cody P Schafer wrote:
> bin_attributes created/updated in create_files() (such as those listed
> via (struct device).attribute_groups) were not placed under the
> specified group, and instead appeared in the base kobj directory.
>
> Fix this by making bin_attributes use creating code similar to normal
> attributes.
>
> A quick grep shows that no one is using bin_attrs in a named attribute
> group yet, so we can do this without breaking anything in usespace.
>
> Note that I do not add is_visible() support to
> bin_attributes, though that could be done as well.
is_visible() support would be nice to add if you get a chance.
thanks,
greg k-h
next prev parent reply other threads:[~2014-02-15 20:13 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 22:02 [PATCH v2 00/11] powerpc: Add support for Power Hypervisor supplied performance counters Cody P Schafer
2014-02-14 22:02 ` Cody P Schafer
2014-02-14 22:02 ` [PATCH v2 01/11] perf: add PMU_RANGE_ATTR() helper for use by sw-like pmus Cody P Schafer
2014-02-14 22:02 ` Cody P Schafer
2014-02-25 3:33 ` Michael Ellerman
2014-02-25 20:33 ` Cody P Schafer
2014-02-25 22:19 ` Cody P Schafer
2014-02-14 22:02 ` [PATCH v2 02/11] perf core: export swevent hrtimer helpers Cody P Schafer
2014-02-14 22:02 ` Cody P Schafer
2014-02-25 3:33 ` Michael Ellerman
2014-02-25 10:20 ` Peter Zijlstra
2014-02-25 10:20 ` Peter Zijlstra
2014-02-25 21:38 ` Cody P Schafer
2014-02-25 21:38 ` Cody P Schafer
2014-02-26 8:29 ` Peter Zijlstra
2014-02-26 8:29 ` Peter Zijlstra
2014-02-27 19:33 ` Cody P Schafer
2014-02-27 19:33 ` Cody P Schafer
2014-02-14 22:02 ` [PATCH v2 03/11] sysfs: create bin_attributes under the requested group Cody P Schafer
2014-02-14 22:02 ` Cody P Schafer
2014-02-15 20:15 ` Greg Kroah-Hartman [this message]
2014-02-15 20:15 ` Greg Kroah-Hartman
2014-02-25 3:33 ` Michael Ellerman
2014-02-25 3:33 ` Michael Ellerman
2014-02-14 22:02 ` [PATCH v2 04/11] powerpc: add hvcalls for 24x7 and gpci (get performance counter info) Cody P Schafer
2014-02-14 22:02 ` Cody P Schafer
2014-02-25 3:33 ` Michael Ellerman
2014-02-25 3:33 ` Michael Ellerman
2014-02-25 21:13 ` Cody P Schafer
2014-02-25 21:13 ` Cody P Schafer
2014-02-14 22:02 ` [PATCH v2 05/11] powerpc: add hv_gpci interface header Cody P Schafer
2014-02-14 22:02 ` Cody P Schafer
2014-02-25 3:33 ` Michael Ellerman
2014-02-25 3:33 ` Michael Ellerman
2014-02-25 20:35 ` Cody P Schafer
2014-02-25 20:35 ` Cody P Schafer
2014-02-14 22:02 ` [PATCH v2 06/11] powerpc: add 24x7 " Cody P Schafer
2014-02-14 22:02 ` Cody P Schafer
2014-02-14 22:02 ` [PATCH v2 07/11] powerpc: add a shared interface to get gpci version and capabilities Cody P Schafer
2014-02-14 22:02 ` Cody P Schafer
2014-02-25 3:33 ` Michael Ellerman
2014-02-25 3:33 ` Michael Ellerman
2014-02-25 21:20 ` Cody P Schafer
2014-02-25 21:20 ` Cody P Schafer
2014-02-14 22:02 ` [PATCH v2 08/11] powerpc/perf: add support for the hv gpci (get performance counter info) interface Cody P Schafer
2014-02-14 22:02 ` Cody P Schafer
2014-02-25 3:33 ` Michael Ellerman
2014-02-25 3:33 ` Michael Ellerman
2014-02-25 21:25 ` Cody P Schafer
2014-02-25 21:25 ` Cody P Schafer
2014-02-14 22:02 ` [PATCH v2 09/11] powerpc/perf: add support for the hv 24x7 interface Cody P Schafer
2014-02-14 22:02 ` Cody P Schafer
2014-02-25 3:33 ` Michael Ellerman
2014-02-25 3:33 ` Michael Ellerman
2014-02-25 20:55 ` Cody P Schafer
2014-02-25 20:55 ` Cody P Schafer
2014-02-14 22:02 ` [PATCH v2 10/11] powerpc/perf: add kconfig option for hypervisor provided counters Cody P Schafer
2014-02-14 22:02 ` Cody P Schafer
2014-02-14 22:32 ` Scott Wood
2014-02-15 0:25 ` Cody P Schafer
2014-02-15 0:25 ` Cody P Schafer
2014-02-17 7:11 ` Michael Ellerman
2014-02-17 7:11 ` Michael Ellerman
2014-02-17 19:41 ` Cody P Schafer
2014-02-17 19:41 ` Cody P Schafer
2014-02-21 0:14 ` [PATCH v2.1 9/11] " Cody P Schafer
2014-02-21 0:14 ` Cody P Schafer
2014-02-21 0:24 ` Cody P Schafer
2014-02-21 0:24 ` Cody P Schafer
2014-02-25 3:33 ` [PATCH v2 10/11] " Michael Ellerman
2014-02-25 3:33 ` Michael Ellerman
2014-02-25 21:31 ` Cody P Schafer
2014-02-25 21:31 ` Cody P Schafer
2014-02-26 3:48 ` Michael Ellerman
2014-02-26 3:48 ` Michael Ellerman
2014-02-14 22:02 ` [PATCH v2 11/11] powerpc/perf/hv_{gpci, 24x7}: add documentation of device attributes Cody P Schafer
2014-02-14 22:02 ` [PATCH v2 11/11] powerpc/perf/hv_{gpci,24x7}: " Cody P Schafer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140215201515.GA28316@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=cody@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.