From: Wolfram Sang <wsa@the-dreams.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/5] ARM: shmobile: r8a7791: add i2c master nodes to dtsi
Date: Mon, 17 Feb 2014 09:12:37 +0000 [thread overview]
Message-ID: <20140217091237.GC2633@katana> (raw)
In-Reply-To: <CANqRtoSDxQfSw5PJB6-UcL-UuMySBkoCqfC+1H=o-EBA18ouLQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 956 bytes --]
> > Why is that? From my knowledge, you start with the exact compatible
> > property and hardware compatible entries may follow.
>
> I think this boils down to if they really are compatible or not. If
> for instance a 16550 port would be compatible with 8250 on a hardware
> level then using them in the order of "16550", "8250" makes sense. In
> this case the r8a7791 i2c is not really strictly based on r8a7790 i2c,
> it is just that r8a7790 has support in the driver. So it's a short cut
> instead of actual hardware compatibility.
I don't get this point. The legacy board code for koelsch and lager both
create a platform_device with "i2c-rcar_gen2", so the cores surely must
be compatible? Maybe the cores are not strictly based on each other, but
compatible, yes, I'd say.
> So far we've dealt with this by updating the driver and only relying
> on the actual SoC name as suffix.
OK, for consistency reasons I will resend.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] ARM: shmobile: r8a7791: add i2c master nodes to dtsi
Date: Mon, 17 Feb 2014 10:12:37 +0100 [thread overview]
Message-ID: <20140217091237.GC2633@katana> (raw)
In-Reply-To: <CANqRtoSDxQfSw5PJB6-UcL-UuMySBkoCqfC+1H=o-EBA18ouLQ@mail.gmail.com>
> > Why is that? From my knowledge, you start with the exact compatible
> > property and hardware compatible entries may follow.
>
> I think this boils down to if they really are compatible or not. If
> for instance a 16550 port would be compatible with 8250 on a hardware
> level then using them in the order of "16550", "8250" makes sense. In
> this case the r8a7791 i2c is not really strictly based on r8a7790 i2c,
> it is just that r8a7790 has support in the driver. So it's a short cut
> instead of actual hardware compatibility.
I don't get this point. The legacy board code for koelsch and lager both
create a platform_device with "i2c-rcar_gen2", so the cores surely must
be compatible? Maybe the cores are not strictly based on each other, but
compatible, yes, I'd say.
> So far we've dealt with this by updating the driver and only relying
> on the actual SoC name as suffix.
OK, for consistency reasons I will resend.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140217/064932de/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: SH-Linux <linux-sh@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
devicetree@vger.kernel.org, Simon Horman <horms@verge.net.au>
Subject: Re: [PATCH 2/5] ARM: shmobile: r8a7791: add i2c master nodes to dtsi
Date: Mon, 17 Feb 2014 10:12:37 +0100 [thread overview]
Message-ID: <20140217091237.GC2633@katana> (raw)
In-Reply-To: <CANqRtoSDxQfSw5PJB6-UcL-UuMySBkoCqfC+1H=o-EBA18ouLQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 956 bytes --]
> > Why is that? From my knowledge, you start with the exact compatible
> > property and hardware compatible entries may follow.
>
> I think this boils down to if they really are compatible or not. If
> for instance a 16550 port would be compatible with 8250 on a hardware
> level then using them in the order of "16550", "8250" makes sense. In
> this case the r8a7791 i2c is not really strictly based on r8a7790 i2c,
> it is just that r8a7790 has support in the driver. So it's a short cut
> instead of actual hardware compatibility.
I don't get this point. The legacy board code for koelsch and lager both
create a platform_device with "i2c-rcar_gen2", so the cores surely must
be compatible? Maybe the cores are not strictly based on each other, but
compatible, yes, I'd say.
> So far we've dealt with this by updating the driver and only relying
> on the actual SoC name as suffix.
OK, for consistency reasons I will resend.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-02-17 9:12 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-16 9:40 [PATCH 0/5] enable i2c on koelsch-dt (and cleanup lager) Wolfram Sang
2014-02-16 9:40 ` Wolfram Sang
2014-02-16 9:40 ` Wolfram Sang
2014-02-16 9:40 ` [PATCH 1/5] ARM: shmobile: r8a7791: remove superfluous interrupt-parents Wolfram Sang
2014-02-16 9:40 ` Wolfram Sang
2014-02-16 9:40 ` Wolfram Sang
2014-02-16 9:40 ` [PATCH 2/5] ARM: shmobile: r8a7791: add i2c master nodes to dtsi Wolfram Sang
2014-02-16 9:40 ` Wolfram Sang
2014-02-16 9:40 ` Wolfram Sang
2014-02-17 7:54 ` Wolfram Sang
2014-02-17 7:54 ` Wolfram Sang
2014-02-17 7:54 ` Wolfram Sang
2014-02-17 8:02 ` Magnus Damm
2014-02-17 8:02 ` Magnus Damm
2014-02-17 8:02 ` Magnus Damm
2014-02-17 9:11 ` Geert Uytterhoeven
2014-02-17 9:11 ` Geert Uytterhoeven
2014-02-17 9:11 ` Geert Uytterhoeven
2014-02-17 9:19 ` Wolfram Sang
2014-02-17 9:19 ` Wolfram Sang
2014-02-17 9:19 ` Wolfram Sang
2014-02-17 9:23 ` Geert Uytterhoeven
2014-02-17 9:23 ` Geert Uytterhoeven
2014-02-17 9:23 ` Geert Uytterhoeven
2014-02-17 9:31 ` Wolfram Sang
2014-02-17 9:31 ` Wolfram Sang
2014-02-17 9:31 ` Wolfram Sang
2014-02-17 10:03 ` Magnus Damm
2014-02-17 10:03 ` Magnus Damm
2014-02-17 10:03 ` Magnus Damm
2014-02-17 10:08 ` Wolfram Sang
2014-02-17 10:08 ` Wolfram Sang
2014-02-17 10:08 ` Wolfram Sang
2014-02-17 10:11 ` Magnus Damm
2014-02-17 10:11 ` Magnus Damm
2014-02-17 10:11 ` Magnus Damm
2014-02-17 10:25 ` Wolfram Sang
2014-02-17 10:25 ` Wolfram Sang
2014-02-17 10:25 ` Wolfram Sang
2014-02-17 9:12 ` Wolfram Sang [this message]
2014-02-17 9:12 ` Wolfram Sang
2014-02-17 9:12 ` Wolfram Sang
2014-02-17 9:57 ` Magnus Damm
2014-02-17 9:57 ` Magnus Damm
2014-02-17 9:57 ` Magnus Damm
2014-02-16 9:40 ` [PATCH 3/5] ARM: shmobile: r8a7791: add i2c2 bus to koelsch dt Wolfram Sang
2014-02-16 9:40 ` Wolfram Sang
2014-02-16 9:40 ` Wolfram Sang
2014-02-16 9:40 ` [PATCH 4/5] ARM: shmobile: r8a7790: remove superfluous interrupt-parents Wolfram Sang
2014-02-16 9:40 ` Wolfram Sang
2014-02-16 9:40 ` Wolfram Sang
2014-02-16 9:40 ` [PATCH 5/5] ARM: shmobile: r8a7790: add i2c aliases to dtsi Wolfram Sang
2014-02-16 9:40 ` Wolfram Sang
2014-02-16 9:40 ` Wolfram Sang
2014-02-17 3:13 ` [PATCH 0/5] enable i2c on koelsch-dt (and cleanup lager) Magnus Damm
2014-02-17 3:13 ` Magnus Damm
2014-02-17 3:13 ` Magnus Damm
2014-02-17 3:19 ` Simon Horman
2014-02-17 3:19 ` Simon Horman
2014-02-17 3:19 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140217091237.GC2633@katana \
--to=wsa@the-dreams.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.