From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: imx: remove MACH_MXLADS
Date: Mon, 17 Feb 2014 10:18:40 +0100 [thread overview]
Message-ID: <20140217091840.GO17250@pengutronix.de> (raw)
In-Reply-To: <1392627768.10966.23.camel@x220>
On Mon, Feb 17, 2014 at 10:02:48AM +0100, Paul Bolle wrote:
> On Mon, 2014-02-17 at 08:43 +0400, Alexander Shiyan wrote:
> > It seems that even in the current state, Kconfig for i.MX contains an error.
> > As a start, we should rename ARCH_MX1ADS to MACH_MX1ADS first.
No. Have a look at arch/arm/tools/mach-types:
mxlads MACH_MXLADS MXLADS 1851
mx1ads ARCH_MX1ADS MX1ADS 160
And what gen-mach-types makes from it:
#ifdef CONFIG_MACH_MXLADS
# ifdef machine_arch_type
# undef machine_arch_type
# define machine_arch_type __machine_arch_type
# else
# define machine_arch_type MACH_TYPE_MXLADS
# endif
# define machine_is_mxlads() (machine_arch_type == MACH_TYPE_MXLADS)
#else
# define machine_is_mxlads() (0)
#endif
#ifdef CONFIG_ARCH_MX1ADS
# ifdef machine_arch_type
# undef machine_arch_type
# define machine_arch_type __machine_arch_type
# else
# define machine_arch_type MACH_TYPE_MX1ADS
# endif
# define machine_is_mx1ads() (machine_arch_type == MACH_TYPE_MX1ADS)
#else
# define machine_is_mx1ads() (0)
#endif
So machine_is_mx1ads() can only ever evaluate to true when
CONFIG_ARCH_MX1ADS is set and machine_is_mxlads() can only evaluate to true
when CONFIG_MACH_MXLADS is set.
Whether to use ARCH or MACH simply depends on what Russell has in the
machine registry database for a given board.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Alexander Shiyan <shc_work@mail.ru>,
Russell King <linux@arm.linux.org.uk>,
Richard Weinberger <richard@nod.at>,
linux-kernel@vger.kernel.org,
Sascha Hauer <kernel@pengutronix.de>,
Shawn Guo <shawn.guo@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm: imx: remove MACH_MXLADS
Date: Mon, 17 Feb 2014 10:18:40 +0100 [thread overview]
Message-ID: <20140217091840.GO17250@pengutronix.de> (raw)
In-Reply-To: <1392627768.10966.23.camel@x220>
On Mon, Feb 17, 2014 at 10:02:48AM +0100, Paul Bolle wrote:
> On Mon, 2014-02-17 at 08:43 +0400, Alexander Shiyan wrote:
> > It seems that even in the current state, Kconfig for i.MX contains an error.
> > As a start, we should rename ARCH_MX1ADS to MACH_MX1ADS first.
No. Have a look at arch/arm/tools/mach-types:
mxlads MACH_MXLADS MXLADS 1851
mx1ads ARCH_MX1ADS MX1ADS 160
And what gen-mach-types makes from it:
#ifdef CONFIG_MACH_MXLADS
# ifdef machine_arch_type
# undef machine_arch_type
# define machine_arch_type __machine_arch_type
# else
# define machine_arch_type MACH_TYPE_MXLADS
# endif
# define machine_is_mxlads() (machine_arch_type == MACH_TYPE_MXLADS)
#else
# define machine_is_mxlads() (0)
#endif
#ifdef CONFIG_ARCH_MX1ADS
# ifdef machine_arch_type
# undef machine_arch_type
# define machine_arch_type __machine_arch_type
# else
# define machine_arch_type MACH_TYPE_MX1ADS
# endif
# define machine_is_mx1ads() (machine_arch_type == MACH_TYPE_MX1ADS)
#else
# define machine_is_mx1ads() (0)
#endif
So machine_is_mx1ads() can only ever evaluate to true when
CONFIG_ARCH_MX1ADS is set and machine_is_mxlads() can only evaluate to true
when CONFIG_MACH_MXLADS is set.
Whether to use ARCH or MACH simply depends on what Russell has in the
machine registry database for a given board.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2014-02-17 9:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-16 18:03 [PATCH] arm: imx: remove MACH_MXLADS Paul Bolle
2014-02-16 18:03 ` Paul Bolle
2014-02-16 18:16 ` Alexander Shiyan
2014-02-16 18:16 ` Alexander Shiyan
2014-02-16 18:43 ` Paul Bolle
2014-02-16 18:43 ` Paul Bolle
2014-02-16 19:06 ` Alexander Shiyan
2014-02-16 19:06 ` Alexander Shiyan
2014-02-16 19:12 ` Paul Bolle
2014-02-16 19:12 ` Paul Bolle
2014-02-16 19:21 ` Alexander Shiyan
2014-02-16 19:21 ` Alexander Shiyan
2014-02-16 20:35 ` Paul Bolle
2014-02-16 20:35 ` Paul Bolle
2014-02-17 4:43 ` Alexander Shiyan
2014-02-17 4:43 ` Alexander Shiyan
2014-02-17 9:02 ` Paul Bolle
2014-02-17 9:02 ` Paul Bolle
2014-02-17 9:18 ` Sascha Hauer [this message]
2014-02-17 9:18 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140217091840.GO17250@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.