* [PATCH] ATA: SATA_MV: Add missing Kconfig select statememnt
[not found] <52e00d45.5gijwyKGLiVLcCNX%fengguang.wu@intel.com>
@ 2014-01-22 19:56 ` Andrew Lunn
2014-01-29 18:20 ` Tejun Heo
0 siblings, 1 reply; 8+ messages in thread
From: Andrew Lunn @ 2014-01-22 19:56 UTC (permalink / raw)
To: tj; +Cc: linux-ide, Andrew Lunn
SATA_MV depends on GENERIC_PHY. So if SATA_MV is built in, GENERIC_PHY
cannot be modular. Fixes build error found by kbuild test robot.
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/ata/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 4e737728aee2..868429a47be4 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -247,6 +247,7 @@ config SATA_HIGHBANK
config SATA_MV
tristate "Marvell SATA support"
+ select GENERIC_PHY
help
This option enables support for the Marvell Serial ATA family.
Currently supports 88SX[56]0[48][01] PCI(-X) chips,
--
1.8.5.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] ATA: SATA_MV: Add missing Kconfig select statememnt
2014-01-22 19:56 ` [PATCH] ATA: SATA_MV: Add missing Kconfig select statememnt Andrew Lunn
@ 2014-01-29 18:20 ` Tejun Heo
2014-02-17 15:13 ` Ezequiel Garcia
0 siblings, 1 reply; 8+ messages in thread
From: Tejun Heo @ 2014-01-29 18:20 UTC (permalink / raw)
To: Andrew Lunn; +Cc: linux-ide
On Wed, Jan 22, 2014 at 08:56:33PM +0100, Andrew Lunn wrote:
> SATA_MV depends on GENERIC_PHY. So if SATA_MV is built in, GENERIC_PHY
> cannot be modular. Fixes build error found by kbuild test robot.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Applied to libata/for-3.14-fixes. Thanks.
--
tejun
^ permalink raw reply [flat|nested] 8+ messages in thread
* [v3.14-rc3 BUG] 1) panic and 2) SATA not working (Was Re: [PATCH] ATA: SATA_MV: Add missing Kconfig select statememnt)
2014-01-29 18:20 ` Tejun Heo
@ 2014-02-17 15:13 ` Ezequiel Garcia
0 siblings, 0 replies; 8+ messages in thread
From: Ezequiel Garcia @ 2014-02-17 15:13 UTC (permalink / raw)
To: Tejun Heo
Cc: Andrew Lunn, linux-ide, Thomas Petazzoni, Gregory Clement,
Jason Cooper, Kevin Hilman, linux-arm-kernel
On Wed, Jan 29, 2014 at 01:20:35PM -0500, Tejun Heo wrote:
> On Wed, Jan 22, 2014 at 08:56:33PM +0100, Andrew Lunn wrote:
> > SATA_MV depends on GENERIC_PHY. So if SATA_MV is built in, GENERIC_PHY
> > cannot be modular. Fixes build error found by kbuild test robot.
> >
> > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
>
> Applied to libata/for-3.14-fixes. Thanks.
>
Tejun, Jason:
The lack of this patch in -rc3, just made my Armada XP GP board panic.
The panic is the same as this one (reported on Kirkwood):
http://www.spinics.net/lists/arm-kernel/msg308080.html
Which is fixed in linux-next (and should be in -rc4, right?) by:
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=8ad116e649b21a42e3cccfb3c1b8d5ea52ba19e5
The SATA won't get probed unless this commit from linux-next is also applied:
commit 49c8f1ffe26ffddfb7244a24db21c0b4a79e1c52
Author: Andrew Lunn <andrew@lunn.ch>
Date: Wed Jan 22 20:56:33 2014 +0100
ATA: SATA_MV: Add missing Kconfig select statememnt
I guess it felt through someone cracks...
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* [v3.14-rc3 BUG] 1) panic and 2) SATA not working (Was Re: [PATCH] ATA: SATA_MV: Add missing Kconfig select statememnt)
@ 2014-02-17 15:13 ` Ezequiel Garcia
0 siblings, 0 replies; 8+ messages in thread
From: Ezequiel Garcia @ 2014-02-17 15:13 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 29, 2014 at 01:20:35PM -0500, Tejun Heo wrote:
> On Wed, Jan 22, 2014 at 08:56:33PM +0100, Andrew Lunn wrote:
> > SATA_MV depends on GENERIC_PHY. So if SATA_MV is built in, GENERIC_PHY
> > cannot be modular. Fixes build error found by kbuild test robot.
> >
> > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
>
> Applied to libata/for-3.14-fixes. Thanks.
>
Tejun, Jason:
The lack of this patch in -rc3, just made my Armada XP GP board panic.
The panic is the same as this one (reported on Kirkwood):
http://www.spinics.net/lists/arm-kernel/msg308080.html
Which is fixed in linux-next (and should be in -rc4, right?) by:
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=8ad116e649b21a42e3cccfb3c1b8d5ea52ba19e5
The SATA won't get probed unless this commit from linux-next is also applied:
commit 49c8f1ffe26ffddfb7244a24db21c0b4a79e1c52
Author: Andrew Lunn <andrew@lunn.ch>
Date: Wed Jan 22 20:56:33 2014 +0100
ATA: SATA_MV: Add missing Kconfig select statememnt
I guess it felt through someone cracks...
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [v3.14-rc3 BUG] 1) panic and 2) SATA not working (Was Re: [PATCH] ATA: SATA_MV: Add missing Kconfig select statememnt)
2014-02-17 15:13 ` Ezequiel Garcia
@ 2014-02-17 15:23 ` Jason Cooper
-1 siblings, 0 replies; 8+ messages in thread
From: Jason Cooper @ 2014-02-17 15:23 UTC (permalink / raw)
To: Ezequiel Garcia
Cc: Tejun Heo, Andrew Lunn, linux-ide, Thomas Petazzoni,
Gregory Clement, Kevin Hilman, linux-arm-kernel
On Mon, Feb 17, 2014 at 12:13:16PM -0300, Ezequiel Garcia wrote:
> On Wed, Jan 29, 2014 at 01:20:35PM -0500, Tejun Heo wrote:
> > On Wed, Jan 22, 2014 at 08:56:33PM +0100, Andrew Lunn wrote:
> > > SATA_MV depends on GENERIC_PHY. So if SATA_MV is built in, GENERIC_PHY
> > > cannot be modular. Fixes build error found by kbuild test robot.
> > >
> > > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> >
> > Applied to libata/for-3.14-fixes. Thanks.
> >
>
> Tejun, Jason:
>
> The lack of this patch in -rc3, just made my Armada XP GP board panic.
>
> The panic is the same as this one (reported on Kirkwood):
> http://www.spinics.net/lists/arm-kernel/msg308080.html
>
> Which is fixed in linux-next (and should be in -rc4, right?) by:
> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=8ad116e649b21a42e3cccfb3c1b8d5ea52ba19e5
>
> The SATA won't get probed unless this commit from linux-next is also applied:
>
> commit 49c8f1ffe26ffddfb7244a24db21c0b4a79e1c52
> Author: Andrew Lunn <andrew@lunn.ch>
> Date: Wed Jan 22 20:56:33 2014 +0100
>
> ATA: SATA_MV: Add missing Kconfig select statememnt
>
> I guess it felt through someone cracks...
Well, sort of. By the time I saw it, and realized it should be kept
next to the phy series fixes, Tejun had already taken it.
Looking back, I don't have the patch in my inbox...
thx,
Jason.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [v3.14-rc3 BUG] 1) panic and 2) SATA not working (Was Re: [PATCH] ATA: SATA_MV: Add missing Kconfig select statememnt)
@ 2014-02-17 15:23 ` Jason Cooper
0 siblings, 0 replies; 8+ messages in thread
From: Jason Cooper @ 2014-02-17 15:23 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Feb 17, 2014 at 12:13:16PM -0300, Ezequiel Garcia wrote:
> On Wed, Jan 29, 2014 at 01:20:35PM -0500, Tejun Heo wrote:
> > On Wed, Jan 22, 2014 at 08:56:33PM +0100, Andrew Lunn wrote:
> > > SATA_MV depends on GENERIC_PHY. So if SATA_MV is built in, GENERIC_PHY
> > > cannot be modular. Fixes build error found by kbuild test robot.
> > >
> > > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> >
> > Applied to libata/for-3.14-fixes. Thanks.
> >
>
> Tejun, Jason:
>
> The lack of this patch in -rc3, just made my Armada XP GP board panic.
>
> The panic is the same as this one (reported on Kirkwood):
> http://www.spinics.net/lists/arm-kernel/msg308080.html
>
> Which is fixed in linux-next (and should be in -rc4, right?) by:
> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=8ad116e649b21a42e3cccfb3c1b8d5ea52ba19e5
>
> The SATA won't get probed unless this commit from linux-next is also applied:
>
> commit 49c8f1ffe26ffddfb7244a24db21c0b4a79e1c52
> Author: Andrew Lunn <andrew@lunn.ch>
> Date: Wed Jan 22 20:56:33 2014 +0100
>
> ATA: SATA_MV: Add missing Kconfig select statememnt
>
> I guess it felt through someone cracks...
Well, sort of. By the time I saw it, and realized it should be kept
next to the phy series fixes, Tejun had already taken it.
Looking back, I don't have the patch in my inbox...
thx,
Jason.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [v3.14-rc3 BUG] 1) panic and 2) SATA not working (Was Re: [PATCH] ATA: SATA_MV: Add missing Kconfig select statememnt)
2014-02-17 15:13 ` Ezequiel Garcia
@ 2014-02-18 22:50 ` Tejun Heo
-1 siblings, 0 replies; 8+ messages in thread
From: Tejun Heo @ 2014-02-18 22:50 UTC (permalink / raw)
To: Ezequiel Garcia
Cc: Andrew Lunn, linux-ide, Thomas Petazzoni, Gregory Clement,
Jason Cooper, Kevin Hilman, linux-arm-kernel
On Mon, Feb 17, 2014 at 12:13:16PM -0300, Ezequiel Garcia wrote:
> On Wed, Jan 29, 2014 at 01:20:35PM -0500, Tejun Heo wrote:
> > On Wed, Jan 22, 2014 at 08:56:33PM +0100, Andrew Lunn wrote:
> > > SATA_MV depends on GENERIC_PHY. So if SATA_MV is built in, GENERIC_PHY
> > > cannot be modular. Fixes build error found by kbuild test robot.
> > >
> > > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> >
> > Applied to libata/for-3.14-fixes. Thanks.
> >
>
> Tejun, Jason:
>
> The lack of this patch in -rc3, just made my Armada XP GP board panic.
Will push out soon. Thanks.
--
tejun
^ permalink raw reply [flat|nested] 8+ messages in thread
* [v3.14-rc3 BUG] 1) panic and 2) SATA not working (Was Re: [PATCH] ATA: SATA_MV: Add missing Kconfig select statememnt)
@ 2014-02-18 22:50 ` Tejun Heo
0 siblings, 0 replies; 8+ messages in thread
From: Tejun Heo @ 2014-02-18 22:50 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Feb 17, 2014 at 12:13:16PM -0300, Ezequiel Garcia wrote:
> On Wed, Jan 29, 2014 at 01:20:35PM -0500, Tejun Heo wrote:
> > On Wed, Jan 22, 2014 at 08:56:33PM +0100, Andrew Lunn wrote:
> > > SATA_MV depends on GENERIC_PHY. So if SATA_MV is built in, GENERIC_PHY
> > > cannot be modular. Fixes build error found by kbuild test robot.
> > >
> > > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> >
> > Applied to libata/for-3.14-fixes. Thanks.
> >
>
> Tejun, Jason:
>
> The lack of this patch in -rc3, just made my Armada XP GP board panic.
Will push out soon. Thanks.
--
tejun
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-02-18 22:50 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <52e00d45.5gijwyKGLiVLcCNX%fengguang.wu@intel.com>
2014-01-22 19:56 ` [PATCH] ATA: SATA_MV: Add missing Kconfig select statememnt Andrew Lunn
2014-01-29 18:20 ` Tejun Heo
2014-02-17 15:13 ` [v3.14-rc3 BUG] 1) panic and 2) SATA not working (Was Re: [PATCH] ATA: SATA_MV: Add missing Kconfig select statememnt) Ezequiel Garcia
2014-02-17 15:13 ` Ezequiel Garcia
2014-02-17 15:23 ` Jason Cooper
2014-02-17 15:23 ` Jason Cooper
2014-02-18 22:50 ` Tejun Heo
2014-02-18 22:50 ` Tejun Heo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.