All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Lukas Czerner <lczerner@redhat.com>,
	Ext4 Developers List <linux-ext4@vger.kernel.org>,
	xfs@oss.sgi.com
Subject: Re: [PATCH 1/6] ext4: Update inode i_size after the preallocation
Date: Mon, 17 Feb 2014 18:21:00 -0500	[thread overview]
Message-ID: <20140217232100.GA26580@thunk.org> (raw)
In-Reply-To: <9288BED9-A44E-4ACC-9A3D-BC086AB4E121@dilger.ca>

On Mon, Feb 17, 2014 at 04:12:14PM -0700, Andreas Dilger wrote:
> 
> I don't necessarily agree about this.  Calling fallocate() will not
> change the user-visible data at all, so there is no reason to e.g.
> do a new backup of the file or reprocess the contents, or any other
> reason that an application cares about a changed mtime.

Well, if i_size has changed, then the visible results of reading from
the file will change, so in that case I'd argue m_time should change.
If the results of reading file doesn't change then we can keep m_time
unchanged --- but since the inode is changing, c_time *should* always
change any time we've made any changes to the extent tree.

	      	  	    	     - Ted

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2014-02-17 23:21 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-17 15:08 [PATCH 0/6][RFC] Introduce FALLOC_FL_ZERO_RANGE flag for fallocate Lukas Czerner
2014-02-17 15:08 ` Lukas Czerner
2014-02-17 15:08 ` [PATCH 1/6] ext4: Update inode i_size after the preallocation Lukas Czerner
2014-02-17 15:08   ` Lukas Czerner
2014-02-17 23:12   ` Andreas Dilger
2014-02-17 23:12     ` Andreas Dilger
2014-02-17 23:21     ` Theodore Ts'o [this message]
2014-02-18  8:13       ` Lukáš Czerner
2014-02-18  8:13         ` Lukáš Czerner
2014-02-17 15:08 ` [PATCH 2/6] ext4: refactor ext4_fallocate code Lukas Czerner
2014-02-17 15:08   ` Lukas Czerner
2014-02-18  8:25   ` jon ernst
2014-02-17 15:08 ` [PATCH 3/6] ext4: translate fallocate mode bits to strings Lukas Czerner
2014-02-17 15:08   ` Lukas Czerner
2014-02-17 15:08 ` [PATCH 4/6] fs: Introduce FALLOC_FL_ZERO_RANGE flag for fallocate Lukas Czerner
2014-02-17 15:08   ` Lukas Czerner
2014-02-18  2:51   ` Dave Chinner
2014-02-18  8:10     ` Lukáš Czerner
2014-02-18  8:10       ` Lukáš Czerner
2014-02-17 15:08 ` [PATCH 5/6] ext4: " Lukas Czerner
2014-02-17 15:08   ` Lukas Czerner
2014-02-18  8:27   ` jon ernst
2014-02-17 15:08 ` [PATCH 6/6] xfs: Add support for FALLOC_FL_ZERO_RANGE Lukas Czerner
2014-02-17 15:08   ` Lukas Czerner
2014-02-18  4:51   ` Dave Chinner
2014-02-18  1:01 ` [PATCH 0/6][RFC] Introduce FALLOC_FL_ZERO_RANGE flag for fallocate Dave Chinner
2014-02-18  1:01   ` Dave Chinner
2014-02-18  8:33   ` Dave Chinner
2014-02-18  8:33     ` Dave Chinner
2014-02-18  9:09     ` Lukáš Czerner
2014-02-18  9:41       ` Dave Chinner
2014-02-18 12:04         ` Lukáš Czerner
2014-02-18 12:04           ` Lukáš Czerner
2014-02-18 14:23           ` Theodore Ts'o
2014-02-18 14:23             ` Theodore Ts'o
2014-02-18 14:42             ` Lukáš Czerner
2014-02-18 14:42               ` Lukáš Czerner
2014-02-19  0:33               ` Theodore Ts'o
2014-02-19 14:52 ` Dongsu Park
2014-02-19 14:52   ` Dongsu Park
2014-02-19 15:18   ` Lukáš Czerner
2014-02-19 15:18     ` Lukáš Czerner
2014-02-19 15:51     ` Dongsu Park
2014-02-20 11:16       ` Lukáš Czerner
2014-02-20 11:16         ` Lukáš Czerner
2014-02-24  1:07 ` Dave Chinner
2014-02-24 13:47   ` Lukáš Czerner
2014-02-24 13:47     ` Lukáš Czerner
2014-04-16  6:36 ` Christoph Hellwig
     [not found]   ` <20140416063618.GA12498-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2014-04-16 10:43     ` Lukáš Czerner
2014-04-16 10:43       ` Lukáš Czerner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140217232100.GA26580@thunk.org \
    --to=tytso@mit.edu \
    --cc=adilger@dilger.ca \
    --cc=lczerner@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.