From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Jason Cooper <jason@lakedaemon.net>
Cc: linux-arm-kernel@lists.infradead.org,
linux-watchdog@vger.kernel.org, Lior Amsalem <alior@marvell.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Tawfik Bayouk <tawfik@marvell.com>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Wim Van Sebroeck <wim@iguana.be>,
Gregory Clement <gregory.clement@free-electrons.com>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v7 11/18] watchdog: orion: Add per-compatible watchdog start implementation
Date: Mon, 17 Feb 2014 20:42:57 -0300 [thread overview]
Message-ID: <20140217234256.GA28783@localhost> (raw)
In-Reply-To: <20140217211113.GD7862@titan.lakedaemon.net>
On Mon, Feb 17, 2014 at 04:11:13PM -0500, Jason Cooper wrote:
> On Mon, Feb 17, 2014 at 04:08:22PM -0500, Jason Cooper wrote:
> > On Mon, Feb 10, 2014 at 08:00:30PM -0300, Ezequiel Garcia wrote:
> > > To handle differences between SoCs this commit adds per-compatible
> > > string start() function for the watchdog kick-off. This is preparation
> > > work and makes no functionality changes to the current driver.
> > >
> > > Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> > > Tested-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> > > Tested-by: Willy Tarreau <w@1wt.eu>
> > > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> > > ---
> > > drivers/watchdog/orion_wdt.c | 12 +++++++++++-
> > > 1 file changed, 11 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/watchdog/orion_wdt.c b/drivers/watchdog/orion_wdt.c
> > > index b48fd08..3925297 100644
> > > --- a/drivers/watchdog/orion_wdt.c
> > > +++ b/drivers/watchdog/orion_wdt.c
> > > @@ -50,6 +50,7 @@ struct orion_watchdog_data {
> > > int rstout_enable_bit;
> >
> >
> > > int (*clock_init)(struct platform_device *,
> > > struct orion_watchdog *);
> >
> > this...
> >
> > > + int (*start)(struct watchdog_device *);
> > > };
> > >
> > > struct orion_watchdog {
> > ...
> > > @@ -193,6 +202,7 @@ static const struct orion_watchdog_data orion_data = {
> > > .wdt_enable_bit = BIT(4),
> > > .wdt_counter_offset = 0x24,
> >
> >
> > > .clock_init = orion_wdt_clock_init,
> >
> > and this...
> >
> > > + .start = orion_start,
> > > };
> >
> > cause a failure to apply the patch. I hand-jammed it (attached), please
> > let me know what is going on here (missed dep?)
>
> disregard. I missed patch 10. It helps. :)
>
Phhheeew... my heart stopped for a minute ;-)
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 11/18] watchdog: orion: Add per-compatible watchdog start implementation
Date: Mon, 17 Feb 2014 20:42:57 -0300 [thread overview]
Message-ID: <20140217234256.GA28783@localhost> (raw)
In-Reply-To: <20140217211113.GD7862@titan.lakedaemon.net>
On Mon, Feb 17, 2014 at 04:11:13PM -0500, Jason Cooper wrote:
> On Mon, Feb 17, 2014 at 04:08:22PM -0500, Jason Cooper wrote:
> > On Mon, Feb 10, 2014 at 08:00:30PM -0300, Ezequiel Garcia wrote:
> > > To handle differences between SoCs this commit adds per-compatible
> > > string start() function for the watchdog kick-off. This is preparation
> > > work and makes no functionality changes to the current driver.
> > >
> > > Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> > > Tested-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> > > Tested-by: Willy Tarreau <w@1wt.eu>
> > > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> > > ---
> > > drivers/watchdog/orion_wdt.c | 12 +++++++++++-
> > > 1 file changed, 11 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/watchdog/orion_wdt.c b/drivers/watchdog/orion_wdt.c
> > > index b48fd08..3925297 100644
> > > --- a/drivers/watchdog/orion_wdt.c
> > > +++ b/drivers/watchdog/orion_wdt.c
> > > @@ -50,6 +50,7 @@ struct orion_watchdog_data {
> > > int rstout_enable_bit;
> >
> >
> > > int (*clock_init)(struct platform_device *,
> > > struct orion_watchdog *);
> >
> > this...
> >
> > > + int (*start)(struct watchdog_device *);
> > > };
> > >
> > > struct orion_watchdog {
> > ...
> > > @@ -193,6 +202,7 @@ static const struct orion_watchdog_data orion_data = {
> > > .wdt_enable_bit = BIT(4),
> > > .wdt_counter_offset = 0x24,
> >
> >
> > > .clock_init = orion_wdt_clock_init,
> >
> > and this...
> >
> > > + .start = orion_start,
> > > };
> >
> > cause a failure to apply the patch. I hand-jammed it (attached), please
> > let me know what is going on here (missed dep?)
>
> disregard. I missed patch 10. It helps. :)
>
Phhheeew... my heart stopped for a minute ;-)
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-02-17 23:43 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 23:00 [PATCH v7 00/18] Armada 370/XP watchdog Ezequiel Garcia
2014-02-10 23:00 ` Ezequiel Garcia
2014-02-10 23:00 ` [PATCH v7 01/18] watchdog: orion: Add clock error handling Ezequiel Garcia
2014-02-10 23:00 ` Ezequiel Garcia
2014-02-10 23:00 ` [PATCH v7 02/18] watchdog: orion: Use atomic access for shared registers Ezequiel Garcia
2014-02-10 23:00 ` Ezequiel Garcia
2014-02-10 23:00 ` [PATCH v7 03/18] watchdog: orion: Remove unused macros Ezequiel Garcia
2014-02-10 23:00 ` Ezequiel Garcia
2014-02-10 23:00 ` [PATCH v7 04/18] watchdog: orion: Make sure the watchdog is initially stopped Ezequiel Garcia
2014-02-10 23:00 ` Ezequiel Garcia
2014-02-10 23:00 ` [PATCH v7 05/18] watchdog: orion: Handle the interrupt so it's properly acked Ezequiel Garcia
2014-02-10 23:00 ` Ezequiel Garcia
2014-02-10 23:00 ` [PATCH v7 06/18] watchdog: orion: Make RSTOUT register a separate resource Ezequiel Garcia
2014-02-10 23:00 ` Ezequiel Garcia
2014-02-10 23:00 ` [PATCH v7 07/18] watchdog: orion: Remove unneeded BRIDGE_CAUSE clear Ezequiel Garcia
2014-02-10 23:00 ` Ezequiel Garcia
2014-02-10 23:00 ` [PATCH v7 08/18] watchdog: orion: Introduce an orion_watchdog device structure Ezequiel Garcia
2014-02-10 23:00 ` Ezequiel Garcia
2014-02-10 23:00 ` [PATCH v7 09/18] watchdog: orion: Introduce per-compatible of_device_id data Ezequiel Garcia
2014-02-10 23:00 ` Ezequiel Garcia
2014-02-10 23:00 ` [PATCH v7 10/18] watchdog: orion: Add per-compatible clock initialization Ezequiel Garcia
2014-02-10 23:00 ` Ezequiel Garcia
2014-02-10 23:00 ` [PATCH v7 11/18] watchdog: orion: Add per-compatible watchdog start implementation Ezequiel Garcia
2014-02-10 23:00 ` Ezequiel Garcia
2014-02-17 21:08 ` Jason Cooper
2014-02-17 21:08 ` Jason Cooper
2014-02-17 21:11 ` Jason Cooper
2014-02-17 21:11 ` Jason Cooper
2014-02-17 23:42 ` Ezequiel Garcia [this message]
2014-02-17 23:42 ` Ezequiel Garcia
2014-02-10 23:00 ` [PATCH v7 12/18] watchdog: orion: Add support for Armada 370 and Armada XP SoC Ezequiel Garcia
2014-02-10 23:00 ` Ezequiel Garcia
2014-02-10 23:00 ` [PATCH v7 13/18] ARM: mvebu: Enable Armada 370/XP watchdog in the devicetree Ezequiel Garcia
2014-02-10 23:00 ` Ezequiel Garcia
2014-02-10 23:00 ` [PATCH v7 14/18] ARM: kirkwood: Add RSTOUT 'reg' entry to devicetree Ezequiel Garcia
2014-02-10 23:00 ` Ezequiel Garcia
2014-02-10 23:00 ` [PATCH v7 15/18] ARM: dove: Enable Dove watchdog in the devicetree Ezequiel Garcia
2014-02-10 23:00 ` Ezequiel Garcia
2014-02-10 23:00 ` [PATCH v7 16/18] watchdog: orion: Enable the build on ARCH_MVEBU Ezequiel Garcia
2014-02-10 23:00 ` Ezequiel Garcia
2014-02-10 23:00 ` [PATCH v7 17/18] ARM: mvebu: Enable watchdog support in defconfig Ezequiel Garcia
2014-02-10 23:00 ` Ezequiel Garcia
2014-02-10 23:00 ` [PATCH v7 18/18] ARM: dove: Enable watchdog support in the defconfig Ezequiel Garcia
2014-02-10 23:00 ` Ezequiel Garcia
2014-02-11 8:31 ` [PATCH v7 00/18] Armada 370/XP watchdog Ezequiel Garcia
2014-02-11 8:31 ` Ezequiel Garcia
2014-02-15 8:26 ` Wim Van Sebroeck
2014-02-17 22:09 ` Jason Cooper
2014-02-17 22:09 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140217234256.GA28783@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=alior@marvell.com \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=tawfik@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.