From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Koen De Wit <koen.de.wit@oracle.com>,
xfs@oss.sgi.com, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] xfstests: test for atime-related mount options
Date: Tue, 18 Feb 2014 12:05:03 +1100 [thread overview]
Message-ID: <20140218010503.GF13997@dastard> (raw)
In-Reply-To: <530273CD.3090303@redhat.com>
On Mon, Feb 17, 2014 at 02:40:45PM -0600, Eric Sandeen wrote:
> On 2/17/14, 2:25 PM, Koen De Wit wrote:
> > Tests the noatime, relatime, strictatime and nodiratime mount options.
> >
> > There is an extra check for Btrfs to ensure that the access time is
> > never updated on read-only subvolumes. (Regression test for bug fixed
> > with commit 93fd63c2f001ca6797c6b15b696a484b165b4800)
>
> I think this looks ok. Only little nit is that _require_relatime
> now implicitly requires scratch, but *shrug* it was Dave's idea. ;)
There's a _require_scratch call in there, so it's all good. ;)
Thanks Koen!
> Thanks!
>
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
And thanks for the reivew, Eric ;)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Koen De Wit <koen.de.wit@oracle.com>,
linux-btrfs@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH v2] xfstests: test for atime-related mount options
Date: Tue, 18 Feb 2014 12:05:03 +1100 [thread overview]
Message-ID: <20140218010503.GF13997@dastard> (raw)
In-Reply-To: <530273CD.3090303@redhat.com>
On Mon, Feb 17, 2014 at 02:40:45PM -0600, Eric Sandeen wrote:
> On 2/17/14, 2:25 PM, Koen De Wit wrote:
> > Tests the noatime, relatime, strictatime and nodiratime mount options.
> >
> > There is an extra check for Btrfs to ensure that the access time is
> > never updated on read-only subvolumes. (Regression test for bug fixed
> > with commit 93fd63c2f001ca6797c6b15b696a484b165b4800)
>
> I think this looks ok. Only little nit is that _require_relatime
> now implicitly requires scratch, but *shrug* it was Dave's idea. ;)
There's a _require_scratch call in there, so it's all good. ;)
Thanks Koen!
> Thanks!
>
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
And thanks for the reivew, Eric ;)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-02-18 1:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 20:25 [PATCH v2] xfstests: test for atime-related mount options Koen De Wit
2014-02-17 20:25 ` Koen De Wit
2014-02-17 20:40 ` Eric Sandeen
2014-02-17 20:40 ` Eric Sandeen
2014-02-18 1:05 ` Dave Chinner [this message]
2014-02-18 1:05 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140218010503.GF13997@dastard \
--to=david@fromorbit.com \
--cc=koen.de.wit@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.