From: Magnus Damm <magnus.damm@gmail.com>
To: linux-pci@vger.kernel.org
Cc: horms@verge.net.au, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org,
valentine.barshak@cogentembedded.com, ben.dooks@codethink.co.uk,
geert@linux-m68k.org, bhelgaas@google.com,
Magnus Damm <magnus.damm@gmail.com>
Subject: [PATCH 01/08] PCI: rcar: check platform_get_irq() return code
Date: Tue, 18 Feb 2014 11:10:51 +0900 [thread overview]
Message-ID: <20140218021051.14164.6194.sendpatchset@w520> (raw)
In-Reply-To: <20140218021041.14164.56411.sendpatchset@w520>
From: Ben Dooks <ben.dooks@codethink.co.uk>
The current code does not check the return from platform_get_irq()
so add an error check and return if this call does fail.
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Signed-off-by: Magnus Damm <damm@opensource.se>
---
drivers/pci/host/pci-rcar-gen2.c | 5 +++++
1 file changed, 5 insertions(+)
--- 0001/drivers/pci/host/pci-rcar-gen2.c
+++ work/drivers/pci/host/pci-rcar-gen2.c 2014-02-13 09:41:55.000000000 +0900
@@ -308,6 +308,11 @@ static int __init rcar_pci_probe(struct
priv->reg = reg;
priv->dev = &pdev->dev;
+ if (priv->irq < 0) {
+ dev_err(&pdev->dev, "no valid irq found\n");
+ return priv->irq;
+ }
+
return rcar_pci_add_controller(priv);
}
WARNING: multiple messages have this Message-ID (diff)
From: Magnus Damm <magnus.damm@gmail.com>
To: linux-pci@vger.kernel.org
Cc: horms@verge.net.au, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org,
valentine.barshak@cogentembedded.com, ben.dooks@codethink.co.uk,
geert@linux-m68k.org, bhelgaas@google.com,
Magnus Damm <magnus.damm@gmail.com>
Subject: [PATCH 01/08] PCI: rcar: check platform_get_irq() return code
Date: Tue, 18 Feb 2014 02:10:51 +0000 [thread overview]
Message-ID: <20140218021051.14164.6194.sendpatchset@w520> (raw)
In-Reply-To: <20140218021041.14164.56411.sendpatchset@w520>
From: Ben Dooks <ben.dooks@codethink.co.uk>
The current code does not check the return from platform_get_irq()
so add an error check and return if this call does fail.
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Signed-off-by: Magnus Damm <damm@opensource.se>
---
drivers/pci/host/pci-rcar-gen2.c | 5 +++++
1 file changed, 5 insertions(+)
--- 0001/drivers/pci/host/pci-rcar-gen2.c
+++ work/drivers/pci/host/pci-rcar-gen2.c 2014-02-13 09:41:55.000000000 +0900
@@ -308,6 +308,11 @@ static int __init rcar_pci_probe(struct
priv->reg = reg;
priv->dev = &pdev->dev;
+ if (priv->irq < 0) {
+ dev_err(&pdev->dev, "no valid irq found\n");
+ return priv->irq;
+ }
+
return rcar_pci_add_controller(priv);
}
next prev parent reply other threads:[~2014-02-18 2:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 2:10 [PATCH v2 00/08] PCI: rcar: Recent driver patches from Ben Dooks and me (V2) Magnus Damm
2014-02-18 2:10 ` Magnus Damm
2014-02-18 2:10 ` Magnus Damm [this message]
2014-02-18 2:10 ` [PATCH 01/08] PCI: rcar: check platform_get_irq() return code Magnus Damm
2014-02-18 2:11 ` [PATCH v2 02/08] PCI: rcar: add error interrupt handling Magnus Damm
2014-02-18 2:11 ` Magnus Damm
2014-02-18 2:11 ` [PATCH 03/08] PCI: rcar: fix bridge logic configuration accesses Magnus Damm
2014-02-18 2:11 ` Magnus Damm
2014-02-18 2:11 ` [PATCH v3 04/08] PCI: rcar: Register each instance independently Magnus Damm
2014-02-18 2:11 ` Magnus Damm
2014-02-18 2:11 ` [PATCH v2 05/08] PCI: rcar: Break out window size handling Magnus Damm
2014-02-18 2:11 ` Magnus Damm
2014-02-18 2:11 ` [PATCH v2 06/08] PCI: rcar: Add DMABOUNCE support Magnus Damm
2014-02-18 2:11 ` Magnus Damm
2014-02-18 2:11 ` [PATCH 07/08] PCI: rcar: Enable BOUNCE in case of HIGHMEM Magnus Damm
2014-02-18 2:11 ` Magnus Damm
2014-02-18 2:12 ` [PATCH 08/08] PCI: rcar: Make the Kconfig dependencies more generic Magnus Damm
2014-02-18 2:12 ` Magnus Damm
-- strict thread matches above, loose matches on Subject: below --
2014-02-13 3:03 [PATCH 00/08] PCI: rcar: Recent driver patches from Ben Dooks and me Magnus Damm
2014-02-13 3:03 ` [PATCH 01/08] PCI: rcar: check platform_get_irq() return code Magnus Damm
2014-02-13 3:03 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140218021051.14164.6194.sendpatchset@w520 \
--to=magnus.damm@gmail.com \
--cc=ben.dooks@codethink.co.uk \
--cc=bhelgaas@google.com \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=valentine.barshak@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.