Re: [PATCH 01/10] mfd: Add TI LMU driver

[Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>]

> >>+static const struct resource lm3633_effect_resources[] = {
> >>+	{
> >>+		.name  = LM3633_EFFECT_BL0_RAMPUP,
> >>+		.flags = IORESOURCE_REG,
> >>+		.start = LM3633_EFFECT_REGISTER(BL0_RAMPUP),
> >>+	},

<snip>

> >>+	{
> >>+		.name  = LM3633_EFFECT_PTN_HIGHBRT,
> >>+		.flags = IORESOURCE_REG,
> >>+		.start = LM3633_EFFECT_REGISTER(HIGHBRT),
> >>+	},
> >>+};
> >
> >Can you define a MACRO to do all of these as one liners?
> 
> Yes, resource definitions will be replaced by simple macro,
> LMU_EFFECT_RESOURCE().
> 
> For example,
> 
> #define LMU_EFFECT_RESOURCE(chip, effect)               \
> {                                                       \
>         .name  = chip##_EFFECT_##effect,                \
>         .flags = IORESOURCE_REG,                        \
>         .start = LMU_EFFECT_REGISTER(chip, effect),     \
> }
> 
> static const struct resource lm3633_effect_resources[] = {
>         LMU_EFFECT_RESOURCE(LM3633, BL0_RAMPUP),

<snip>

>         LMU_EFFECT_RESOURCE(LM3633, PTN_HIGHBRT),
> };
> 
> and so on.

Yes, this is what I had in mind.

> >>+	pdata->en_gpio = of_get_named_gpio(node, "ti,enable-gpio", 0);
> >
> >There is a global DT property for this already.
> 
> I've not found it yet, but I agree it looks like general property.
> So I'll replace "ti,enable-gpio" with "ti,lmu-en-gpio".

Just re-use "gpio-enable". No need for it to be vendor specific.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html