All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: regmap: Separate regmap dev initialization
Date: Tue, 18 Feb 2014 12:24:10 +0000	[thread overview]
Message-ID: <20140218122410.GA9825@elgon.mountain> (raw)

Hello Michal Simek,

The patch 6cfec04bcc05: "regmap: Separate regmap dev initialization"
from Feb 10, 2014, leads to the following static checker warning:

	drivers/base/regmap/regmap.c:765 regmap_init()
	warn: add curly braces?

drivers/base/regmap/regmap.c
   759          ret = regcache_init(map, config);
   760          if (ret != 0)
   761                  goto err_range;
   762  
   763          if (dev)
   764                  ret = regmap_attach_dev(dev, map, config);
   765                  if (ret != 0)
   766                          goto err_regcache;

Please add curly braces or adjust the indenting to not confuse the
static checkers.

   767  
   768          return map;

regards,
dan carpenter

             reply	other threads:[~2014-02-18 12:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-18 12:24 Dan Carpenter [this message]
2014-02-18 12:33 ` regmap: Separate regmap dev initialization Michal Simek
2014-02-18 12:59 ` Dan Carpenter
2014-02-18 13:10 ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140218122410.GA9825@elgon.mountain \
    --to=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.