* [patch] [media] gspca_stv06xx: remove an unneeded check
@ 2014-02-18 15:00 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2014-02-18 15:00 UTC (permalink / raw)
To: Hans de Goede
Cc: Mauro Carvalho Chehab, Theodore Kilgore, linux-media,
kernel-janitors
"err" is zero here so we don't need to check again.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/media/usb/gspca/stv06xx/stv06xx_vv6410.c b/drivers/media/usb/gspca/stv06xx/stv06xx_vv6410.c
index bf3e5c317a26..e60cbb3aa609 100644
--- a/drivers/media/usb/gspca/stv06xx/stv06xx_vv6410.c
+++ b/drivers/media/usb/gspca/stv06xx/stv06xx_vv6410.c
@@ -178,7 +178,7 @@ static int vv6410_stop(struct sd *sd)
PDEBUG(D_STREAM, "Halting stream");
- return (err < 0) ? err : 0;
+ return 0;
}
static int vv6410_dump(struct sd *sd)
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch] [media] gspca_stv06xx: remove an unneeded check
@ 2014-02-18 15:00 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2014-02-18 15:00 UTC (permalink / raw)
To: Hans de Goede
Cc: Mauro Carvalho Chehab, Theodore Kilgore, linux-media,
kernel-janitors
"err" is zero here so we don't need to check again.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/media/usb/gspca/stv06xx/stv06xx_vv6410.c b/drivers/media/usb/gspca/stv06xx/stv06xx_vv6410.c
index bf3e5c317a26..e60cbb3aa609 100644
--- a/drivers/media/usb/gspca/stv06xx/stv06xx_vv6410.c
+++ b/drivers/media/usb/gspca/stv06xx/stv06xx_vv6410.c
@@ -178,7 +178,7 @@ static int vv6410_stop(struct sd *sd)
PDEBUG(D_STREAM, "Halting stream");
- return (err < 0) ? err : 0;
+ return 0;
}
static int vv6410_dump(struct sd *sd)
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] [media] gspca_stv06xx: remove an unneeded check
2014-02-18 15:00 ` Dan Carpenter
@ 2014-02-23 21:47 ` Hans de Goede
-1 siblings, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2014-02-23 21:47 UTC (permalink / raw)
To: Dan Carpenter
Cc: Mauro Carvalho Chehab, Theodore Kilgore, linux-media,
kernel-janitors
Hi,
On 02/18/2014 04:00 PM, Dan Carpenter wrote:
> "err" is zero here so we don't need to check again.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/media/usb/gspca/stv06xx/stv06xx_vv6410.c b/drivers/media/usb/gspca/stv06xx/stv06xx_vv6410.c
> index bf3e5c317a26..e60cbb3aa609 100644
> --- a/drivers/media/usb/gspca/stv06xx/stv06xx_vv6410.c
> +++ b/drivers/media/usb/gspca/stv06xx/stv06xx_vv6410.c
> @@ -178,7 +178,7 @@ static int vv6410_stop(struct sd *sd)
>
> PDEBUG(D_STREAM, "Halting stream");
>
> - return (err < 0) ? err : 0;
> + return 0;
> }
>
> static int vv6410_dump(struct sd *sd)
>
Thanks I've added this to my gspca tree for 3.15.
Regards,
Hans
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] [media] gspca_stv06xx: remove an unneeded check
@ 2014-02-23 21:47 ` Hans de Goede
0 siblings, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2014-02-23 21:47 UTC (permalink / raw)
To: Dan Carpenter
Cc: Mauro Carvalho Chehab, Theodore Kilgore, linux-media,
kernel-janitors
Hi,
On 02/18/2014 04:00 PM, Dan Carpenter wrote:
> "err" is zero here so we don't need to check again.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/media/usb/gspca/stv06xx/stv06xx_vv6410.c b/drivers/media/usb/gspca/stv06xx/stv06xx_vv6410.c
> index bf3e5c317a26..e60cbb3aa609 100644
> --- a/drivers/media/usb/gspca/stv06xx/stv06xx_vv6410.c
> +++ b/drivers/media/usb/gspca/stv06xx/stv06xx_vv6410.c
> @@ -178,7 +178,7 @@ static int vv6410_stop(struct sd *sd)
>
> PDEBUG(D_STREAM, "Halting stream");
>
> - return (err < 0) ? err : 0;
> + return 0;
> }
>
> static int vv6410_dump(struct sd *sd)
>
Thanks I've added this to my gspca tree for 3.15.
Regards,
Hans
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-02-23 21:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-18 15:00 [patch] [media] gspca_stv06xx: remove an unneeded check Dan Carpenter
2014-02-18 15:00 ` Dan Carpenter
2014-02-23 21:47 ` Hans de Goede
2014-02-23 21:47 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.