From: Thierry Reding <thierry.reding@gmail.com>
To: Erik Faye-Lund <kusmabite@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [RFC libdrm 2/6] libdrm: Add NVIDIA Tegra support
Date: Wed, 19 Feb 2014 22:33:46 +0100 [thread overview]
Message-ID: <20140219213345.GB31663@ulmo.nvidia.com> (raw)
In-Reply-To: <CABPQNSbbQAKo3VfPHbuGo98uGbmdkRDW4Q05fuJ0+_-XU+EUhg@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 851 bytes --]
On Wed, Feb 19, 2014 at 09:03:51PM +0100, Erik Faye-Lund wrote:
> On Wed, Feb 19, 2014 at 5:04 PM, Thierry Reding
> <thierry.reding@gmail.com> wrote:
> > +#ifndef __DRM_TEGRA_PRIVATE_H__
> > +#define __DRM_TEGRA_PRIVATE_H__ 1
> > +
> > +#include <stdbool.h>
> > +#include <stdint.h>
> > +
> > +#include <xf86atomic.h>
> > +
> > +#include "tegra.h"
> > +
> > +#if defined(HAVE_VISIBILITY)
> > +# define drm_private __attribute__((visibility("hidden")))
> > +# define drm_public __attribute__((visibility("default")))
> > +#else
> > +# define drm_private
> > +# define drm_public
> > +#endif
> > +
>
> Perhaps you could put this where it's visible to other drivers as
> well, like xf86drm.h?
I'd prefer to keep this here for now. We can move it to a more central
location when another module starts using it.
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2014-02-19 21:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 16:04 [RFC libdrm 0/6] Add NVIDIA Tegra support Thierry Reding
2014-02-19 16:04 ` [RFC libdrm 1/6] configure: Support symbol visibility when available Thierry Reding
2014-02-19 21:05 ` Erik Faye-Lund
2014-02-19 21:50 ` Thierry Reding
2014-02-19 16:04 ` [RFC libdrm 2/6] libdrm: Add NVIDIA Tegra support Thierry Reding
2014-02-19 19:59 ` Rémi Cardona
2014-02-19 20:03 ` Erik Faye-Lund
2014-02-19 21:33 ` Thierry Reding [this message]
2014-02-19 20:13 ` Erik Faye-Lund
2014-02-19 21:32 ` Thierry Reding
2014-02-19 16:04 ` [RFC libdrm 3/6] tegra: Add simple test for drm_tegra_open() Thierry Reding
2014-02-19 20:19 ` Erik Faye-Lund
2014-02-19 20:50 ` Erik Faye-Lund
2014-02-19 21:34 ` Erik Faye-Lund
2014-02-19 16:04 ` [RFC libdrm 4/6] tegra: Add channel, job, pushbuf and fence APIs Thierry Reding
2014-02-19 19:57 ` Erik Faye-Lund
2014-02-19 21:11 ` Thierry Reding
2014-02-19 16:04 ` [RFC libdrm 5/6] tegra: Add helper library for tests Thierry Reding
2014-02-19 20:54 ` Erik Faye-Lund
2014-02-19 16:04 ` [RFC libdrm 6/6] tegra: Add gr2d-fill test Thierry Reding
2014-02-19 21:03 ` Erik Faye-Lund
2014-02-19 21:49 ` Thierry Reding
2014-03-20 15:23 ` [RFC libdrm 0/6] Add NVIDIA Tegra support Erik Faye-Lund
2014-04-08 12:58 ` Erik Faye-Lund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140219213345.GB31663@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kusmabite@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.